From: Oliver O'Halloran <oohall@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Oliver O'Halloran <oohall@gmail.com>
Subject: [PATCH 3/5] powerpc/zImage: Check compatible at driver init
Date: Mon, 19 Mar 2018 16:14:01 +1100 [thread overview]
Message-ID: <20180319051403.23275-3-oohall@gmail.com> (raw)
In-Reply-To: <20180319051403.23275-1-oohall@gmail.com>
Have each driver's init function check the compatible string
of the node given by the stdout path. This gives the drivers
a more traditional probe-also-inits structure.
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
---
arch/powerpc/boot/cpm-serial.c | 2 ++
arch/powerpc/boot/mpc52xx-psc.c | 3 +++
arch/powerpc/boot/mpsc.c | 3 +++
arch/powerpc/boot/ns16550.c | 4 ++++
arch/powerpc/boot/opal.c | 3 +++
arch/powerpc/boot/uartlite.c | 5 +++++
6 files changed, 20 insertions(+)
diff --git a/arch/powerpc/boot/cpm-serial.c b/arch/powerpc/boot/cpm-serial.c
index dfb56829cace..f6b1cf23946e 100644
--- a/arch/powerpc/boot/cpm-serial.c
+++ b/arch/powerpc/boot/cpm-serial.c
@@ -212,6 +212,8 @@ int cpm_console_init(void *devp, struct serial_console_data *scdp)
} else if (dt_is_compatible(devp, "fsl,cpm2-smc-uart")) {
is_cpm2 = 1;
is_smc = 1;
+ } else if (!dt_is_compatible(devp, "fsl,cpm1-scc-uart")) {
+ return 1; /* not compatible */
}
if (is_smc) {
diff --git a/arch/powerpc/boot/mpc52xx-psc.c b/arch/powerpc/boot/mpc52xx-psc.c
index c2c08633ee35..75470936e661 100644
--- a/arch/powerpc/boot/mpc52xx-psc.c
+++ b/arch/powerpc/boot/mpc52xx-psc.c
@@ -52,6 +52,9 @@ static unsigned char psc_getc(void)
int mpc5200_psc_console_init(void *devp, struct serial_console_data *scdp)
{
+ if (!dt_is_compatible(devp, "fsl,mpc5200-psc-uart"))
+ return 1;
+
/* Get the base address of the psc registers */
if (dt_get_virtual_reg(devp, &psc, 1) < 1)
return -1;
diff --git a/arch/powerpc/boot/mpsc.c b/arch/powerpc/boot/mpsc.c
index 425ad88cce8d..59e23e886440 100644
--- a/arch/powerpc/boot/mpsc.c
+++ b/arch/powerpc/boot/mpsc.c
@@ -128,6 +128,9 @@ int mpsc_console_init(void *devp, struct serial_console_data *scdp)
int n, reg_set;
volatile char *sdma_base;
+ if (!dt_is_compatible(devp, "marvell,mv64360-mpsc"))
+ return 1;
+
n = getprop(devp, "virtual-reg", &v, sizeof(v));
if (n != sizeof(v))
goto err_out;
diff --git a/arch/powerpc/boot/ns16550.c b/arch/powerpc/boot/ns16550.c
index b0da4466d419..0e7bd5284255 100644
--- a/arch/powerpc/boot/ns16550.c
+++ b/arch/powerpc/boot/ns16550.c
@@ -58,6 +58,10 @@ int ns16550_console_init(void *devp, struct serial_console_data *scdp)
int n;
u32 reg_offset;
+ if (!dt_is_compatible(devp, "ns16550") &&
+ !dt_is_compatible(devp, "pnpPNP,501"))
+ return 1;
+
if (dt_get_virtual_reg(devp, (void **)®_base, 1) < 1)
return -1;
diff --git a/arch/powerpc/boot/opal.c b/arch/powerpc/boot/opal.c
index dfb199ef5b94..0e92537536b9 100644
--- a/arch/powerpc/boot/opal.c
+++ b/arch/powerpc/boot/opal.c
@@ -83,6 +83,9 @@ static void opal_init(void)
int opal_console_init(void *devp, struct serial_console_data *scdp)
{
+ if (!dt_is_compatible(devp, "ibm,opal-console-raw"))
+ return 1;
+
opal_init();
if (devp) {
diff --git a/arch/powerpc/boot/uartlite.c b/arch/powerpc/boot/uartlite.c
index 46bed69b4169..fc66a5fcea66 100644
--- a/arch/powerpc/boot/uartlite.c
+++ b/arch/powerpc/boot/uartlite.c
@@ -62,6 +62,11 @@ int uartlite_console_init(void *devp, struct serial_console_data *scdp)
int n;
unsigned long reg_phys;
+
+ if (!dt_is_compatible(devp, "xlnx,opb-uartlite-1.00.b") &&
+ !dt_is_compatible(devp, "xlnx,xps-uartlite-1.00.a"))
+ return 1;
+
n = getprop(devp, "virtual-reg", ®_base, sizeof(reg_base));
if (n != sizeof(reg_base)) {
if (!dt_xlate_reg(devp, 0, ®_phys, NULL))
--
2.9.5
next prev parent reply other threads:[~2018-03-19 5:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 5:13 [PATCH 1/5] powerpc/zImage: Remove #ifdef in opal.c Oliver O'Halloran
2018-03-19 5:14 ` [PATCH 2/5] powerpc/zImage: Don't build zlib object files Oliver O'Halloran
2018-03-19 5:14 ` Oliver O'Halloran [this message]
2018-03-20 9:19 ` [PATCH 3/5] powerpc/zImage: Check compatible at driver init Michael Ellerman
2018-03-20 12:56 ` Oliver
2018-03-19 5:14 ` [PATCH 4/5] powerpc/zImage: Rework serial driver probing Oliver O'Halloran
2018-03-20 7:50 ` kbuild test robot
2018-03-20 8:04 ` kbuild test robot
2018-03-20 9:20 ` Michael Ellerman
2018-03-20 13:05 ` Oliver
2018-03-19 5:14 ` [PATCH 5/5] powerpc/zImage: Also check for stdout-path Oliver O'Halloran
2018-12-23 13:28 ` [5/5] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319051403.23275-3-oohall@gmail.com \
--to=oohall@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).