From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: benh@kernel.crashing.org, tlfalcon@linux.vnet.ibm.com,
jallen@linux.vnet.ibm.com, paulus@samba.org, mpe@ellerman.id.au,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] ibmvnic: Potential NULL dereference in clean_one_tx_pool()
Date: Sun, 25 Mar 2018 21:14:17 -0400 (EDT) [thread overview]
Message-ID: <20180325.211417.809927177270425883.davem@davemloft.net> (raw)
In-Reply-To: <20180323113615.GA28518@mwanda>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 23 Mar 2018 14:36:15 +0300
> There is an && vs || typo here, which potentially leads to a NULL
> dereference.
>
> Fixes: e9e1e97884b7 ("ibmvnic: Update TX pool cleaning routine")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
prev parent reply other threads:[~2018-03-26 1:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 11:36 [PATCH net-next] ibmvnic: Potential NULL dereference in clean_one_tx_pool() Dan Carpenter
2018-03-23 15:06 ` Thomas Falcon
2018-03-26 1:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180325.211417.809927177270425883.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=dan.carpenter@oracle.com \
--cc=jallen@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).