From: Balbir Singh <bsingharora@gmail.com>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-nvdimm@lists.01.org,
mpe@ellerman.id.au
Subject: Re: [RESEND 1/3] powerpc/mce: Bug fixes for MCE handling in kernel space
Date: Thu, 5 Apr 2018 11:11:56 +1000 [thread overview]
Message-ID: <20180405111156.09cd3150@gmail.com> (raw)
In-Reply-To: <20180405094900.3ce4be8b@roar.ozlabs.ibm.com>
On Thu, 5 Apr 2018 09:49:00 +1000
Nicholas Piggin <npiggin@gmail.com> wrote:
> On Thu, 5 Apr 2018 09:19:41 +1000
> Balbir Singh <bsingharora@gmail.com> wrote:
>
> > The code currently assumes PAGE_SHIFT as the shift value of
> > the pfn, this works correctly (mostly) for user space pages,
> > but the correct thing to do is
>
> It would be good to actually explain the problem in the
> changelog. I would have thought pte_pfn returns a
> PAGE_SIZE based pfn value?
>
The issue is hidden inside of hugepte_offset() as invoked by __find_linux_pte().
I will send a new version because the code needs to do
<< (shift - PAGE_SHIFT) for instruction address.
> >
> > 1. Extrace the shift value returned via the pte-walk API's
>
> ^^^ extract?
Thanks, yes, typo!
Balbir Singh.
next prev parent reply other threads:[~2018-04-05 1:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 23:19 [RESEND 0/3] Add support for memcpy_mcsafe Balbir Singh
2018-04-04 23:19 ` [RESEND 1/3] powerpc/mce: Bug fixes for MCE handling in kernel space Balbir Singh
2018-04-04 23:49 ` Nicholas Piggin
2018-04-05 1:11 ` Balbir Singh [this message]
2018-04-04 23:19 ` [RESEND 2/3] powerpc/memcpy: Add memcpy_mcsafe for pmem Balbir Singh
2018-04-04 23:57 ` Nicholas Piggin
2018-04-05 3:00 ` Dan Williams
2018-04-05 5:04 ` Nicholas Piggin
2018-04-05 5:53 ` Balbir Singh
2018-04-05 6:45 ` Nicholas Piggin
2018-04-05 15:00 ` Dan Williams
2018-05-01 20:57 ` Dan Williams
2018-05-02 12:36 ` Balbir Singh
2018-04-05 20:40 ` Jeff Moyer
2018-04-06 1:26 ` Nicholas Piggin
2018-04-06 9:25 ` Balbir Singh
2018-04-06 15:46 ` Luck, Tony
2018-04-04 23:19 ` [RESEND 3/3] powerpc/mce: Handle memcpy_mcsafe Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405111156.09cd3150@gmail.com \
--to=bsingharora@gmail.com \
--cc=linux-nvdimm@lists.01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).