From: Matthew Wilcox <willy@infradead.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: Jeremy Kerr <jk@ozlabs.org>, Arnd Bergmann <arnd@arndb.de>,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: platform: cell: spufs: Change return type to vm_fault_t
Date: Wed, 18 Apr 2018 12:27:32 -0700 [thread overview]
Message-ID: <20180418192732.GD30953@bombadil.infradead.org> (raw)
In-Reply-To: <CAFqt6zbhHm7s=_N8QOh-+qcw=dbyx-qgq3ajp3OmGLGYANO0ww@mail.gmail.com>
On Thu, Apr 19, 2018 at 12:34:15AM +0530, Souptick Joarder wrote:
> > Re-reading spufs_ps_fault(), I wouldn't change anything inside it. Just
> > change its return type to vm_fault_t and call it done.
>
> In that case, return value of spufs_wait() has to changed
> to VM_FAULT_ type and we end with changing all the
> references where spufs_wait() is called. I think we shouldn't
> go with that approach. That's the reason I introduce inline
> vmf_handle_error() and convert err to VM_FAULT_ type.
No, don't change the type of 'ret' or spufs_wait. Just do this:
-static int spufs_ps_fault(struct vm_fault *vmf,
+static vm_fault_t spufs_ps_fault(struct vm_fault *vmf,
unsigned long ps_offs,
unsigned long ps_size)
next prev parent reply other threads:[~2018-04-18 19:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 19:20 [PATCH] powerpc: platform: cell: spufs: Change return type to vm_fault_t Souptick Joarder
2018-04-17 19:43 ` Arnd Bergmann
2018-04-17 20:47 ` Matthew Wilcox
2018-04-18 19:04 ` Souptick Joarder
2018-04-18 19:27 ` Matthew Wilcox [this message]
2018-04-18 19:33 ` Souptick Joarder
2018-04-18 19:38 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418192732.GD30953@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=jk@ozlabs.org \
--cc=jrdr.linux@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).