From: Sam Bobroff <sbobroff@linux.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 03/13] powerpc/eeh: Fix use-after-release of EEH driver
Date: Mon, 7 May 2018 15:38:38 +1000 [thread overview]
Message-ID: <20180507053837.GE18123@tungsten.ozlabs.ibm.com> (raw)
In-Reply-To: <871ses9lhk.fsf@concordia.ellerman.id.au>
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
On Fri, May 04, 2018 at 12:56:55PM +1000, Michael Ellerman wrote:
> Sam Bobroff <sbobroff@linux.ibm.com> writes:
>
> > Correct two cases where eeh_pcid_get() is used to reference the driver's
> > module but the reference is dropped before the driver pointer is used.
> >
> > In eeh_rmv_device() also refactor a little so that only two calls to
> > eeh_pcid_put() are needed, rather than three and the reference isn't
> > taken at all if it wasn't needed.
>
> This sounds like a crash or memory corruption bug?
>
> But it doesn't have Fixes or Cc: stable. Is it not a major problem for
> some reason?
Only that I've exercised that code path a fair bit during testing and
never managed to cause a problem with it. I found it by inspection.
Do you think I should mark it fixes or stable in the next version?
> cheers
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-05-07 5:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 6:34 [PATCH 00/13] EEH refactoring 2 Sam Bobroff
2018-05-02 6:34 ` [PATCH 01/13] powerpc/eeh: Add eeh_max_freezes to initial EEH log line Sam Bobroff
2018-05-04 5:46 ` Russell Currey
2018-05-02 6:35 ` [PATCH 02/13] powerpc/eeh: Add final message for successful recovery Sam Bobroff
2018-05-04 2:55 ` Michael Ellerman
2018-05-04 6:08 ` Russell Currey
2018-05-07 5:35 ` Sam Bobroff
2018-05-07 5:29 ` Sam Bobroff
2018-05-02 6:35 ` [PATCH 03/13] powerpc/eeh: Fix use-after-release of EEH driver Sam Bobroff
2018-05-04 2:56 ` Michael Ellerman
2018-05-07 5:38 ` Sam Bobroff [this message]
2018-05-02 6:35 ` [PATCH 04/13] powerpc/eeh: Remove unused eeh_pcid_name() Sam Bobroff
2018-05-04 6:29 ` Russell Currey
2018-05-02 6:35 ` [PATCH 05/13] powerpc/eeh: Strengthen types of eeh traversal functions Sam Bobroff
2018-05-04 6:32 ` Russell Currey
2018-05-02 6:35 ` [PATCH 06/13] powerpc/eeh: Add message when PE processing at parent Sam Bobroff
2018-05-04 6:51 ` Russell Currey
2018-05-02 6:36 ` [PATCH 07/13] powerpc/eeh: Clean up pci_ers_result handling Sam Bobroff
2018-05-04 2:58 ` Michael Ellerman
2018-05-04 6:58 ` Russell Currey
2018-05-08 1:09 ` Sam Bobroff
2018-05-02 6:36 ` [PATCH 08/13] powerpc/eeh: Introduce eeh_for_each_pe() Sam Bobroff
2018-05-04 6:59 ` Russell Currey
2018-05-02 6:36 ` [PATCH 09/13] powerpc/eeh: Introduce eeh_edev_actionable() Sam Bobroff
2018-05-02 6:36 ` [PATCH 10/13] powerpc/eeh: Introduce eeh_set_channel_state() Sam Bobroff
2018-05-02 6:36 ` [PATCH 11/13] powerpc/eeh: Introduce eeh_set_irq_state() Sam Bobroff
2018-05-04 3:02 ` Michael Ellerman
2018-05-08 1:12 ` Sam Bobroff
2018-05-02 6:36 ` [PATCH 12/13] powerpc/eeh: Cleaner handling of EEH_DEV_NO_HANDLER Sam Bobroff
2018-05-02 6:36 ` [PATCH 13/13] powerpc/eeh: Refactor report functions Sam Bobroff
2018-05-03 13:27 ` Michael Ellerman
2018-05-07 5:23 ` Sam Bobroff
2018-05-09 14:51 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507053837.GE18123@tungsten.ozlabs.ibm.com \
--to=sbobroff@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).