From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Torsten Duwe <duwe@lst.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Jiri Kosina <jkosina@suse.cz>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Nicholas Piggin <npiggin@gmail.com>,
live-patching@vger.kernel.org
Subject: Re: [PATCH v3] ppc64le livepatch: implement reliable stacktrace for newer consistency models
Date: Tue, 8 May 2018 19:14:32 -0500 [thread overview]
Message-ID: <20180509001432.5nd55ictwf5yi7sm@treble> (raw)
In-Reply-To: <20180508103832.085378b9@blackhole.lan>
On Tue, May 08, 2018 at 10:38:32AM +0200, Torsten Duwe wrote:
> On Mon, 7 May 2018 10:42:08 -0500
> Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> > The subject doesn't actively describe what the patch does, maybe
> > change it to something like:
> >
> > powerpc: Add support for HAVE_RELIABLE_STACKTRACE
> >
> > or maybe
> >
> > powerpc: Add support for livepatch consistency model
>
> Maybe $SUBJECT? You're absolutely right, the old subject was just a
> leftover of my original attempt to just set the flag, before Miroslav
> corrected me. I just kept on copying it without a second thought. Thanks
> for noting.
Generally we refer to it as "the consistency model". So I would
propose a minor edit:
ppc64le/livepatch: Implement reliable stack tracing for the consistency model
> > Otherwise it looks great to me.
> >
> > Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
> >
> Thanks.
>
> Torsten
>
--
Josh
next prev parent reply other threads:[~2018-05-09 0:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 16:49 [PATCH v2] On ppc64le we HAVE_RELIABLE_STACKTRACE Torsten Duwe
2018-03-05 17:09 ` Segher Boessenkool
2018-03-08 16:26 ` Josh Poimboeuf
2018-03-09 16:47 ` Torsten Duwe
2018-03-12 15:35 ` Josh Poimboeuf
2018-05-04 12:38 ` [PATCH v3] " Torsten Duwe
2018-05-07 15:42 ` Josh Poimboeuf
2018-05-08 8:38 ` [PATCH v3] ppc64le livepatch: implement reliable stacktrace for newer consistency models Torsten Duwe
2018-05-09 0:14 ` Josh Poimboeuf [this message]
2018-05-09 1:41 ` Michael Ellerman
2018-05-09 10:35 ` Torsten Duwe
2018-05-10 14:06 ` [v3] On ppc64le we HAVE_RELIABLE_STACKTRACE Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509001432.5nd55ictwf5yi7sm@treble \
--to=jpoimboe@redhat.com \
--cc=duwe@lst.de \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox