From: Wolfram Sang <wsa@the-dreams.de>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org,
"Brendan Higgins" <brendanhiggins@google.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Guenter Roeck" <linux@roeck-us.net>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Peter Korsgaard" <jacmet@sunsite.dk>,
"Andy Gross" <andy.gross@linaro.org>,
"David Brown" <david.brown@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] i2c: busses: make use of i2c_8bit_addr_from_msg
Date: Tue, 29 May 2018 20:31:43 +0200 [thread overview]
Message-ID: <20180529183143.ker46to34gr5hx3w@ninjato> (raw)
In-Reply-To: <20180516071647.29277-3-peda@axentia.se>
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
On Wed, May 16, 2018 at 09:16:47AM +0200, Peter Rosin wrote:
> Because it looks neater.
>
> For diolan, this allows factoring out some code that is now common
> between if and else.
>
> For eg20t, pch_i2c_writebytes is always called with a write in
> msgs->flags, and pch_i2c_readbytes with a read.
>
> For imx, i2c_imx_dma_write and i2c_imx_write are always called with a
> write in msgs->flags, and i2c_imx_read with a read.
>
> For qup, qup_i2c_write_tx_fifo_v1 is always called with a write in
> qup->msg->flags.
>
> For stu300, also restructure debug output for resends, since that
> code as a result is only handling debug output.
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net> [diolan]
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [emf32 and imx]
> Acked-by: Linus Walleij <linus.walleij@linaro.org> [stu300]
> Signed-off-by: Peter Rosin <peda@axentia.se>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-05-29 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 7:16 [PATCH v2 0/2] i2c: make use of i2c_8bit_addr_from_msg Peter Rosin
2018-05-16 7:16 ` [PATCH v2 1/2] i2c: algos: " Peter Rosin
2018-05-29 18:31 ` Wolfram Sang
2018-05-16 7:16 ` [PATCH v2 2/2] i2c: busses: " Peter Rosin
2018-05-16 7:33 ` Uwe Kleine-König
2018-05-29 18:31 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529183143.ker46to34gr5hx3w@ninjato \
--to=wsa@the-dreams.de \
--cc=andrew@aj.id.au \
--cc=andy.gross@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=david.brown@linaro.org \
--cc=jacmet@sunsite.dk \
--cc=joel@jms.id.au \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=openbmc@lists.ozlabs.org \
--cc=peda@axentia.se \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox