* linux-next: boot messages from today's linux-next
@ 2018-05-29 11:02 Stephen Rothwell
2018-05-29 11:56 ` Mathieu Malaterre
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2018-05-29 11:02 UTC (permalink / raw)
To: Michael Ellerman, Benjamin Herrenschmidt, PowerPC
Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
Mathieu Malaterre
[-- Attachment #1: Type: text/plain, Size: 376 bytes --]
Hi all,
My qemu boots of today's powerpc linux-next kernel produced the following
boot message differences:
-Max number of cores passed to firmware: 2048 (NR_CPUS = 2048)
+Max number of cores passed to firmware: u (NR_CPUS = 2048)
Seemingly caused by commit
eae5f709a4d7 ("powerpc: Add __printf verification to prom_printf")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: boot messages from today's linux-next 2018-05-29 11:02 linux-next: boot messages from today's linux-next Stephen Rothwell @ 2018-05-29 11:56 ` Mathieu Malaterre 2018-05-29 12:00 ` Mathieu Malaterre 2018-05-29 12:23 ` Stephen Rothwell 0 siblings, 2 replies; 6+ messages in thread From: Mathieu Malaterre @ 2018-05-29 11:56 UTC (permalink / raw) To: Stephen Rothwell Cc: Michael Ellerman, Benjamin Herrenschmidt, PowerPC, Linux-Next Mailing List, Linux Kernel Mailing List On Tue, May 29, 2018 at 1:02 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > Hi all, > > My qemu boots of today's powerpc linux-next kernel produced the following > boot message differences: > > -Max number of cores passed to firmware: 2048 (NR_CPUS = 2048) > +Max number of cores passed to firmware: u (NR_CPUS = 2048) > > Seemingly caused by commit > > eae5f709a4d7 ("powerpc: Add __printf verification to prom_printf") My bad. Patch is pending (thanks Michael!): https://patchwork.ozlabs.org/patch/921948/ > -- > Cheers, > Stephen Rothwell ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: boot messages from today's linux-next 2018-05-29 11:56 ` Mathieu Malaterre @ 2018-05-29 12:00 ` Mathieu Malaterre 2018-05-29 12:14 ` Mathieu Malaterre 2018-05-29 12:23 ` Stephen Rothwell 1 sibling, 1 reply; 6+ messages in thread From: Mathieu Malaterre @ 2018-05-29 12:00 UTC (permalink / raw) To: Stephen Rothwell Cc: Michael Ellerman, Benjamin Herrenschmidt, PowerPC, Linux-Next Mailing List, Linux Kernel Mailing List On Tue, May 29, 2018 at 1:56 PM, Mathieu Malaterre <malat@debian.org> wrote: > On Tue, May 29, 2018 at 1:02 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> Hi all, >> >> My qemu boots of today's powerpc linux-next kernel produced the following >> boot message differences: >> >> -Max number of cores passed to firmware: 2048 (NR_CPUS = 2048) >> +Max number of cores passed to firmware: u (NR_CPUS = 2048) >> >> Seemingly caused by commit >> >> eae5f709a4d7 ("powerpc: Add __printf verification to prom_printf") > > My bad. Patch is pending (thanks Michael!): > > https://patchwork.ozlabs.org/patch/921948/ Nope, nevermind this is unrelated. >> -- >> Cheers, >> Stephen Rothwell ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: boot messages from today's linux-next 2018-05-29 12:00 ` Mathieu Malaterre @ 2018-05-29 12:14 ` Mathieu Malaterre 0 siblings, 0 replies; 6+ messages in thread From: Mathieu Malaterre @ 2018-05-29 12:14 UTC (permalink / raw) To: Stephen Rothwell Cc: Michael Ellerman, Benjamin Herrenschmidt, PowerPC, Linux-Next Mailing List, Linux Kernel Mailing List Michael, On Tue, May 29, 2018 at 2:00 PM, Mathieu Malaterre <malat@debian.org> wrote: > On Tue, May 29, 2018 at 1:56 PM, Mathieu Malaterre <malat@debian.org> wrote: >> On Tue, May 29, 2018 at 1:02 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: >>> Hi all, >>> >>> My qemu boots of today's powerpc linux-next kernel produced the following >>> boot message differences: >>> >>> -Max number of cores passed to firmware: 2048 (NR_CPUS = 2048) >>> +Max number of cores passed to firmware: u (NR_CPUS = 2048) >>> >>> Seemingly caused by commit >>> >>> eae5f709a4d7 ("powerpc: Add __printf verification to prom_printf") >> >> My bad. Patch is pending (thanks Michael!): >> >> https://patchwork.ozlabs.org/patch/921948/ > > Nope, nevermind this is unrelated. Could you update your patch "powerpc/prom: Fix %llx usage since prom_printf() change" to also do "powerpc/prom: Fix %u usage since prom_printf() change" I did not pay attention that "%u" was also not supported in prom_printf. I may be able to provide a patch tonight, if this is not acceptable, please revert my faulty patch. Sorry for the mess. >>> -- >>> Cheers, >>> Stephen Rothwell ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: boot messages from today's linux-next 2018-05-29 11:56 ` Mathieu Malaterre 2018-05-29 12:00 ` Mathieu Malaterre @ 2018-05-29 12:23 ` Stephen Rothwell 2018-05-29 12:39 ` Mathieu Malaterre 1 sibling, 1 reply; 6+ messages in thread From: Stephen Rothwell @ 2018-05-29 12:23 UTC (permalink / raw) To: Mathieu Malaterre Cc: Michael Ellerman, Benjamin Herrenschmidt, PowerPC, Linux-Next Mailing List, Linux Kernel Mailing List [-- Attachment #1: Type: text/plain, Size: 769 bytes --] Hi Mathieu, On Tue, 29 May 2018 13:56:48 +0200 Mathieu Malaterre <malat@debian.org> wrote: > > On Tue, May 29, 2018 at 1:02 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > Hi all, > > > > My qemu boots of today's powerpc linux-next kernel produced the following > > boot message differences: > > > > -Max number of cores passed to firmware: 2048 (NR_CPUS = 2048) > > +Max number of cores passed to firmware: u (NR_CPUS = 2048) > > > > Seemingly caused by commit > > > > eae5f709a4d7 ("powerpc: Add __printf verification to prom_printf") > > My bad. Patch is pending (thanks Michael!): > > https://patchwork.ozlabs.org/patch/921948/ Umm, that fixes some other messages, but not this particular one. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: boot messages from today's linux-next 2018-05-29 12:23 ` Stephen Rothwell @ 2018-05-29 12:39 ` Mathieu Malaterre 0 siblings, 0 replies; 6+ messages in thread From: Mathieu Malaterre @ 2018-05-29 12:39 UTC (permalink / raw) To: Stephen Rothwell Cc: Michael Ellerman, Benjamin Herrenschmidt, PowerPC, Linux-Next Mailing List, Linux Kernel Mailing List Stephen, On Tue, May 29, 2018 at 2:23 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > Hi Mathieu, > > On Tue, 29 May 2018 13:56:48 +0200 Mathieu Malaterre <malat@debian.org> wrote: >> >> On Tue, May 29, 2018 at 1:02 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> > Hi all, >> > >> > My qemu boots of today's powerpc linux-next kernel produced the following >> > boot message differences: >> > >> > -Max number of cores passed to firmware: 2048 (NR_CPUS = 2048) >> > +Max number of cores passed to firmware: u (NR_CPUS = 2048) >> > >> > Seemingly caused by commit >> > >> > eae5f709a4d7 ("powerpc: Add __printf verification to prom_printf") >> >> My bad. Patch is pending (thanks Michael!): >> >> https://patchwork.ozlabs.org/patch/921948/ > > Umm, that fixes some other messages, but not this particular one. Here is what I tried to say: diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index 4d62f561f272..72ebe5896c1d 100644 --- a/arch/powerpc/kernel/prom_init.c +++ b/arch/powerpc/kernel/prom_init.c @@ -379,6 +379,11 @@ static void __init prom_printf(const char *format, ...) } prom_print_dec(vs); break; + case 'u': + ++q; + vs = va_arg(args, unsigned long); + prom_print_dec(vs); + break; case 'l': ++q; if (*q == 0) > -- > Cheers, > Stephen Rothwell ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-29 12:39 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-05-29 11:02 linux-next: boot messages from today's linux-next Stephen Rothwell 2018-05-29 11:56 ` Mathieu Malaterre 2018-05-29 12:00 ` Mathieu Malaterre 2018-05-29 12:14 ` Mathieu Malaterre 2018-05-29 12:23 ` Stephen Rothwell 2018-05-29 12:39 ` Mathieu Malaterre
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).