From: Nicholas Piggin <npiggin@gmail.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V2 4/4] powerpc/mm/radix: Change pte relax sequence to handle nest MMU hang
Date: Wed, 30 May 2018 08:44:43 +1000 [thread overview]
Message-ID: <20180530084443.58e4f754@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <20180529142841.19428-4-aneesh.kumar@linux.ibm.com>
On Tue, 29 May 2018 19:58:41 +0530
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote:
> When relaxing access (read -> read_write update), pte needs to be marked invalid
> to handle a nest MMU bug. We also need to do a tlb flush after the pte is
> marked invalid before updating the pte with new access bits.
>
> We also move tlb flush to platform specific __ptep_set_access_flags. This will
> help us to gerid of unnecessary tlb flush on BOOK3S 64 later. We don't do that
> in this patch. This also helps in avoiding multiple tlbies with coprocessor
> attached.
I thought you should move this part of the change back into patch 3 as
well.
Thanks,
Nick
next prev parent reply other threads:[~2018-05-29 22:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 14:28 [PATCH V2 1/4] powerpc/mm/hugetlb: Update huge_ptep_set_access_flags to call __ptep_set_access_flags directly Aneesh Kumar K.V
2018-05-29 14:28 ` [PATCH V2 2/4] powerpc/mm/radix: Move function from radix.h to pgtable-radix.c Aneesh Kumar K.V
2018-05-29 14:28 ` [PATCH V2 3/4] powerpc/mm: Change function prototype Aneesh Kumar K.V
2018-05-29 14:28 ` [PATCH V2 4/4] powerpc/mm/radix: Change pte relax sequence to handle nest MMU hang Aneesh Kumar K.V
2018-05-29 22:44 ` Nicholas Piggin [this message]
2018-06-04 14:11 ` [V2, 1/4] powerpc/mm/hugetlb: Update huge_ptep_set_access_flags to call __ptep_set_access_flags directly Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180530084443.58e4f754@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).