From: Christoph Hellwig <hch@infradead.org>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] pci/shpchp: no claim on pcie port device
Date: Mon, 11 Jun 2018 23:57:27 -0700 [thread overview]
Message-ID: <20180612065727.GA5195@infradead.org> (raw)
In-Reply-To: <1528785733-19442-1-git-send-email-kernelfans@gmail.com>
On Tue, Jun 12, 2018 at 02:42:13PM +0800, Pingfan Liu wrote:
> The Linux Device Driver Model allows a physical device to be handled
> by only a single driver. But at present, both shpchp and portdrv_pci
> claim PCI_CLASS_BRIDGE_PCI, and touch devices_kset. This causes a
> few problems, one is the wrong shutdown seq of devices, owing to the
> broken devices_kset.
How can they both touch devices_kset? Once one driver has claimed the
device it should not be available to others.
> + /* do not claim pcie port device */
> + if (pci_is_pcie(dev) &&
> + ((pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT) ||
> + (pci_pcie_type(dev) == PCI_EXP_TYPE_UPSTREAM) ||
> + (pci_pcie_type(dev) == PCI_EXP_TYPE_DOWNSTREAM)))
> + return -ENODEV;
No need for the inner braces.
next prev parent reply other threads:[~2018-06-12 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 6:42 [PATCH] pci/shpchp: no claim on pcie port device Pingfan Liu
2018-06-12 6:57 ` Christoph Hellwig [this message]
2018-06-12 7:20 ` Pingfan Liu
2018-06-12 6:57 ` kbuild test robot
2018-06-12 7:14 ` Pingfan Liu
2018-06-12 7:37 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612065727.GA5195@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=kernelfans@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox