From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: kbuild@01.org, kbuild-all@01.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Christoph Hellwig <hch@infradead.org>,
Bjorn Helgaas <helgaas@kernel.org>,
Dave Young <dyoung@redhat.com>,
linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/3] drivers/base: reorder consumer and its children behind suppliers
Date: Wed, 27 Jun 2018 11:34:45 +0300 [thread overview]
Message-ID: <20180627083445.jsu2ffyz5cl4wbjn@mwanda> (raw)
In-Reply-To: <CAFgQCTsCFP_6znUaFKnczuUJjMMA1Hq_Qrk6CUVs+EFEBZgTMQ@mail.gmail.com>
On Wed, Jun 27, 2018 at 10:34:54AM +0800, Pingfan Liu wrote:
> > 1b2a1e63 Pingfan Liu 2018-06-25 243 }
> > 1b2a1e63 Pingfan Liu 2018-06-25 244 }
> > 1b2a1e63 Pingfan Liu 2018-06-25 @245 BUG_ON(!ret);
> >
> > If the list is empty then "ret" can be unitialized. We test a different
> > list "dev->links.suppliers" to see if that's empty. I wrote a bunch of
> > code to make Smatch try to understand about empty lists, but I don't
> > think it works...
> >
> Yes, if list_empty, then the code can not touch ret. But ret is
> useless in this scene. Does it matter?
>
I'm not sure I understand what you're asking? Of course, it matters?
regards,
dan carpenter
next prev parent reply other threads:[~2018-06-27 8:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 5:23 [PATCH 0/3] drivers/base: bugfix for supplier<-consumer ordering in device_kset Pingfan Liu
2018-06-25 5:23 ` [PATCH 1/3] drivers/base: introduce some help routines for reordering a group of dev Pingfan Liu
2018-06-25 6:41 ` Greg Kroah-Hartman
2018-06-25 7:08 ` Pingfan Liu
2018-06-25 5:23 ` [PATCH 2/3] drivers/base: reorder consumer and its children behind suppliers Pingfan Liu
2018-06-26 7:44 ` Dan Carpenter
2018-06-27 2:34 ` Pingfan Liu
2018-06-27 8:34 ` Dan Carpenter [this message]
2018-06-28 13:47 ` Pingfan Liu
2018-06-25 5:23 ` [PATCH 3/3] drivers/base: only reordering consumer device when probing Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627083445.jsu2ffyz5cl4wbjn@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dyoung@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=kbuild-all@01.org \
--cc=kbuild@01.org \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox