From: John Allen <jallen@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org, nfont@linux.vnet.ibm.com
Cc: John Allen <jallen@linux.ibm.com>
Subject: [PATCH v2 2/2] powerpc/pseries: Wait for completion of hotplug events during PRRN handling
Date: Tue, 17 Jul 2018 14:40:48 -0500 [thread overview]
Message-ID: <20180717194048.3057-3-jallen@linux.ibm.com> (raw)
In-Reply-To: <20180717194048.3057-1-jallen@linux.ibm.com>
While handling PRRN events, the time to handle the actual hotplug events
dwarfs the time it takes to perform the device tree updates and queue the
hotplug events. In the case that PRRN events are being queued continuously,
hotplug events have been observed to be queued faster than the kernel can
actually handle them. This patch avoids the problem by waiting for a
hotplug request to complete before queueing more hotplug events.
Signed-off-by: John Allen <jallen@linux.ibm.com>
---
arch/powerpc/platforms/pseries/mobility.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c
index 8a8033a249c7..49930848fa78 100644
--- a/arch/powerpc/platforms/pseries/mobility.c
+++ b/arch/powerpc/platforms/pseries/mobility.c
@@ -242,6 +242,7 @@ static int add_dt_node(__be32 parent_phandle, __be32 drc_index)
static void prrn_update_node(__be32 phandle)
{
struct pseries_hp_errorlog *hp_elog;
+ struct completion hotplug_done;
struct device_node *dn;
/*
@@ -263,7 +264,9 @@ static void prrn_update_node(__be32 phandle)
hp_elog->id_type = PSERIES_HP_ELOG_ID_DRC_INDEX;
hp_elog->_drc_u.drc_index = phandle;
- queue_hotplug_event(hp_elog, NULL, NULL);
+ init_completion(&hotplug_done);
+ queue_hotplug_event(hp_elog, &hotplug_done, NULL);
+ wait_for_completion(&hotplug_done);
kfree(hp_elog);
}
--
2.17.1
next prev parent reply other threads:[~2018-07-17 19:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 19:40 [PATCH v2 0/2] powerpc/pseries: Improve serialization of PRRN events John Allen
2018-07-17 19:40 ` [PATCH v2 1/2] powerpc/pseries: Avoid blocking rtas polling handling multiple " John Allen
2018-07-20 16:12 ` Nathan Fontenot
2018-07-23 13:27 ` Michael Ellerman
2018-07-23 15:05 ` John Allen
2018-08-01 13:02 ` Michael Ellerman
2018-08-06 19:09 ` John Allen
2018-07-17 19:40 ` John Allen [this message]
2018-07-20 16:12 ` [PATCH v2 2/2] powerpc/pseries: Wait for completion of hotplug events during PRRN handling Nathan Fontenot
2018-07-23 13:41 ` Michael Ellerman
2018-07-23 15:22 ` John Allen
2018-08-01 13:16 ` Michael Ellerman
2018-08-07 19:26 ` John Allen
2018-08-08 13:38 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717194048.3057-3-jallen@linux.ibm.com \
--to=jallen@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nfont@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).