From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41VnMm5TjWzF3Hd for ; Wed, 18 Jul 2018 16:30:44 +1000 (AEST) Date: Wed, 18 Jul 2018 16:29:07 +1000 From: Paul Mackerras To: Nicholas Mc Guire Cc: Benjamin Herrenschmidt , Michael Ellerman , kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: PPC: Book3S HV: add of_node_put() in success path Message-ID: <20180718062907.GB27453@fergus> References: <1530946387-6607-1-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1530946387-6607-1-git-send-email-hofrat@osadl.org> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Jul 07, 2018 at 08:53:07AM +0200, Nicholas Mc Guire wrote: > The call to of_find_compatible_node() is returning a pointer with > incremented refcount so it must be explicitly decremented after the > last use. As here it is only being used for checking of node presence > but the result is not actually used in the success path it can be > dropped immediately. > > Signed-off-by: Nicholas Mc Guire > Fixes: commit f725758b899f ("KVM: PPC: Book3S HV: Use OPAL XICS emulation on POWER9") Thanks, patch applied to my kvm-ppc-next branch. Paul.