From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41Wd2k55ZbzDqDX for ; Fri, 20 Jul 2018 01:18:54 +1000 (AEST) Date: Thu, 19 Jul 2018 23:18:46 +0800 From: Baoquan He To: Andy Shevchenko Cc: Linux Kernel Mailing List , Andrew Morton , Rob Herring , Dan Williams , Nicolas Pitre , Josh Triplett , kbuild test robot , Borislav Petkov , Patrik Jakobsson , David Airlie , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Dmitry Torokhov , Frank Rowand , Keith Busch , Jon Derrick , Lorenzo Pieralisi , Bjorn Helgaas , Thomas Gleixner , brijesh.singh@amd.com, =?iso-8859-1?B?Suly9G1l?= Glisse , Tom Lendacky , Greg Kroah-Hartman , baiyaowei@cmss.chinamobile.com, richard.weiyang@gmail.com, devel@linuxdriverproject.org, linux-input , linux-nvdimm@lists.01.org, devicetree , linux-pci@vger.kernel.org, Eric Biederman , Vivek Goyal , Dave Young , Yinghai Lu , Michal Simek , "David S. Miller" , Chris Zankel , Max Filippov , Gustavo Padovan , Maarten Lankhorst , Sean Paul , linux-parisc@vger.kernel.org, "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Subject: Re: [PATCH v7 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public Message-ID: <20180719151846.GC7147@localhost.localdomain> References: <20180718024944.577-1-bhe@redhat.com> <20180718024944.577-2-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 07/18/18 at 07:37pm, Andy Shevchenko wrote: > On Wed, Jul 18, 2018 at 7:36 PM, Andy Shevchenko > wrote: > > On Wed, Jul 18, 2018 at 5:49 AM, Baoquan He wrote: > >> reparent_resources() is duplicated in arch/microblaze/pci/pci-common.c > >> and arch/powerpc/kernel/pci-common.c, so move it to kernel/resource.c > >> so that it's shared. > > >> + * Returns 0 on success, -ENOTSUPP if child resource is not completely > >> + * contained by 'res', -ECANCELED if no any conflicting entry found. > > You also can refer to constants by prefixing them with %, e.g. %-ENOTSUPP. > But this is up to you completely. Thanks, will fix when repost.