* [PATCH] scsi: prevent ISA driver from building on PPC32
@ 2018-07-21 19:58 Randy Dunlap
2018-07-23 8:18 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2018-07-21 19:58 UTC (permalink / raw)
To: PowerPC, Michael Ellerman, linux-scsi, Martin K. Petersen,
James E.J. Bottomley
From: Randy Dunlap <rdunlap@infradead.org>
Prevent drivers from building on PPC32 if they use isa_bus_to_virt(),
isa_virt_to_bus(), or isa_page_to_bus(), which are not available and
thus cause build errors.
../drivers/scsi/aha1542.c: In function 'aha1542_queuecommand':
../drivers/scsi/aha1542.c:461:30: error: implicit declaration of function 'isa_page_to_bus'; did you mean 'page_to_bus'? [-Werror=implicit-function-declaration]
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
---
drivers/scsi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20180720.orig/drivers/scsi/Kconfig
+++ linux-next-20180720/drivers/scsi/Kconfig
@@ -428,7 +428,7 @@ config SCSI_AHA152X
config SCSI_AHA1542
tristate "Adaptec AHA1542 support"
- depends on ISA && SCSI && ISA_DMA_API
+ depends on ISA && SCSI && ISA_DMA_API && !PPC32
---help---
This is support for a SCSI host adapter. It is explained in section
3.4 of the SCSI-HOWTO, available from
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: prevent ISA driver from building on PPC32
2018-07-21 19:58 [PATCH] scsi: prevent ISA driver from building on PPC32 Randy Dunlap
@ 2018-07-23 8:18 ` Christoph Hellwig
2018-07-23 8:19 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2018-07-23 8:18 UTC (permalink / raw)
To: Randy Dunlap
Cc: PowerPC, Michael Ellerman, linux-scsi, Martin K. Petersen,
James E.J. Bottomley
On Sat, Jul 21, 2018 at 12:58:21PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Prevent drivers from building on PPC32 if they use isa_bus_to_virt(),
> isa_virt_to_bus(), or isa_page_to_bus(), which are not available and
> thus cause build errors.
Please don't introduce weird arch dependencies, and add a
CONFIG_ISA_VIRT_TO_BUS instead.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: prevent ISA driver from building on PPC32
2018-07-23 8:18 ` Christoph Hellwig
@ 2018-07-23 8:19 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2018-07-23 8:19 UTC (permalink / raw)
To: Randy Dunlap
Cc: PowerPC, Michael Ellerman, linux-scsi, Martin K. Petersen,
James E.J. Bottomley
On Mon, Jul 23, 2018 at 01:18:11AM -0700, Christoph Hellwig wrote:
> On Sat, Jul 21, 2018 at 12:58:21PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> >
> > Prevent drivers from building on PPC32 if they use isa_bus_to_virt(),
> > isa_virt_to_bus(), or isa_page_to_bus(), which are not available and
> > thus cause build errors.
>
> Please don't introduce weird arch dependencies, and add a
> CONFIG_ISA_VIRT_TO_BUS instead.
And in fact we have so few drivers that we should just kill off the
API entirely instead. I'll take care of aha1542 in the next week or
so.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-23 8:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-21 19:58 [PATCH] scsi: prevent ISA driver from building on PPC32 Randy Dunlap
2018-07-23 8:18 ` Christoph Hellwig
2018-07-23 8:19 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).