From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41YvY83j00zDqRM for ; Mon, 23 Jul 2018 18:19:40 +1000 (AEST) Date: Mon, 23 Jul 2018 01:19:38 -0700 From: Christoph Hellwig To: Randy Dunlap Cc: PowerPC , Michael Ellerman , linux-scsi , "Martin K. Petersen" , "James E.J. Bottomley" Subject: Re: [PATCH] scsi: prevent ISA driver from building on PPC32 Message-ID: <20180723081938.GA28153@infradead.org> References: <5928f120-5a23-eff9-6c1d-41344d588b11@infradead.org> <20180723081811.GA27025@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180723081811.GA27025@infradead.org> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jul 23, 2018 at 01:18:11AM -0700, Christoph Hellwig wrote: > On Sat, Jul 21, 2018 at 12:58:21PM -0700, Randy Dunlap wrote: > > From: Randy Dunlap > > > > Prevent drivers from building on PPC32 if they use isa_bus_to_virt(), > > isa_virt_to_bus(), or isa_page_to_bus(), which are not available and > > thus cause build errors. > > Please don't introduce weird arch dependencies, and add a > CONFIG_ISA_VIRT_TO_BUS instead. And in fact we have so few drivers that we should just kill off the API entirely instead. I'll take care of aha1542 in the next week or so.