linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: "Alastair D'Silva" <alastair@d-silva.org>,
	Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
	Balbir Singh <bsingharora@gmail.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Christophe Leroy <christophe.leroy@c-s.fr>,
	Cyril Bur <cyrilbur@gmail.com>,
	"Eric W . Biederman" <ebiederm@xmission.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Michael Neuling <mikey@neuling.org>,
	Murilo Opsfelder Araujo <muriloo@linux.ibm.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Simon Guo <wei.guo.simon@gmail.com>,
	Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
	"Tobin C . Harding" <me@tobin.cc>,
	linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 4/7] powerpc/traps: Use REG_FMT in show_signal_msg()
Date: Tue, 24 Jul 2018 16:27:17 -0300	[thread overview]
Message-ID: <20180724192720.32417-5-muriloo@linux.ibm.com> (raw)
In-Reply-To: <20180724192720.32417-1-muriloo@linux.ibm.com>

Simplify the message format by using REG_FMT as the register format.  This
avoids having two different formats and avoids checking for MSR_64BIT.

Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
---
 arch/powerpc/kernel/traps.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
index 4faab4705774..047d980ac776 100644
--- a/arch/powerpc/kernel/traps.c
+++ b/arch/powerpc/kernel/traps.c
@@ -311,17 +311,13 @@ static bool show_unhandled_signals_ratelimited(void)
 static void show_signal_msg(int signr, struct pt_regs *regs, int code,
 			    unsigned long addr)
 {
-	const char fmt32[] = KERN_INFO "%s[%d]: unhandled signal %d " \
-		"at %08lx nip %08lx lr %08lx code %x\n";
-	const char fmt64[] = KERN_INFO "%s[%d]: unhandled signal %d " \
-		"at %016lx nip %016lx lr %016lx code %x\n";
-
 	if (!unhandled_signal(current, signr))
 		return;
 
-	printk(regs->msr & MSR_64BIT ? fmt64 : fmt32,
-	       current->comm, current->pid, signr,
-	       addr, regs->nip, regs->link, code);
+	pr_info("%s[%d]: unhandled signal %d at "REG_FMT \
+		" nip "REG_FMT" lr "REG_FMT" code %x\n",
+		current->comm, current->pid, signr, addr,
+		regs->nip, regs->link, code);
 }
 
 void _exception_pkey(int signr, struct pt_regs *regs, int code,
-- 
2.17.1

  parent reply	other threads:[~2018-07-24 19:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 19:27 [PATCH 0/7] powerpc: Modernize unhandled signals message Murilo Opsfelder Araujo
2018-07-24 19:27 ` [PATCH 1/7] powerpc/traps: Print unhandled signals in a separate function Murilo Opsfelder Araujo
2018-07-24 19:27 ` [PATCH 2/7] powerpc/traps: Return early in show_signal_msg() Murilo Opsfelder Araujo
2018-07-25 15:42   ` LEROY Christophe
2018-07-25 20:31     ` Murilo Opsfelder Araujo
2018-07-24 19:27 ` [PATCH 3/7] powerpc/reg: Add REG_FMT definition Murilo Opsfelder Araujo
2018-07-24 19:27 ` Murilo Opsfelder Araujo [this message]
2018-07-24 19:27 ` [PATCH 5/7] powerpc/traps: Print VMA for unhandled signals Murilo Opsfelder Araujo
2018-07-24 19:27 ` [PATCH 6/7] powerpc/traps: Print signal name " Murilo Opsfelder Araujo
2018-07-25 15:19   ` Gustavo Romero
2018-07-25 19:41     ` Murilo Opsfelder Araujo
2018-07-25 15:49   ` LEROY Christophe
2018-07-25 20:06     ` Murilo Opsfelder Araujo
2018-07-24 19:27 ` [PATCH 7/7] powerpc/traps: Show instructions on exceptions Murilo Opsfelder Araujo
2018-07-25 16:01   ` LEROY Christophe
2018-07-25 20:51     ` Murilo Opsfelder Araujo
2018-07-25  7:00 ` [PATCH 0/7] powerpc: Modernize unhandled signals message Michael Neuling
2018-07-25 19:36   ` Murilo Opsfelder Araujo
2018-07-26  2:11     ` Michael Neuling
2018-07-26  2:20     ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724192720.32417-5-muriloo@linux.ibm.com \
    --to=muriloo@linux.ibm.com \
    --cc=alastair@d-silva.org \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=bsingharora@gmail.com \
    --cc=christophe.leroy@c-s.fr \
    --cc=cyrilbur@gmail.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=me@tobin.cc \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=wei.guo.simon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).