From: David Miller <davem@davemloft.net>
To: krzk@kernel.org
Cc: pantelis.antoniou@gmail.com, linuxppc-dev@lists.ozlabs.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ebiggers3@gmail.com
Subject: Re: [PATCH] net: ethernet: fs-enet: Use generic CRC32 implementation
Date: Wed, 25 Jul 2018 13:42:11 -0700 (PDT) [thread overview]
Message-ID: <20180725.134211.849330522483481967.davem@davemloft.net> (raw)
In-Reply-To: <20180723162020.6221-1-krzk@kernel.org>
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: Mon, 23 Jul 2018 18:20:20 +0200
> Use generic kernel CRC32 implementation because it:
> 1. Should be faster (uses lookup tables),
> 2. Removes duplicated CRC generation code,
> 3. Uses well-proven algorithm instead of coding it one more time.
>
> Suggested-by: Eric Biggers <ebiggers3@gmail.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied.
prev parent reply other threads:[~2018-07-25 20:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 16:20 [PATCH] net: ethernet: fs-enet: Use generic CRC32 implementation Krzysztof Kozlowski
2018-07-24 11:05 ` David Laight
2018-07-24 11:11 ` Krzysztof Kozlowski
2018-07-24 11:22 ` David Laight
2018-07-25 20:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725.134211.849330522483481967.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiggers3@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pantelis.antoniou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).