* [PATCH] powerpc/mpc85xx: fix issues in clock node
@ 2018-08-14 2:50 Yuantian Tang
0 siblings, 0 replies; 5+ messages in thread
From: Yuantian Tang @ 2018-08-14 2:50 UTC (permalink / raw)
To: robh+dt, mark.rutland
Cc: benh, paulus, mpe, devicetree, linuxppc-dev, Yuantian Tang
The compatible string is not correct in the clock node.
The clocks property refers to the wrong node too.
This patch is to fix them.
Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
---
arch/powerpc/boot/dts/fsl/t1023si-post.dtsi | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
index 4908af5..763caf4 100644
--- a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
@@ -348,7 +348,7 @@
mux0: mux0@0 {
#clock-cells = <0>;
reg = <0x0 4>;
- compatible = "fsl,core-mux-clock";
+ compatible = "fsl,qoriq-core-mux-2.0";
clocks = <&pll0 0>, <&pll0 1>;
clock-names = "pll0_0", "pll0_1";
clock-output-names = "cmux0";
@@ -356,9 +356,9 @@
mux1: mux1@20 {
#clock-cells = <0>;
reg = <0x20 4>;
- compatible = "fsl,core-mux-clock";
- clocks = <&pll0 0>, <&pll0 1>;
- clock-names = "pll0_0", "pll0_1";
+ compatible = "fsl,qoriq-core-mux-2.0";
+ clocks = <&pll1 0>, <&pll1 1>;
+ clock-names = "pll1_0", "pll1_1";
clock-output-names = "cmux1";
};
};
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] powerpc/mpc85xx: fix issues in clock node
@ 2018-09-11 2:12 andy.tang
2018-09-18 0:43 ` Andy Tang
2018-09-18 22:24 ` Scott Wood
0 siblings, 2 replies; 5+ messages in thread
From: andy.tang @ 2018-09-11 2:12 UTC (permalink / raw)
To: oss; +Cc: robh+dt, mark.rutland, benh, devicetree, linuxppc-dev,
Yuantian Tang
From: Yuantian Tang <andy.tang@nxp.com>
The compatible string is not correct in the clock node.
The clocks property refers to the wrong node too.
This patch is to fix them.
Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
---
arch/powerpc/boot/dts/fsl/t1023si-post.dtsi | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
index 4908af5..763caf4 100644
--- a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
@@ -348,7 +348,7 @@
mux0: mux0@0 {
#clock-cells = <0>;
reg = <0x0 4>;
- compatible = "fsl,core-mux-clock";
+ compatible = "fsl,qoriq-core-mux-2.0";
clocks = <&pll0 0>, <&pll0 1>;
clock-names = "pll0_0", "pll0_1";
clock-output-names = "cmux0";
@@ -356,9 +356,9 @@
mux1: mux1@20 {
#clock-cells = <0>;
reg = <0x20 4>;
- compatible = "fsl,core-mux-clock";
- clocks = <&pll0 0>, <&pll0 1>;
- clock-names = "pll0_0", "pll0_1";
+ compatible = "fsl,qoriq-core-mux-2.0";
+ clocks = <&pll1 0>, <&pll1 1>;
+ clock-names = "pll1_0", "pll1_1";
clock-output-names = "cmux1";
};
};
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH] powerpc/mpc85xx: fix issues in clock node
2018-09-11 2:12 andy.tang
@ 2018-09-18 0:43 ` Andy Tang
2018-09-18 22:24 ` Scott Wood
1 sibling, 0 replies; 5+ messages in thread
From: Andy Tang @ 2018-09-18 0:43 UTC (permalink / raw)
To: Andy Tang, oss@buserror.net
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
benh@kernel.crashing.org, devicetree@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
SGkgU2NvdHQsDQoNCkNvdWxkIHlvdSBwbGVhc2UgdGFrZSBhIGxvb2sgYXQgdGhpcyBwYXRjaD8N
Cg0KVGhhbmtzLA0KQW5keQ0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206
IGFuZHkudGFuZ0BueHAuY29tIDxhbmR5LnRhbmdAbnhwLmNvbT4NCj4gU2VudDogMjAxOMTqOdTC
MTHI1SAxMDoxMg0KPiBUbzogb3NzQGJ1c2Vycm9yLm5ldA0KPiBDYzogcm9iaCtkdEBrZXJuZWwu
b3JnOyBtYXJrLnJ1dGxhbmRAYXJtLmNvbTsNCj4gYmVuaEBrZXJuZWwuY3Jhc2hpbmcub3JnOyBk
ZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsNCj4gbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5v
cmc7IEFuZHkgVGFuZyA8YW5keS50YW5nQG54cC5jb20+DQo+IFN1YmplY3Q6IFtQQVRDSF0gcG93
ZXJwYy9tcGM4NXh4OiBmaXggaXNzdWVzIGluIGNsb2NrIG5vZGUNCj4gDQo+IEZyb206IFl1YW50
aWFuIFRhbmcgPGFuZHkudGFuZ0BueHAuY29tPg0KPiANCj4gVGhlIGNvbXBhdGlibGUgc3RyaW5n
IGlzIG5vdCBjb3JyZWN0IGluIHRoZSBjbG9jayBub2RlLg0KPiBUaGUgY2xvY2tzIHByb3BlcnR5
IHJlZmVycyB0byB0aGUgd3Jvbmcgbm9kZSB0b28uDQo+IFRoaXMgcGF0Y2ggaXMgdG8gZml4IHRo
ZW0uDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBUYW5nIFl1YW50aWFuIDxhbmR5LnRhbmdAbnhwLmNv
bT4NCj4gLS0tDQo+ICBhcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL3QxMDIzc2ktcG9zdC5kdHNp
IHwgICAgOCArKysrLS0tLQ0KPiAgMSBmaWxlcyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQg
ZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL2Zz
bC90MTAyM3NpLXBvc3QuZHRzaQ0KPiBiL2FyY2gvcG93ZXJwYy9ib290L2R0cy9mc2wvdDEwMjNz
aS1wb3N0LmR0c2kNCj4gaW5kZXggNDkwOGFmNS4uNzYzY2FmNCAxMDA2NDQNCj4gLS0tIGEvYXJj
aC9wb3dlcnBjL2Jvb3QvZHRzL2ZzbC90MTAyM3NpLXBvc3QuZHRzaQ0KPiArKysgYi9hcmNoL3Bv
d2VycGMvYm9vdC9kdHMvZnNsL3QxMDIzc2ktcG9zdC5kdHNpDQo+IEBAIC0zNDgsNyArMzQ4LDcg
QEANCj4gIAkJbXV4MDogbXV4MEAwIHsNCj4gIAkJCSNjbG9jay1jZWxscyA9IDwwPjsNCj4gIAkJ
CXJlZyA9IDwweDAgND47DQo+IC0JCQljb21wYXRpYmxlID0gImZzbCxjb3JlLW11eC1jbG9jayI7
DQo+ICsJCQljb21wYXRpYmxlID0gImZzbCxxb3JpcS1jb3JlLW11eC0yLjAiOw0KPiAgCQkJY2xv
Y2tzID0gPCZwbGwwIDA+LCA8JnBsbDAgMT47DQo+ICAJCQljbG9jay1uYW1lcyA9ICJwbGwwXzAi
LCAicGxsMF8xIjsNCj4gIAkJCWNsb2NrLW91dHB1dC1uYW1lcyA9ICJjbXV4MCI7DQo+IEBAIC0z
NTYsOSArMzU2LDkgQEANCj4gIAkJbXV4MTogbXV4MUAyMCB7DQo+ICAJCQkjY2xvY2stY2VsbHMg
PSA8MD47DQo+ICAJCQlyZWcgPSA8MHgyMCA0PjsNCj4gLQkJCWNvbXBhdGlibGUgPSAiZnNsLGNv
cmUtbXV4LWNsb2NrIjsNCj4gLQkJCWNsb2NrcyA9IDwmcGxsMCAwPiwgPCZwbGwwIDE+Ow0KPiAt
CQkJY2xvY2stbmFtZXMgPSAicGxsMF8wIiwgInBsbDBfMSI7DQo+ICsJCQljb21wYXRpYmxlID0g
ImZzbCxxb3JpcS1jb3JlLW11eC0yLjAiOw0KPiArCQkJY2xvY2tzID0gPCZwbGwxIDA+LCA8JnBs
bDEgMT47DQo+ICsJCQljbG9jay1uYW1lcyA9ICJwbGwxXzAiLCAicGxsMV8xIjsNCj4gIAkJCWNs
b2NrLW91dHB1dC1uYW1lcyA9ICJjbXV4MSI7DQo+ICAJCX07DQo+ICAJfTsNCj4gLS0NCj4gMS43
LjENCg0K
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/mpc85xx: fix issues in clock node
2018-09-11 2:12 andy.tang
2018-09-18 0:43 ` Andy Tang
@ 2018-09-18 22:24 ` Scott Wood
2018-09-19 6:31 ` Andy Tang
1 sibling, 1 reply; 5+ messages in thread
From: Scott Wood @ 2018-09-18 22:24 UTC (permalink / raw)
To: andy.tang; +Cc: robh+dt, mark.rutland, benh, devicetree, linuxppc-dev
On Tue, 2018-09-11 at 10:12 +0800, andy.tang@nxp.com wrote:
> From: Yuantian Tang <andy.tang@nxp.com>
>
> The compatible string is not correct in the clock node.
> The clocks property refers to the wrong node too.
> This patch is to fix them.
>
> Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
> ---
> arch/powerpc/boot/dts/fsl/t1023si-post.dtsi | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> index 4908af5..763caf4 100644
> --- a/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t1023si-post.dtsi
> @@ -348,7 +348,7 @@
> mux0: mux0@0 {
> #clock-cells = <0>;
> reg = <0x0 4>;
> - compatible = "fsl,core-mux-clock";
> + compatible = "fsl,qoriq-core-mux-2.0";
> clocks = <&pll0 0>, <&pll0 1>;
> clock-names = "pll0_0", "pll0_1";
> clock-output-names = "cmux0";
> @@ -356,9 +356,9 @@
> mux1: mux1@20 {
> #clock-cells = <0>;
> reg = <0x20 4>;
> - compatible = "fsl,core-mux-clock";
> - clocks = <&pll0 0>, <&pll0 1>;
> - clock-names = "pll0_0", "pll0_1";
> + compatible = "fsl,qoriq-core-mux-2.0";
> + clocks = <&pll1 0>, <&pll1 1>;
> + clock-names = "pll1_0", "pll1_1";
> clock-output-names = "cmux1";
> };
> };
These are the legacy nodes. Why not just remove them instead of fixing them?
Now that the cpufreq driver is fixed we could get rid of the legacy nodes for
all the chips.
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] powerpc/mpc85xx: fix issues in clock node
2018-09-18 22:24 ` Scott Wood
@ 2018-09-19 6:31 ` Andy Tang
0 siblings, 0 replies; 5+ messages in thread
From: Andy Tang @ 2018-09-19 6:31 UTC (permalink / raw)
To: Scott Wood
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
benh@kernel.crashing.org, devicetree@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
SGkgU2NvdHQsDQoNCldoYXQgeW91IHNhaWQgbWFrZXMgc2Vuc2Ugd2VsbC4gSSB3aWxsIHJlc2Vu
ZCB0aGUgcGF0Y2guDQoNClRoYW5rcywNCkFuZHkNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2Ut
LS0tLQ0KPiBGcm9tOiBTY290dCBXb29kIDxvc3NAYnVzZXJyb3IubmV0Pg0KPiBTZW50OiAyMDE4
5bm0OeaciDE55pelIDY6MjQNCj4gVG86IEFuZHkgVGFuZyA8YW5keS50YW5nQG54cC5jb20+DQo+
IENjOiByb2JoK2R0QGtlcm5lbC5vcmc7IG1hcmsucnV0bGFuZEBhcm0uY29tOw0KPiBiZW5oQGtl
cm5lbC5jcmFzaGluZy5vcmc7IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOw0KPiBsaW51eHBw
Yy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIXSBwb3dlcnBjL21w
Yzg1eHg6IGZpeCBpc3N1ZXMgaW4gY2xvY2sgbm9kZQ0KPiANCj4gT24gVHVlLCAyMDE4LTA5LTEx
IGF0IDEwOjEyICswODAwLCBhbmR5LnRhbmdAbnhwLmNvbSB3cm90ZToNCj4gPiBGcm9tOiBZdWFu
dGlhbiBUYW5nIDxhbmR5LnRhbmdAbnhwLmNvbT4NCj4gPg0KPiA+IFRoZSBjb21wYXRpYmxlIHN0
cmluZyBpcyBub3QgY29ycmVjdCBpbiB0aGUgY2xvY2sgbm9kZS4NCj4gPiBUaGUgY2xvY2tzIHBy
b3BlcnR5IHJlZmVycyB0byB0aGUgd3Jvbmcgbm9kZSB0b28uDQo+ID4gVGhpcyBwYXRjaCBpcyB0
byBmaXggdGhlbS4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFRhbmcgWXVhbnRpYW4gPGFuZHku
dGFuZ0BueHAuY29tPg0KPiA+IC0tLQ0KPiA+ICBhcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL3Qx
MDIzc2ktcG9zdC5kdHNpIHwgICAgOCArKysrLS0tLQ0KPiA+ICAxIGZpbGVzIGNoYW5nZWQsIDQg
aW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9hcmNo
L3Bvd2VycGMvYm9vdC9kdHMvZnNsL3QxMDIzc2ktcG9zdC5kdHNpDQo+ID4gYi9hcmNoL3Bvd2Vy
cGMvYm9vdC9kdHMvZnNsL3QxMDIzc2ktcG9zdC5kdHNpDQo+ID4gaW5kZXggNDkwOGFmNS4uNzYz
Y2FmNCAxMDA2NDQNCj4gPiAtLS0gYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL3QxMDIzc2kt
cG9zdC5kdHNpDQo+ID4gKysrIGIvYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL2ZzbC90MTAyM3NpLXBv
c3QuZHRzaQ0KPiA+IEBAIC0zNDgsNyArMzQ4LDcgQEANCj4gPiAgCQltdXgwOiBtdXgwQDAgew0K
PiA+ICAJCQkjY2xvY2stY2VsbHMgPSA8MD47DQo+ID4gIAkJCXJlZyA9IDwweDAgND47DQo+ID4g
LQkJCWNvbXBhdGlibGUgPSAiZnNsLGNvcmUtbXV4LWNsb2NrIjsNCj4gPiArCQkJY29tcGF0aWJs
ZSA9ICJmc2wscW9yaXEtY29yZS1tdXgtMi4wIjsNCj4gPiAgCQkJY2xvY2tzID0gPCZwbGwwIDA+
LCA8JnBsbDAgMT47DQo+ID4gIAkJCWNsb2NrLW5hbWVzID0gInBsbDBfMCIsICJwbGwwXzEiOw0K
PiA+ICAJCQljbG9jay1vdXRwdXQtbmFtZXMgPSAiY211eDAiOw0KPiA+IEBAIC0zNTYsOSArMzU2
LDkgQEANCj4gPiAgCQltdXgxOiBtdXgxQDIwIHsNCj4gPiAgCQkJI2Nsb2NrLWNlbGxzID0gPDA+
Ow0KPiA+ICAJCQlyZWcgPSA8MHgyMCA0PjsNCj4gPiAtCQkJY29tcGF0aWJsZSA9ICJmc2wsY29y
ZS1tdXgtY2xvY2siOw0KPiA+IC0JCQljbG9ja3MgPSA8JnBsbDAgMD4sIDwmcGxsMCAxPjsNCj4g
PiAtCQkJY2xvY2stbmFtZXMgPSAicGxsMF8wIiwgInBsbDBfMSI7DQo+ID4gKwkJCWNvbXBhdGli
bGUgPSAiZnNsLHFvcmlxLWNvcmUtbXV4LTIuMCI7DQo+ID4gKwkJCWNsb2NrcyA9IDwmcGxsMSAw
PiwgPCZwbGwxIDE+Ow0KPiA+ICsJCQljbG9jay1uYW1lcyA9ICJwbGwxXzAiLCAicGxsMV8xIjsN
Cj4gPiAgCQkJY2xvY2stb3V0cHV0LW5hbWVzID0gImNtdXgxIjsNCj4gPiAgCQl9Ow0KPiA+ICAJ
fTsNCj4gDQo+IFRoZXNlIGFyZSB0aGUgbGVnYWN5IG5vZGVzLiAgV2h5IG5vdCBqdXN0IHJlbW92
ZSB0aGVtIGluc3RlYWQgb2YgZml4aW5nDQo+IHRoZW0/DQo+IE5vdyB0aGF0IHRoZSBjcHVmcmVx
IGRyaXZlciBpcyBmaXhlZCB3ZSBjb3VsZCBnZXQgcmlkIG9mIHRoZSBsZWdhY3kgbm9kZXMNCj4g
Zm9yIGFsbCB0aGUgY2hpcHMuDQo+IA0KPiAtU2NvdHQNCg0K
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-19 6:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-14 2:50 [PATCH] powerpc/mpc85xx: fix issues in clock node Yuantian Tang
-- strict thread matches above, loose matches on Subject: below --
2018-09-11 2:12 andy.tang
2018-09-18 0:43 ` Andy Tang
2018-09-18 22:24 ` Scott Wood
2018-09-19 6:31 ` Andy Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).