From: Wolfram Sang <wsa@the-dreams.de>
To: Darren Stevens <darren@stevens-zone.net>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [RESEND PATCH] i2c/busses/pasemi: Remove hardcoded bus numbers on smbus
Date: Mon, 20 Aug 2018 11:07:18 +0200 [thread overview]
Message-ID: <20180820090718.eb4kgadzg7qevqrx@ninjato> (raw)
In-Reply-To: <4b3d0f2cad0.58555470@auth.smtp.1and1.co.uk>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
On Sun, Dec 31, 2017 at 08:53:55PM +0000, Darren Stevens wrote:
> The pasemi smbus controller uses PCI_FUNC(dev->devfn) to define which
> number bus to attach to, however this fails when something else is
> probed first, for example an ATI Radeon graphics card will claim 9 or
> 10 busses, including the ones the pasemi wants.
> Patch the driver to call i2c_add_adapter rather than
> i2c_add_numbered_adapter.
>
> Signed-off-by: Darren Stevens <darren@stevens-zone.net>
>
Applied to for-next, thanks!
Disclaimer: I usually do not like to change the bus numbering because
some people may rely on that. But numbering based on PCI functions seems
really weak and all known users of pasemi seem to have issues here, so I
make an exception.
Thanks to Michael Ellerman for the additional info.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-08-20 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-31 20:53 [RESEND PATCH] i2c/busses/pasemi: Remove hardcoded bus numbers on smbus Darren Stevens
2018-08-20 9:07 ` Wolfram Sang [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-02-26 21:49 Darren Stevens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180820090718.eb4kgadzg7qevqrx@ninjato \
--to=wsa@the-dreams.de \
--cc=darren@stevens-zone.net \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox