* [PATCH] hwmon: drop unnecessary OF name NULL checks
@ 2018-08-29 20:02 Rob Herring
2018-08-29 20:27 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2018-08-29 20:02 UTC (permalink / raw)
To: Guenter Roeck
Cc: linux-kernel, Jean Delvare, Benjamin Herrenschmidt,
Paul Mackerras, Michael Ellerman, linux-hwmon, linuxppc-dev
Checking the child node names is pointless as the DT node name can
never be NULL, so remove it.
Cc: Jean Delvare <jdelvare@suse.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-hwmon@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/hwmon/ibmpowernv.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
index 4935897f1527..0ccca87f5271 100644
--- a/drivers/hwmon/ibmpowernv.c
+++ b/drivers/hwmon/ibmpowernv.c
@@ -458,9 +458,6 @@ static int populate_attr_groups(struct platform_device *pdev)
for_each_child_of_node(opal, np) {
const char *label;
- if (np->name == NULL)
- continue;
-
type = get_sensor_type(np);
if (type == MAX_SENSOR_TYPE)
continue;
@@ -589,9 +586,6 @@ static int create_device_attrs(struct platform_device *pdev)
const char *label;
enum sensors type;
- if (np->name == NULL)
- continue;
-
type = get_sensor_type(np);
if (type == MAX_SENSOR_TYPE)
continue;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] hwmon: drop unnecessary OF name NULL checks
2018-08-29 20:02 [PATCH] hwmon: drop unnecessary OF name NULL checks Rob Herring
@ 2018-08-29 20:27 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2018-08-29 20:27 UTC (permalink / raw)
To: Rob Herring
Cc: linux-kernel, Jean Delvare, Benjamin Herrenschmidt,
Paul Mackerras, Michael Ellerman, linux-hwmon, linuxppc-dev
On Wed, Aug 29, 2018 at 03:02:21PM -0500, Rob Herring wrote:
> Checking the child node names is pointless as the DT node name can
> never be NULL, so remove it.
>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: linux-hwmon@vger.kernel.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/ibmpowernv.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
> index 4935897f1527..0ccca87f5271 100644
> --- a/drivers/hwmon/ibmpowernv.c
> +++ b/drivers/hwmon/ibmpowernv.c
> @@ -458,9 +458,6 @@ static int populate_attr_groups(struct platform_device *pdev)
> for_each_child_of_node(opal, np) {
> const char *label;
>
> - if (np->name == NULL)
> - continue;
> -
> type = get_sensor_type(np);
> if (type == MAX_SENSOR_TYPE)
> continue;
> @@ -589,9 +586,6 @@ static int create_device_attrs(struct platform_device *pdev)
> const char *label;
> enum sensors type;
>
> - if (np->name == NULL)
> - continue;
> -
> type = get_sensor_type(np);
> if (type == MAX_SENSOR_TYPE)
> continue;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-29 20:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-29 20:02 [PATCH] hwmon: drop unnecessary OF name NULL checks Rob Herring
2018-08-29 20:27 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).