linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Miguel Ojeda Sandonis" <miguel.ojeda.sandonis@gmail.com>,
	"Peter Korsgaard" <peter.korsgaard@barco.com>,
	"Peter Rosin" <peda@axentia.se>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Dominik Brodowski" <linux@dominikbrodowski.net>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Hartmut Knaack" <knaack.h@gmx.de>,
	"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
	"Jiri Slaby" <jslaby@suse.com>, "Willy Tarreau" <w@1wt.eu>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	linux-doc@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-mmc@vger.kernel.org, netdev@vger.kernel.org,
	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Sebastien Bourdelin" <sebastien.bourdelin@savoirfairelinux.com>,
	"Lukas Wunner" <lukas@wunner.de>,
	"Rojhalat Ibrahim" <imr@rtschenk.de>,
	"Russell King" <rmk+kernel@armlinux.org.uk>,
	"Tony Lindgren" <tony@atomide.com>,
	"Yegor Yefremov" <yegorslists@googlemail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v7 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array
Date: Sun, 2 Sep 2018 21:31:29 -0700	[thread overview]
Message-ID: <20180903043129.GA17856@bombadil.infradead.org> (raw)
In-Reply-To: <20180902120144.6855-2-jmkrzyszt@gmail.com>

> +++ b/drivers/auxdisplay/hd44780.c
> @@ -62,17 +62,12 @@ static void hd44780_strobe_gpio(struct hd44780 *hd)
>  /* write to an LCD panel register in 8 bit GPIO mode */
>  static void hd44780_write_gpio8(struct hd44780 *hd, u8 val, unsigned int rs)
>  {
> -	int values[10];	/* for DATA[0-7], RS, RW */
> -	unsigned int i, n;
> -
> -	for (i = 0; i < 8; i++)
> -		values[PIN_DATA0 + i] = !!(val & BIT(i));
> -	values[PIN_CTRL_RS] = rs;
> -	n = 9;
> -	if (hd->pins[PIN_CTRL_RW]) {
> -		values[PIN_CTRL_RW] = 0;
> -		n++;
> -	}
> +	DECLARE_BITMAP(values, 10); /* for DATA[0-7], RS, RW */
> +	unsigned int n;
> +
> +	*values = val;
> +	__assign_bit(8, values, rs);
> +	n = hd->pins[PIN_CTRL_RW] ? 10 : 9;

Doesn't this assume little endian bitmaps?  Has anyone tested this on
big-endian machines?

       reply	other threads:[~2018-09-03  4:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180831225616.29221-1-jmkrzyszt@gmail.com>
     [not found] ` <20180902120144.6855-1-jmkrzyszt@gmail.com>
     [not found]   ` <20180902120144.6855-2-jmkrzyszt@gmail.com>
2018-09-03  4:31     ` Matthew Wilcox [this message]
2018-09-03 14:24       ` [PATCH v7 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180903043129.GA17856@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andrew@lunn.ch \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=f.fainelli@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=imr@rtschenk.de \
    --cc=jic23@kernel.org \
    --cc=jmkrzyszt@gmail.com \
    --cc=jslaby@suse.com \
    --cc=kishon@ti.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lukas@wunner.de \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=peter.korsgaard@barco.com \
    --cc=pmeerw@pmeerw.net \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=sebastien.bourdelin@savoirfairelinux.com \
    --cc=tony@atomide.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=ulf.hansson@linaro.org \
    --cc=w@1wt.eu \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).