From: Reza Arbab <arbab@linux.ibm.com>
To: Alan Modra <amodra@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, Michael Neuling <mikey@neuling.org>
Subject: Re: [PATCH] Correct PowerPC VDSO call frame info
Date: Thu, 13 Sep 2018 21:59:11 -0500 [thread overview]
Message-ID: <20180914025911.665onq4xzb67ijss@arbab-vm> (raw)
In-Reply-To: <20180913232704.GL3174@bubble.grove.modra.org>
On Fri, Sep 14, 2018 at 08:57:04AM +0930, Alan Modra wrote:
>There is control flow in __kernel_clock_gettime that reaches label 99
>without saving lr in r12. CFI info however is interpreted by the
>unwinder without reference to control flow: It's a simple matter of
>"Execute all the CFI opcodes up to the current address". That means
>the unwinder thinks r12 contains the return address at label 99.
>Disabuse it of that notion by resetting CFI for the return address at
>label 99.
Thanks for this! It looks like v2 will just be a commit log change, so
feel free to carry over my
Tested-by: Reza Arbab <arbab@linux.ibm.com>
--
Reza Arbab
prev parent reply other threads:[~2018-09-14 2:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 23:27 [PATCH] Correct PowerPC VDSO call frame info Alan Modra
2018-09-14 0:01 ` Michael Neuling
2018-09-14 3:40 ` [PATCH] PowerPC/VDSO: Correct call frame information Alan Modra
2018-09-20 4:21 ` Michael Ellerman
2018-09-14 2:59 ` Reza Arbab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914025911.665onq4xzb67ijss@arbab-vm \
--to=arbab@linux.ibm.com \
--cc=amodra@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox