From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] powerpc: initial stack protector (-fstack-protector) support
Date: Mon, 17 Sep 2018 11:46:13 -0500 [thread overview]
Message-ID: <20180917164613.GJ23155@gate.crashing.org> (raw)
In-Reply-To: <9f7efcc085685717bb4c7b3a575138a1a1cd15ed.1537186089.git.christophe.leroy@c-s.fr>
Hi!
On Mon, Sep 17, 2018 at 12:15:05PM +0000, Christophe Leroy wrote:
> Now, GCC offers the possibility to manually set the
> stack-protector mode (global or tls) regardless of libc support.
Yup :-)
> This time, the patch selects HAVE_STACKPROTECTOR only if
> -mstack-protector-guard=global is supported by GCC.
"global" is weaker than "tls" (it is easier to read the cookie in an
exploit). It is better to use tls if you can.
Segher
next prev parent reply other threads:[~2018-09-20 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 12:15 [PATCH 1/2] powerpc: initial stack protector (-fstack-protector) support Christophe Leroy
2018-09-17 12:15 ` [PATCH 2/2] powerpc/32: stack protector: change the canary value per task Christophe Leroy
2018-09-17 16:49 ` Segher Boessenkool
2018-09-17 16:21 ` [PATCH 1/2] powerpc: initial stack protector (-fstack-protector) support kbuild test robot
2018-09-17 16:46 ` Segher Boessenkool [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-09-30 14:26 [PATCH 0/2] powerpc: " Christophe Leroy
2016-09-30 14:26 ` [PATCH 1/2] powerpc: initial " Christophe Leroy
2016-11-17 11:05 ` Michael Ellerman
2016-11-22 10:51 ` Christophe LEROY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917164613.GJ23155@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).