From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=DATE_IN_PAST_03_06, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95B02C43143 for ; Tue, 2 Oct 2018 01:15:57 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D16E2083F for ; Tue, 2 Oct 2018 01:15:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D16E2083F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42PLnQ6jNRzF3Df for ; Tue, 2 Oct 2018 11:15:54 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linuxfoundation.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42PLkh2wBtzF38r for ; Tue, 2 Oct 2018 11:13:32 +1000 (AEST) Received: from localhost (24-104-73-23-ip-static.hfc.comcastbusiness.net [24.104.73.23]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id E20CD82; Tue, 2 Oct 2018 01:13:29 +0000 (UTC) Date: Mon, 1 Oct 2018 14:08:04 -0700 From: Greg KH To: Ioana Ciornei Subject: Re: [PATCH] driver core: device: add BUS_ATTR_WO macro Message-ID: <20181001210804.GA24332@kroah.com> References: <1538407972-9340-1-git-send-email-ioana.ciornei@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1538407972-9340-1-git-send-email-ioana.ciornei@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: elder@kernel.org, linux-scsi@vger.kernel.org, sage@redhat.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, idryomov@gmail.com, jth@kernel.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Oct 01, 2018 at 06:32:52PM +0300, Ioana Ciornei wrote: > Add BUS_ATTR_WO macro to make it easier to add attributes without > auditing the mode settings. Also, use the newly added macro where > appropriate. > > Signed-off-by: Ioana Ciornei > --- > arch/powerpc/platforms/pseries/ibmebus.c | 12 ++++---- > drivers/block/rbd.c | 48 ++++++++++++++++---------------- > drivers/scsi/fcoe/fcoe_sysfs.c | 4 +-- > drivers/scsi/fcoe/fcoe_transport.c | 10 +++---- > include/linux/device.h | 2 ++ > include/scsi/libfcoe.h | 8 +++--- > 6 files changed, 43 insertions(+), 41 deletions(-) Nice! This duplicates a lot of the work I did back in July but have not pushed out very far due to the other things that ended up happening around that time: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/log/?h=bus_cleanup As the patch series seen at that link shows, you can do this in more places than just what you did here. Either way, you should break this up into the individual patches, like I did or you can take my patches if you want. Getting the BUS_ATTR_WO() macro added is good to do now, and then you can go and hit up all of the different subsystems that should be converted over to it. thanks, greg k-h