From: Anton Blanchard <anton@ozlabs.org>
To: Russell Currey <ruscur@russell.cc>
Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com
Subject: Re: [PATCH] powerpc: Add doorbell tracepoints
Date: Thu, 4 Oct 2018 16:16:36 +1000 [thread overview]
Message-ID: <20181004161636.3940033e@kryten> (raw)
In-Reply-To: <32bd00f1b50f77f7c58972d72e8459a72317204b.camel@russell.cc>
Hi Russell,
> snowpatch builds failed for this patch on all 64-bit configurations
> (ppc64e, ppc64 and ppc64le) with the following:
Thanks! Stupid bug on my part, need more quilt ref. Update to follow.
Anton
> arch/powerpc/kernel/dbell.c:85:9: error: undefined identifier
> 'trace_doorbell_entry'
> arch/powerpc/kernel/dbell.c:96:9: error: undefined identifier
> 'trace_doorbell_exit'
> ./arch/powerpc/include/asm/spinlock.h:171:9: warning: context
> imbalance in 'key_user_put' - unexpected unlock
> arch/powerpc/kernel/dbell.c: In function 'doorbell_exception':
> arch/powerpc/kernel/dbell.c:85:2: error: implicit declaration of
> function 'trace_doorbell_entry'; did you mean 'trace_irq_entry'?
> [-Werror=implicit- function-declaration]
> trace_doorbell_entry(regs);
> ^~~~~~~~~~~~~~~~~~~~
> trace_irq_entry
> arch/powerpc/kernel/dbell.c:96:2: error: implicit declaration of
> function 'trace_doorbell_exit'; did you mean 'trace_irq_exit'?
> [-Werror=implicit-function- declaration]
> trace_doorbell_exit(regs);
> ^~~~~~~~~~~~~~~~~~~
> trace_irq_exit
> cc1: all warnings being treated as errors
> scripts/Makefile.build:305: recipe for target
> 'arch/powerpc/kernel/dbell.o' failed make[1]: ***
> [arch/powerpc/kernel/dbell.o] Error 1 Makefile:1060: recipe for
> target 'arch/powerpc/kernel' failed
>
> So does something else need to check for CONFIG_PPC_DOORBELL maybe?
>
> You can see the failures here:
> http://patchwork.ozlabs.org/patch/978088/ - output in build_new.log
> (I know it's not pretty in there yet, you can search for "Error 1" to
> find the build failure)
>
> - Russell
>
>
next prev parent reply other threads:[~2018-10-04 6:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 0:29 [PATCH] powerpc: Add doorbell tracepoints Anton Blanchard
2018-10-03 3:48 ` Nicholas Piggin
2018-10-04 5:41 ` Russell Currey
2018-10-04 6:16 ` Anton Blanchard [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-04 6:23 Anton Blanchard
2019-05-03 6:59 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004161636.3940033e@kryten \
--to=anton@ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).