* [PATCH] powerpc/rtasd: Improve unknown error logging
@ 2018-10-10 5:23 Oliver O'Halloran
2018-10-10 5:49 ` Vasant Hegde
2018-10-15 4:01 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Oliver O'Halloran @ 2018-10-10 5:23 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Oliver O'Halloran
Currently when we get an unknown RTAS event it prints the type as
"Unknown" and no other useful information. Add the raw type code to the
log message so that we have something to work off.
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
---
arch/powerpc/kernel/rtasd.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/rtasd.c b/arch/powerpc/kernel/rtasd.c
index 44d66c33d59d..6fafc82c04b0 100644
--- a/arch/powerpc/kernel/rtasd.c
+++ b/arch/powerpc/kernel/rtasd.c
@@ -150,8 +150,10 @@ static void printk_log_rtas(char *buf, int len)
} else {
struct rtas_error_log *errlog = (struct rtas_error_log *)buf;
- printk(RTAS_DEBUG "event: %d, Type: %s, Severity: %d\n",
- error_log_cnt, rtas_event_type(rtas_error_type(errlog)),
+ printk(RTAS_DEBUG "event: %d, Type: %s (%d), Severity: %d\n",
+ error_log_cnt,
+ rtas_event_type(rtas_error_type(errlog)),
+ rtas_error_type(errlog),
rtas_error_severity(errlog));
}
}
--
2.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/rtasd: Improve unknown error logging
2018-10-10 5:23 [PATCH] powerpc/rtasd: Improve unknown error logging Oliver O'Halloran
@ 2018-10-10 5:49 ` Vasant Hegde
2018-10-15 4:01 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Vasant Hegde @ 2018-10-10 5:49 UTC (permalink / raw)
To: Oliver O'Halloran, linuxppc-dev
On 10/10/2018 10:53 AM, Oliver O'Halloran wrote:
> Currently when we get an unknown RTAS event it prints the type as
> "Unknown" and no other useful information. Add the raw type code to the
> log message so that we have something to work off.
Yeah. Useful one.
Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
-Vasant
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> ---
> arch/powerpc/kernel/rtasd.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/rtasd.c b/arch/powerpc/kernel/rtasd.c
> index 44d66c33d59d..6fafc82c04b0 100644
> --- a/arch/powerpc/kernel/rtasd.c
> +++ b/arch/powerpc/kernel/rtasd.c
> @@ -150,8 +150,10 @@ static void printk_log_rtas(char *buf, int len)
> } else {
> struct rtas_error_log *errlog = (struct rtas_error_log *)buf;
>
> - printk(RTAS_DEBUG "event: %d, Type: %s, Severity: %d\n",
> - error_log_cnt, rtas_event_type(rtas_error_type(errlog)),
> + printk(RTAS_DEBUG "event: %d, Type: %s (%d), Severity: %d\n",
> + error_log_cnt,
> + rtas_event_type(rtas_error_type(errlog)),
> + rtas_error_type(errlog),
> rtas_error_severity(errlog));
> }
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: powerpc/rtasd: Improve unknown error logging
2018-10-10 5:23 [PATCH] powerpc/rtasd: Improve unknown error logging Oliver O'Halloran
2018-10-10 5:49 ` Vasant Hegde
@ 2018-10-15 4:01 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2018-10-15 4:01 UTC (permalink / raw)
To: Oliver O'Halloran, linuxppc-dev; +Cc: Oliver O'Halloran
On Wed, 2018-10-10 at 05:23:02 UTC, Oliver O'Halloran wrote:
> Currently when we get an unknown RTAS event it prints the type as
> "Unknown" and no other useful information. Add the raw type code to the
> log message so that we have something to work off.
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/b27e5f939b6d50e1b83e9febfee1c3
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-15 4:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-10 5:23 [PATCH] powerpc/rtasd: Improve unknown error logging Oliver O'Halloran
2018-10-10 5:49 ` Vasant Hegde
2018-10-15 4:01 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).