From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
Cc: Michael Neuling <mikey@neuling.org>,
Murilo Opsfelder Araujo <muriloo@linux.ibm.com>,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
Dave Hansen <dave.hansen@intel.com>,
Oliver O'Halloran <oohall@gmail.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>,
Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH v10 1/3] powerpc: Detect the presence of big-cores via "ibm,thread-groups"
Date: Fri, 12 Oct 2018 12:28:31 +0530 [thread overview]
Message-ID: <20181012065831.GA28228@linux.vnet.ibm.com> (raw)
In-Reply-To: <1539235983-25259-2-git-send-email-ego@linux.vnet.ibm.com>
> +DECLARE_PER_CPU(cpumask_var_t, cpu_smallcore_map);
>
> +/*
> + * On big-cores system, cpu_l1_cache_map for each CPU corresponds to
> + * the set its siblings that share the L1-cache.
> + */
> +DEFINE_PER_CPU(cpumask_var_t, cpu_l1_cache_map);
>
Nit:
Can you add a comment on how cpu_l1_cache_map differs from
cpu_smallcore_map?.
Everything else looks okay to me.
next prev parent reply other threads:[~2018-10-12 7:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 5:33 [PATCH v10 0/3] powerpc: Detection and scheduler optimization for POWER9 bigcore Gautham R. Shenoy
2018-10-11 5:33 ` [PATCH v10 1/3] powerpc: Detect the presence of big-cores via "ibm, thread-groups" Gautham R. Shenoy
2018-10-12 6:58 ` Srikar Dronamraju [this message]
2018-10-15 4:01 ` [v10, " Michael Ellerman
2018-10-11 5:33 ` [PATCH v10 2/3] powerpc: Use cpu_smallcore_sibling_mask at SMT level on bigcores Gautham R. Shenoy
2018-10-12 7:00 ` Srikar Dronamraju
2018-10-11 5:33 ` [PATCH v10 3/3] powerpc/cacheinfo: Report the correct shared_cpu_map on big-cores Gautham R. Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012065831.GA28228@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=akshay.adiga@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anton@samba.org \
--cc=dave.hansen@intel.com \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=muriloo@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=shilpa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).