From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A63C6787C for ; Fri, 12 Oct 2018 22:05:14 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BAFD20835 for ; Fri, 12 Oct 2018 22:05:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="Yx6iiDOE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BAFD20835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42X22J0v0GzF3S4 for ; Sat, 13 Oct 2018 09:05:12 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="Yx6iiDOE"; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=joelfernandes.org (client-ip=2607:f8b0:4864:20::644; helo=mail-pl1-x644.google.com; envelope-from=joel@joelfernandes.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="Yx6iiDOE"; dkim-atps=neutral Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42Wtm971pDzF3TB for ; Sat, 13 Oct 2018 03:37:29 +1100 (AEDT) Received: by mail-pl1-x644.google.com with SMTP id q17-v6so6182922plr.8 for ; Fri, 12 Oct 2018 09:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VgdWRAThwj2EMLbo8sWAHSsutcajwriCEy/dGs8kimQ=; b=Yx6iiDOE4GgwJ3wrxDhjF1xivdsbBDEqc8xx5jdpyDJvE+qpLgMgy/KhjSsAuHRJyU rjgnlYO7tlrGv1G+TaKr5XDehCpd8eZLTAEwubNcKxLRAX6QLsDFm2lImHS78o7KxLhe EhZiy+H+FVvSEtNaG63pU9KzeTWvu1FrWLelY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VgdWRAThwj2EMLbo8sWAHSsutcajwriCEy/dGs8kimQ=; b=IUxKdLBO26gCiqgWxzrPbZ6TRhpVDiaA8bAPKK+LcWB6vtvhTmn7K8j6bKZ6uk73PE 5/ea1NUbrbR16ED2MOhqcWYFNRJU3itHN3YLhWO1xb0lH78VVFJu13cyzkEIri7STLsj Fzjr+EL8GFSsO33SbhaFO7JbpsJl0zSWCB7bpS21demllBV+Bj3uVbDF+X1CDkiz8nHh BjTdSuxexk5DRcT1GSrLO/qMHFGMC1b2Ddwovfqt5yM79rmXwekqxrCKorG/8ji0ann3 o3Wr+lheG42zuu10KLS3zMmr+SOWvcEnfAUWjo2B84/JaYvA9m4bm8V5GrOLzQA2MZWY TWmA== X-Gm-Message-State: ABuFfojzNdCx81cFSxAX04yPQ2nqjqrNJtoBZX0YhXJAPE15M2O/ppIQ 6ma2pQPzMs6MSCXF41mi80mQhQ== X-Google-Smtp-Source: ACcGV62jUKQ08v22v3vIhXoVq3Rc/sYsS1RW7mhnmQmf8WDFV0RfxpB6QhVx3k79ViRK/oHHNtygsQ== X-Received: by 2002:a17:902:8205:: with SMTP id x5-v6mr6704330pln.55.1539362247706; Fri, 12 Oct 2018 09:37:27 -0700 (PDT) Received: from localhost ([2620:0:1000:1601:3aef:314f:b9ea:889f]) by smtp.gmail.com with ESMTPSA id k77-v6sm5032857pfg.1.2018.10.12.09.37.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Oct 2018 09:37:26 -0700 (PDT) Date: Fri, 12 Oct 2018 09:37:25 -0700 From: Joel Fernandes To: "Kirill A. Shutemov" Subject: Re: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions Message-ID: <20181012163725.GB223066@joelaf.mtv.corp.google.com> References: <20181012013756.11285-1-joel@joelfernandes.org> <20181012110906.fpfttp4nhvsr2ps7@kshutemo-mobl1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181012110906.fpfttp4nhvsr2ps7@kshutemo-mobl1> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Sat, 13 Oct 2018 08:58:20 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mips@linux-mips.org, Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , Catalin Marinas , Dave Hansen , Will Deacon , Michal Hocko , linux-mm@kvack.org, lokeshgidra@google.com, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, elfring@users.sourceforge.net, Jonas Bonn , linux-s390@vger.kernel.org, dancol@google.com, Yoshinori Sato , linux-xtensa@linux-xtensa.org, linux-hexagon@vger.kernel.org, Helge Deller , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , hughd@google.com, "James E.J. Bottomley" , kasan-dev@googlegroups.com, kvmarm@lists.cs.columbia.edu, Ingo Molnar , Geert Uytterhoeven , Andrey Ryabinin , linux-snps-arc@lists.infradead.org, kernel-team@android.com, Sam Creasey , Fenghua Yu , Jeff Dike , linux-um@lists.infradead.org, Stefan Kristiansson , Julia Lawall , linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Borislav Petkov , Andy Lutomirski , nios2-dev@lists.rocketboards.org, Stafford Horne , Guan Xuetao , linux-arm-kernel@lists.infradead.org, Chris Zankel , Tony Luck , Richard Weinberger , linux-parisc@vger.kernel.org, pantin@google.com, Max Filippov , linux-kernel@vger.kernel.org, minchan@kernel.org, Thomas Gleixner , linux-alpha@vger.kernel.org, Ley Foon Tan , akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Oct 12, 2018 at 02:09:06PM +0300, Kirill A. Shutemov wrote: > On Thu, Oct 11, 2018 at 06:37:55PM -0700, Joel Fernandes (Google) wrote: > > diff --git a/arch/m68k/include/asm/mcf_pgalloc.h b/arch/m68k/include/asm/mcf_pgalloc.h > > index 12fe700632f4..4399d712f6db 100644 > > --- a/arch/m68k/include/asm/mcf_pgalloc.h > > +++ b/arch/m68k/include/asm/mcf_pgalloc.h > > @@ -12,8 +12,7 @@ extern inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) > > > > extern const char bad_pmd_string[]; > > > > -extern inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm, > > - unsigned long address) > > +extern inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) > > { > > unsigned long page = __get_free_page(GFP_DMA); > > > > @@ -32,8 +31,6 @@ extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, unsigned long address) > > #define pmd_alloc_one_fast(mm, address) ({ BUG(); ((pmd_t *)1); }) > > #define pmd_alloc_one(mm, address) ({ BUG(); ((pmd_t *)2); }) > > > > -#define pte_alloc_one_fast(mm, addr) pte_alloc_one(mm, addr) > > - > > I believe this was one done manually, right? > Please explicitely state everthing you did on not of sematic patch Ok, I can update the changelog with that information next time I send it. This is the only thing I didn't mention in the changelog since it was a trivial unused function deletion.. but I mentioned everything else.. And sir, you are one thorough reviewer! ;-) - Joel [..]