* Re: linux-next: Tree for Oct 15 [not found] ` <20181015182637.GA16445@roeck-us.net> @ 2018-10-15 20:12 ` Stephen Rothwell 2018-10-15 20:24 ` Stephen Rothwell 2018-10-15 20:35 ` Rob Herring 0 siblings, 2 replies; 21+ messages in thread From: Stephen Rothwell @ 2018-10-15 20:12 UTC (permalink / raw) To: Guenter Roeck Cc: Linux Kernel Mailing List, Linux-Next Mailing List, Rob Herring, PowerPC [-- Attachment #1: Type: text/plain, Size: 5216 bytes --] Hi Guenter, [Just cc'ing the PPC and devicetree folks] On Mon, 15 Oct 2018 11:26:37 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > On Mon, Oct 15, 2018 at 07:25:46PM +1100, Stephen Rothwell wrote: > > > > My qemu boots of a powerpc pseries_le_defconfig kernel failed today. > > Same here. Interestingly, this only affects little endian pseries > boots; big endian works fine. I'll try to bisect later. > > ALl ppc qemu tests (including big endian pseries) also generate a warning. > > WARNING: CPU: 0 PID: 0 at mm/memblock.c:1301 .memblock_alloc_range_nid+0x20/0x68 > Modules linked in: > CPU: 0 PID: 0 Comm: swapper Not tainted 4.19.0-rc7-next-20181015 #1 > NIP: c000000000f99198 LR: c000000000f99490 CTR: c000000000bb8364 > REGS: c000000001217a78 TRAP: 0700 Not tainted (4.19.0-rc7-next-20181015) > MSR: 0000000080021000 <CE,ME> CR: 24000422 XER: 20000000 > IRQMASK: 1 > GPR00: c000000000f99490 c000000001217d00 c00000000121a500 00000000000000c0 > GPR04: 0000000000000000 0000000000000000 0000000000000000 ffffffffffffffff > GPR08: 0000000000000000 00000000000000c0 0000000000000018 00000000000000b7 > GPR12: 0000000000000040 c000000000fe7840 0000000000000000 0000000000000000 > GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > GPR24: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > GPR28: c000000000000304 c000000001262088 00000000000000c0 c000000000fea500 > NIP [c000000000f99198] .memblock_alloc_range_nid+0x20/0x68 > LR [c000000000f99490] .memblock_alloc_base+0x18/0x48 > Call Trace: > [c000000001217d00] [c000000002a00000] 0xc000000002a00000 (unreliable) > [c000000001217d80] [c000000000f99490] .memblock_alloc_base+0x18/0x48 > [c000000001217df0] [c000000000f7a274] .allocate_paca_ptrs+0x3c/0x74 > [c000000001217e70] [c000000000f78bf0] .early_init_devtree+0x288/0x320 > [c000000001217f10] [c000000000f79b6c] .early_setup+0x80/0x130 > [c000000001217f90] [c000000000000528] start_here_multiplatform+0x68/0x80 > > > sparc images crash, starting with next-20181009. Bisect with > next-201810112 points to the merge of devicetree/for-next, though > devicetree/for-next itself does not have the problem (bisect log > attached below). The crash is in devicetree code. > > Crash logs: > https://kerneltests.org/builders/qemu-sparc64-next/builds/981/steps/qemubuildcommand_1/logs/stdio > https://kerneltests.org/builders/qemu-sparc-next/builds/975/steps/qemubuildcommand_1/logs/stdio > > Guenter > > --- > # bad: [774ea0551a2966c8fc29a6f675c3e28c5c6fa586] Add linux-next specific files for 20181012 > # good: [0238df646e6224016a45505d2c111a24669ebe21] Linux 4.19-rc7 > git bisect start 'HEAD' 'v4.19-rc7' > # good: [dfbf78faefa3c26d94208398e62bf25ea798e7f2] Merge remote-tracking branch 'spi-nor/spi-nor/next' > git bisect good dfbf78faefa3c26d94208398e62bf25ea798e7f2 > # bad: [3f296bb430327676912966c56d2f078f74e6b4ab] Merge remote-tracking branch 'tip/auto-latest' > git bisect bad 3f296bb430327676912966c56d2f078f74e6b4ab > # good: [efad9cbc89fbef3c4b3905e1c01a8191eae4c772] Merge remote-tracking branch 'sound/for-next' > git bisect good efad9cbc89fbef3c4b3905e1c01a8191eae4c772 > # good: [7d12a265b24001fbff1ff260c2f6bd802224a7c0] Merge remote-tracking branch 'iommu/next' > git bisect good 7d12a265b24001fbff1ff260c2f6bd802224a7c0 > # good: [4fc72c0ef3c1e792caf06d25ef68c7c871730e31] Merge branch 'ras/core' > git bisect good 4fc72c0ef3c1e792caf06d25ef68c7c871730e31 > # good: [d74865bd3996c7a6f3e8ce6e626c1fe474e39494] Merge branch 'x86/mm' > git bisect good d74865bd3996c7a6f3e8ce6e626c1fe474e39494 > # bad: [1b1ab6a98adab8a0436024b369305a978e365a13] Merge remote-tracking branch 'mailbox/mailbox-for-next' > git bisect bad 1b1ab6a98adab8a0436024b369305a978e365a13 > # good: [389d0a8a7af8ff8bb6301382333c7e8f748d7cd6] Merge branch 'dt/cpu-type-rework' into dt/next > git bisect good 389d0a8a7af8ff8bb6301382333c7e8f748d7cd6 > # good: [4355151de47c2b4bc72c026ee743bd9ed7f71ba3] Merge branch 'all-dtbs' into dt/next > git bisect good 4355151de47c2b4bc72c026ee743bd9ed7f71ba3 > # good: [60d744213fd9433b10b23afafb694a44c8e96cb8] Merge remote-tracking branch 'vfio/next' > git bisect good 60d744213fd9433b10b23afafb694a44c8e96cb8 > # good: [9f0a0a381c5db56e7922dbeea6831f27db58372f] mailbox: mediatek: Add check for possible failure of kzalloc > git bisect good 9f0a0a381c5db56e7922dbeea6831f27db58372f > # good: [157b4129ded8ba756ef17c058192e734889673e4] dt-bindings: arm: fsl: Move DCFG and SCFG bindings to their own docs > git bisect good 157b4129ded8ba756ef17c058192e734889673e4 > # bad: [bed61948ea6c57bc73fb3ded9421c1bdd8cbe4d9] Merge remote-tracking branch 'devicetree/for-next' > git bisect bad bed61948ea6c57bc73fb3ded9421c1bdd8cbe4d9 > # good: [d81cc4a8e47219fbe60d49446f04ed3e9c1657d9] dt-bindings: arm: zte: Move sysctrl bindings to their own doc > git bisect good d81cc4a8e47219fbe60d49446f04ed3e9c1657d9 > # first bad commit: [bed61948ea6c57bc73fb3ded9421c1bdd8cbe4d9] Merge remote-tracking branch 'devicetree/for-next' -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 20:12 ` linux-next: Tree for Oct 15 Stephen Rothwell @ 2018-10-15 20:24 ` Stephen Rothwell 2018-10-15 22:13 ` Andrew Morton 2018-10-15 20:35 ` Rob Herring 1 sibling, 1 reply; 21+ messages in thread From: Stephen Rothwell @ 2018-10-15 20:24 UTC (permalink / raw) To: Guenter Roeck Cc: Mike Rapoport, Linux Kernel Mailing List, Linux-Next Mailing List, Rob Herring, Andrew Morton, PowerPC [-- Attachment #1: Type: text/plain, Size: 2439 bytes --] Hi all, On Tue, 16 Oct 2018 07:12:40 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Mon, 15 Oct 2018 11:26:37 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > ALl ppc qemu tests (including big endian pseries) also generate a warning. > > > > WARNING: CPU: 0 PID: 0 at mm/memblock.c:1301 .memblock_alloc_range_nid+0x20/0x68 That is: static phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, phys_addr_t align, phys_addr_t start, phys_addr_t end, int nid, enum memblock_flags flags) { if (WARN_ON_ONCE(!align)) align = SMP_CACHE_BYTES; Looks like patch "memblock: stop using implicit alignment to SMP_CACHE_BYTES" missed some places ... > > Modules linked in: > > CPU: 0 PID: 0 Comm: swapper Not tainted 4.19.0-rc7-next-20181015 #1 > > NIP: c000000000f99198 LR: c000000000f99490 CTR: c000000000bb8364 > > REGS: c000000001217a78 TRAP: 0700 Not tainted (4.19.0-rc7-next-20181015) > > MSR: 0000000080021000 <CE,ME> CR: 24000422 XER: 20000000 > > IRQMASK: 1 > > GPR00: c000000000f99490 c000000001217d00 c00000000121a500 00000000000000c0 > > GPR04: 0000000000000000 0000000000000000 0000000000000000 ffffffffffffffff > > GPR08: 0000000000000000 00000000000000c0 0000000000000018 00000000000000b7 > > GPR12: 0000000000000040 c000000000fe7840 0000000000000000 0000000000000000 > > GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > GPR24: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > GPR28: c000000000000304 c000000001262088 00000000000000c0 c000000000fea500 > > NIP [c000000000f99198] .memblock_alloc_range_nid+0x20/0x68 > > LR [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > Call Trace: > > [c000000001217d00] [c000000002a00000] 0xc000000002a00000 (unreliable) > > [c000000001217d80] [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > [c000000001217df0] [c000000000f7a274] .allocate_paca_ptrs+0x3c/0x74 > > [c000000001217e70] [c000000000f78bf0] .early_init_devtree+0x288/0x320 > > [c000000001217f10] [c000000000f79b6c] .early_setup+0x80/0x130 > > [c000000001217f90] [c000000000000528] start_here_multiplatform+0x68/0x80 -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 20:24 ` Stephen Rothwell @ 2018-10-15 22:13 ` Andrew Morton 2018-10-16 13:36 ` Mike Rapoport 0 siblings, 1 reply; 21+ messages in thread From: Andrew Morton @ 2018-10-15 22:13 UTC (permalink / raw) To: Stephen Rothwell Cc: Mike Rapoport, Linux Kernel Mailing List, Linux-Next Mailing List, Rob Herring, PowerPC, Guenter Roeck On Tue, 16 Oct 2018 07:24:39 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > On Tue, 16 Oct 2018 07:12:40 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > On Mon, 15 Oct 2018 11:26:37 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > ALl ppc qemu tests (including big endian pseries) also generate a warning. > > > > > > WARNING: CPU: 0 PID: 0 at mm/memblock.c:1301 .memblock_alloc_range_nid+0x20/0x68 > > That is: > > static phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > phys_addr_t align, phys_addr_t start, > phys_addr_t end, int nid, > enum memblock_flags flags) > { > if (WARN_ON_ONCE(!align)) > align = SMP_CACHE_BYTES; > > Looks like patch > > "memblock: stop using implicit alignment to SMP_CACHE_BYTES" > > missed some places ... To be expected, I guess. I'm pretty relaxed about this ;) Let's do another sweep in a week or so, after which we'll have a couple of months to mop up any leftovers. ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 22:13 ` Andrew Morton @ 2018-10-16 13:36 ` Mike Rapoport 2018-10-16 20:41 ` Stephen Rothwell 0 siblings, 1 reply; 21+ messages in thread From: Mike Rapoport @ 2018-10-16 13:36 UTC (permalink / raw) To: Andrew Morton Cc: Stephen Rothwell, Mike Rapoport, Linux Kernel Mailing List, Linux-Next Mailing List, Rob Herring, PowerPC, Guenter Roeck On Mon, Oct 15, 2018 at 03:13:19PM -0700, Andrew Morton wrote: > On Tue, 16 Oct 2018 07:24:39 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > On Tue, 16 Oct 2018 07:12:40 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > > > On Mon, 15 Oct 2018 11:26:37 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > > > ALl ppc qemu tests (including big endian pseries) also generate a warning. > > > > > > > > WARNING: CPU: 0 PID: 0 at mm/memblock.c:1301 .memblock_alloc_range_nid+0x20/0x68 > > > > That is: > > > > static phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > > phys_addr_t align, phys_addr_t start, > > phys_addr_t end, int nid, > > enum memblock_flags flags) > > { > > if (WARN_ON_ONCE(!align)) > > align = SMP_CACHE_BYTES; > > > > Looks like patch > > > > "memblock: stop using implicit alignment to SMP_CACHE_BYTES" > > > > missed some places ... > > To be expected, I guess. I'm pretty relaxed about this ;) Let's do > another sweep in a week or so, after which we'll have a couple of > months to mop up any leftovers. After some more grepping and spatching I've found these: From 8b014bae53a78ab747dbb76b9aff7df4cefcb604 Mon Sep 17 00:00:00 2001 From: Mike Rapoport <rppt@linux.ibm.com> Date: Tue, 16 Oct 2018 16:03:00 +0300 Subject: [PATCH] memblock: fix missed uses of implicit aligment A couple of memblock*alloc uses were missed during conversion from implicit alignment setting with 'align = 0' to explictly using SMP_CACHE_BYTES. Fix them now. Signed-off-by: Mike Rapoport <rppt@linux.ibm.com> --- arch/powerpc/kernel/paca.c | 2 +- drivers/firmware/efi/memmap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/paca.c b/arch/powerpc/kernel/paca.c index f331a00..913bfca 100644 --- a/arch/powerpc/kernel/paca.c +++ b/arch/powerpc/kernel/paca.c @@ -198,7 +198,7 @@ void __init allocate_paca_ptrs(void) paca_nr_cpu_ids = nr_cpu_ids; paca_ptrs_size = sizeof(struct paca_struct *) * nr_cpu_ids; - paca_ptrs = __va(memblock_phys_alloc(paca_ptrs_size, 0)); + paca_ptrs = __va(memblock_phys_alloc(paca_ptrs_size, SMP_CACHE_BYTES)); memset(paca_ptrs, 0x88, paca_ptrs_size); } diff --git a/drivers/firmware/efi/memmap.c b/drivers/firmware/efi/memmap.c index ef618bc..fa2904f 100644 --- a/drivers/firmware/efi/memmap.c +++ b/drivers/firmware/efi/memmap.c @@ -15,7 +15,7 @@ static phys_addr_t __init __efi_memmap_alloc_early(unsigned long size) { - return memblock_phys_alloc(size, 0); + return memblock_phys_alloc(size, SMP_CACHE_BYTES); } static phys_addr_t __init __efi_memmap_alloc_late(unsigned long size) -- 2.7.4 -- Sincerely yours, Mike. ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-16 13:36 ` Mike Rapoport @ 2018-10-16 20:41 ` Stephen Rothwell 0 siblings, 0 replies; 21+ messages in thread From: Stephen Rothwell @ 2018-10-16 20:41 UTC (permalink / raw) To: Mike Rapoport Cc: Mike Rapoport, Linux Kernel Mailing List, Linux-Next Mailing List, Rob Herring, Andrew Morton, PowerPC, Guenter Roeck [-- Attachment #1: Type: text/plain, Size: 773 bytes --] Hi Mike, On Tue, 16 Oct 2018 16:36:56 +0300 Mike Rapoport <rppt@linux.ibm.com> wrote: > > After some more grepping and spatching I've found these: > > From 8b014bae53a78ab747dbb76b9aff7df4cefcb604 Mon Sep 17 00:00:00 2001 > From: Mike Rapoport <rppt@linux.ibm.com> > Date: Tue, 16 Oct 2018 16:03:00 +0300 > Subject: [PATCH] memblock: fix missed uses of implicit aligment > > A couple of memblock*alloc uses were missed during conversion from implicit > alignment setting with 'align = 0' to explictly using SMP_CACHE_BYTES. > Fix them now. > > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com> Thanks. I have added that to linux-next today as it should get rid of the stack trace we are seeing in PowerPC boots. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 20:12 ` linux-next: Tree for Oct 15 Stephen Rothwell 2018-10-15 20:24 ` Stephen Rothwell @ 2018-10-15 20:35 ` Rob Herring 2018-10-15 21:18 ` Guenter Roeck 2018-10-16 1:00 ` Rob Herring 1 sibling, 2 replies; 21+ messages in thread From: Rob Herring @ 2018-10-15 20:35 UTC (permalink / raw) To: Stephen Rothwell Cc: linux-kernel@vger.kernel.org, linux-next, linuxppc-dev, Guenter Roeck On Mon, Oct 15, 2018 at 3:12 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > Hi Guenter, > > [Just cc'ing the PPC and devicetree folks] > > On Mon, 15 Oct 2018 11:26:37 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > On Mon, Oct 15, 2018 at 07:25:46PM +1100, Stephen Rothwell wrote: > > > > > > My qemu boots of a powerpc pseries_le_defconfig kernel failed today. > > > > Same here. Interestingly, this only affects little endian pseries > > boots; big endian works fine. I'll try to bisect later. > > > > ALl ppc qemu tests (including big endian pseries) also generate a warning. > > > > WARNING: CPU: 0 PID: 0 at mm/memblock.c:1301 .memblock_alloc_range_nid+0x20/0x68 > > Modules linked in: > > CPU: 0 PID: 0 Comm: swapper Not tainted 4.19.0-rc7-next-20181015 #1 > > NIP: c000000000f99198 LR: c000000000f99490 CTR: c000000000bb8364 > > REGS: c000000001217a78 TRAP: 0700 Not tainted (4.19.0-rc7-next-20181015) > > MSR: 0000000080021000 <CE,ME> CR: 24000422 XER: 20000000 > > IRQMASK: 1 > > GPR00: c000000000f99490 c000000001217d00 c00000000121a500 00000000000000c0 > > GPR04: 0000000000000000 0000000000000000 0000000000000000 ffffffffffffffff > > GPR08: 0000000000000000 00000000000000c0 0000000000000018 00000000000000b7 > > GPR12: 0000000000000040 c000000000fe7840 0000000000000000 0000000000000000 > > GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > GPR24: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > GPR28: c000000000000304 c000000001262088 00000000000000c0 c000000000fea500 > > NIP [c000000000f99198] .memblock_alloc_range_nid+0x20/0x68 > > LR [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > Call Trace: > > [c000000001217d00] [c000000002a00000] 0xc000000002a00000 (unreliable) > > [c000000001217d80] [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > [c000000001217df0] [c000000000f7a274] .allocate_paca_ptrs+0x3c/0x74 > > [c000000001217e70] [c000000000f78bf0] .early_init_devtree+0x288/0x320 > > [c000000001217f10] [c000000000f79b6c] .early_setup+0x80/0x130 > > [c000000001217f90] [c000000000000528] start_here_multiplatform+0x68/0x80 > > > > > > sparc images crash, starting with next-20181009. Bisect with > > next-201810112 points to the merge of devicetree/for-next, though > > devicetree/for-next itself does not have the problem (bisect log > > attached below). The crash is in devicetree code. > > > > Crash logs: > > https://kerneltests.org/builders/qemu-sparc64-next/builds/981/steps/qemubuildcommand_1/logs/stdio > > https://kerneltests.org/builders/qemu-sparc-next/builds/975/steps/qemubuildcommand_1/logs/stdio The sparc crash appears to be related to changes I made. Looking into it. Rob ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 20:35 ` Rob Herring @ 2018-10-15 21:18 ` Guenter Roeck 2018-10-15 21:48 ` Rob Herring 2018-10-16 1:00 ` Rob Herring 1 sibling, 1 reply; 21+ messages in thread From: Guenter Roeck @ 2018-10-15 21:18 UTC (permalink / raw) To: Rob Herring Cc: Stephen Rothwell, linux-kernel@vger.kernel.org, linux-next, linuxppc-dev On Mon, Oct 15, 2018 at 03:35:12PM -0500, Rob Herring wrote: > On Mon, Oct 15, 2018 at 3:12 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > Hi Guenter, > > > > [Just cc'ing the PPC and devicetree folks] > > > > On Mon, 15 Oct 2018 11:26:37 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > On Mon, Oct 15, 2018 at 07:25:46PM +1100, Stephen Rothwell wrote: > > > > > > > > My qemu boots of a powerpc pseries_le_defconfig kernel failed today. > > > > > > Same here. Interestingly, this only affects little endian pseries > > > boots; big endian works fine. I'll try to bisect later. > > > > > > ALl ppc qemu tests (including big endian pseries) also generate a warning. > > > > > > WARNING: CPU: 0 PID: 0 at mm/memblock.c:1301 .memblock_alloc_range_nid+0x20/0x68 > > > Modules linked in: > > > CPU: 0 PID: 0 Comm: swapper Not tainted 4.19.0-rc7-next-20181015 #1 > > > NIP: c000000000f99198 LR: c000000000f99490 CTR: c000000000bb8364 > > > REGS: c000000001217a78 TRAP: 0700 Not tainted (4.19.0-rc7-next-20181015) > > > MSR: 0000000080021000 <CE,ME> CR: 24000422 XER: 20000000 > > > IRQMASK: 1 > > > GPR00: c000000000f99490 c000000001217d00 c00000000121a500 00000000000000c0 > > > GPR04: 0000000000000000 0000000000000000 0000000000000000 ffffffffffffffff > > > GPR08: 0000000000000000 00000000000000c0 0000000000000018 00000000000000b7 > > > GPR12: 0000000000000040 c000000000fe7840 0000000000000000 0000000000000000 > > > GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > GPR24: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > GPR28: c000000000000304 c000000001262088 00000000000000c0 c000000000fea500 > > > NIP [c000000000f99198] .memblock_alloc_range_nid+0x20/0x68 > > > LR [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > Call Trace: > > > [c000000001217d00] [c000000002a00000] 0xc000000002a00000 (unreliable) > > > [c000000001217d80] [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > [c000000001217df0] [c000000000f7a274] .allocate_paca_ptrs+0x3c/0x74 > > > [c000000001217e70] [c000000000f78bf0] .early_init_devtree+0x288/0x320 > > > [c000000001217f10] [c000000000f79b6c] .early_setup+0x80/0x130 > > > [c000000001217f90] [c000000000000528] start_here_multiplatform+0x68/0x80 > > > > > > > > > sparc images crash, starting with next-20181009. Bisect with > > > next-201810112 points to the merge of devicetree/for-next, though > > > devicetree/for-next itself does not have the problem (bisect log > > > attached below). The crash is in devicetree code. > > > > > > Crash logs: > > > https://kerneltests.org/builders/qemu-sparc64-next/builds/981/steps/qemubuildcommand_1/logs/stdio > > > https://kerneltests.org/builders/qemu-sparc-next/builds/975/steps/qemubuildcommand_1/logs/stdio > > The sparc crash appears to be related to changes I made. Looking into it. > Let me know if you need me to test anything or do some debugging. Thanks, Guenter ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 21:18 ` Guenter Roeck @ 2018-10-15 21:48 ` Rob Herring 2018-10-15 22:10 ` Guenter Roeck 0 siblings, 1 reply; 21+ messages in thread From: Rob Herring @ 2018-10-15 21:48 UTC (permalink / raw) To: Guenter Roeck Cc: Stephen Rothwell, linux-kernel@vger.kernel.org, linux-next, linuxppc-dev On Mon, Oct 15, 2018 at 4:18 PM Guenter Roeck <linux@roeck-us.net> wrote: > > On Mon, Oct 15, 2018 at 03:35:12PM -0500, Rob Herring wrote: > > On Mon, Oct 15, 2018 at 3:12 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > > > Hi Guenter, > > > > > > [Just cc'ing the PPC and devicetree folks] > > > > > > On Mon, 15 Oct 2018 11:26:37 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > > > On Mon, Oct 15, 2018 at 07:25:46PM +1100, Stephen Rothwell wrote: > > > > > > > > > > My qemu boots of a powerpc pseries_le_defconfig kernel failed today. > > > > > > > > Same here. Interestingly, this only affects little endian pseries > > > > boots; big endian works fine. I'll try to bisect later. > > > > > > > > ALl ppc qemu tests (including big endian pseries) also generate a warning. > > > > > > > > WARNING: CPU: 0 PID: 0 at mm/memblock.c:1301 .memblock_alloc_range_nid+0x20/0x68 > > > > Modules linked in: > > > > CPU: 0 PID: 0 Comm: swapper Not tainted 4.19.0-rc7-next-20181015 #1 > > > > NIP: c000000000f99198 LR: c000000000f99490 CTR: c000000000bb8364 > > > > REGS: c000000001217a78 TRAP: 0700 Not tainted (4.19.0-rc7-next-20181015) > > > > MSR: 0000000080021000 <CE,ME> CR: 24000422 XER: 20000000 > > > > IRQMASK: 1 > > > > GPR00: c000000000f99490 c000000001217d00 c00000000121a500 00000000000000c0 > > > > GPR04: 0000000000000000 0000000000000000 0000000000000000 ffffffffffffffff > > > > GPR08: 0000000000000000 00000000000000c0 0000000000000018 00000000000000b7 > > > > GPR12: 0000000000000040 c000000000fe7840 0000000000000000 0000000000000000 > > > > GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > GPR24: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > GPR28: c000000000000304 c000000001262088 00000000000000c0 c000000000fea500 > > > > NIP [c000000000f99198] .memblock_alloc_range_nid+0x20/0x68 > > > > LR [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > > Call Trace: > > > > [c000000001217d00] [c000000002a00000] 0xc000000002a00000 (unreliable) > > > > [c000000001217d80] [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > > [c000000001217df0] [c000000000f7a274] .allocate_paca_ptrs+0x3c/0x74 > > > > [c000000001217e70] [c000000000f78bf0] .early_init_devtree+0x288/0x320 > > > > [c000000001217f10] [c000000000f79b6c] .early_setup+0x80/0x130 > > > > [c000000001217f90] [c000000000000528] start_here_multiplatform+0x68/0x80 > > > > > > > > > > > > sparc images crash, starting with next-20181009. Bisect with > > > > next-201810112 points to the merge of devicetree/for-next, though > > > > devicetree/for-next itself does not have the problem (bisect log > > > > attached below). The crash is in devicetree code. > > > > > > > > Crash logs: > > > > https://kerneltests.org/builders/qemu-sparc64-next/builds/981/steps/qemubuildcommand_1/logs/stdio > > > > https://kerneltests.org/builders/qemu-sparc-next/builds/975/steps/qemubuildcommand_1/logs/stdio > > > > The sparc crash appears to be related to changes I made. Looking into it. > > > > Let me know if you need me to test anything or do some debugging. Well, I'm not having any luck getting sparc qemu to work. Here's what I'm trying with a sparc32_defconfig kernel: $ qemu-system-sparc -kernel .build-sparc/vmlinux -M SS-4 -nographic -m 256 -no-reboot rom: requested regions overlap (rom phdr #0: .build-sparc/vmlinux. free=0x000000000000057a, addr=0x0000000000000000) qemu-system-sparc: rom check and register reset failed Using zImage or image file didn't work any better. Then I tried sticking the kernel in a disk image, but that didn't get much farther. Rob ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 21:48 ` Rob Herring @ 2018-10-15 22:10 ` Guenter Roeck 2018-10-15 22:13 ` Rob Herring 0 siblings, 1 reply; 21+ messages in thread From: Guenter Roeck @ 2018-10-15 22:10 UTC (permalink / raw) To: Rob Herring Cc: Stephen Rothwell, linux-kernel@vger.kernel.org, linux-next, linuxppc-dev On Mon, Oct 15, 2018 at 04:48:27PM -0500, Rob Herring wrote: > On Mon, Oct 15, 2018 at 4:18 PM Guenter Roeck <linux@roeck-us.net> wrote: > > > > On Mon, Oct 15, 2018 at 03:35:12PM -0500, Rob Herring wrote: > > > On Mon, Oct 15, 2018 at 3:12 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > > > > > Hi Guenter, > > > > > > > > [Just cc'ing the PPC and devicetree folks] > > > > > > > > On Mon, 15 Oct 2018 11:26:37 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > > > > > On Mon, Oct 15, 2018 at 07:25:46PM +1100, Stephen Rothwell wrote: > > > > > > > > > > > > My qemu boots of a powerpc pseries_le_defconfig kernel failed today. > > > > > > > > > > Same here. Interestingly, this only affects little endian pseries > > > > > boots; big endian works fine. I'll try to bisect later. > > > > > > > > > > ALl ppc qemu tests (including big endian pseries) also generate a warning. > > > > > > > > > > WARNING: CPU: 0 PID: 0 at mm/memblock.c:1301 .memblock_alloc_range_nid+0x20/0x68 > > > > > Modules linked in: > > > > > CPU: 0 PID: 0 Comm: swapper Not tainted 4.19.0-rc7-next-20181015 #1 > > > > > NIP: c000000000f99198 LR: c000000000f99490 CTR: c000000000bb8364 > > > > > REGS: c000000001217a78 TRAP: 0700 Not tainted (4.19.0-rc7-next-20181015) > > > > > MSR: 0000000080021000 <CE,ME> CR: 24000422 XER: 20000000 > > > > > IRQMASK: 1 > > > > > GPR00: c000000000f99490 c000000001217d00 c00000000121a500 00000000000000c0 > > > > > GPR04: 0000000000000000 0000000000000000 0000000000000000 ffffffffffffffff > > > > > GPR08: 0000000000000000 00000000000000c0 0000000000000018 00000000000000b7 > > > > > GPR12: 0000000000000040 c000000000fe7840 0000000000000000 0000000000000000 > > > > > GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > GPR24: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > GPR28: c000000000000304 c000000001262088 00000000000000c0 c000000000fea500 > > > > > NIP [c000000000f99198] .memblock_alloc_range_nid+0x20/0x68 > > > > > LR [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > > > Call Trace: > > > > > [c000000001217d00] [c000000002a00000] 0xc000000002a00000 (unreliable) > > > > > [c000000001217d80] [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > > > [c000000001217df0] [c000000000f7a274] .allocate_paca_ptrs+0x3c/0x74 > > > > > [c000000001217e70] [c000000000f78bf0] .early_init_devtree+0x288/0x320 > > > > > [c000000001217f10] [c000000000f79b6c] .early_setup+0x80/0x130 > > > > > [c000000001217f90] [c000000000000528] start_here_multiplatform+0x68/0x80 > > > > > > > > > > > > > > > sparc images crash, starting with next-20181009. Bisect with > > > > > next-201810112 points to the merge of devicetree/for-next, though > > > > > devicetree/for-next itself does not have the problem (bisect log > > > > > attached below). The crash is in devicetree code. > > > > > > > > > > Crash logs: > > > > > https://kerneltests.org/builders/qemu-sparc64-next/builds/981/steps/qemubuildcommand_1/logs/stdio > > > > > https://kerneltests.org/builders/qemu-sparc-next/builds/975/steps/qemubuildcommand_1/logs/stdio > > > > > > The sparc crash appears to be related to changes I made. Looking into it. > > > > > > > Let me know if you need me to test anything or do some debugging. > > Well, I'm not having any luck getting sparc qemu to work. Here's what > I'm trying with a sparc32_defconfig kernel: > > $ qemu-system-sparc -kernel .build-sparc/vmlinux -M SS-4 -nographic -m > 256 -no-reboot > rom: requested regions overlap (rom phdr #0: .build-sparc/vmlinux. > free=0x000000000000057a, addr=0x0000000000000000) > qemu-system-sparc: rom check and register reset failed > What is your qemu version ? Guenter > Using zImage or image file didn't work any better. > > Then I tried sticking the kernel in a disk image, but that didn't get > much farther. > > Rob ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 22:10 ` Guenter Roeck @ 2018-10-15 22:13 ` Rob Herring 2018-10-15 22:28 ` Guenter Roeck 2018-10-15 22:34 ` Guenter Roeck 0 siblings, 2 replies; 21+ messages in thread From: Rob Herring @ 2018-10-15 22:13 UTC (permalink / raw) To: Guenter Roeck Cc: Stephen Rothwell, linux-kernel@vger.kernel.org, linux-next, linuxppc-dev On Mon, Oct 15, 2018 at 5:10 PM Guenter Roeck <linux@roeck-us.net> wrote: > > On Mon, Oct 15, 2018 at 04:48:27PM -0500, Rob Herring wrote: > > On Mon, Oct 15, 2018 at 4:18 PM Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > On Mon, Oct 15, 2018 at 03:35:12PM -0500, Rob Herring wrote: > > > > On Mon, Oct 15, 2018 at 3:12 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > > > > > > > Hi Guenter, > > > > > > > > > > [Just cc'ing the PPC and devicetree folks] > > > > > > > > > > On Mon, 15 Oct 2018 11:26:37 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > > > > > > > On Mon, Oct 15, 2018 at 07:25:46PM +1100, Stephen Rothwell wrote: > > > > > > > > > > > > > > My qemu boots of a powerpc pseries_le_defconfig kernel failed today. > > > > > > > > > > > > Same here. Interestingly, this only affects little endian pseries > > > > > > boots; big endian works fine. I'll try to bisect later. > > > > > > > > > > > > ALl ppc qemu tests (including big endian pseries) also generate a warning. > > > > > > > > > > > > WARNING: CPU: 0 PID: 0 at mm/memblock.c:1301 .memblock_alloc_range_nid+0x20/0x68 > > > > > > Modules linked in: > > > > > > CPU: 0 PID: 0 Comm: swapper Not tainted 4.19.0-rc7-next-20181015 #1 > > > > > > NIP: c000000000f99198 LR: c000000000f99490 CTR: c000000000bb8364 > > > > > > REGS: c000000001217a78 TRAP: 0700 Not tainted (4.19.0-rc7-next-20181015) > > > > > > MSR: 0000000080021000 <CE,ME> CR: 24000422 XER: 20000000 > > > > > > IRQMASK: 1 > > > > > > GPR00: c000000000f99490 c000000001217d00 c00000000121a500 00000000000000c0 > > > > > > GPR04: 0000000000000000 0000000000000000 0000000000000000 ffffffffffffffff > > > > > > GPR08: 0000000000000000 00000000000000c0 0000000000000018 00000000000000b7 > > > > > > GPR12: 0000000000000040 c000000000fe7840 0000000000000000 0000000000000000 > > > > > > GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > > GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > > GPR24: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > > GPR28: c000000000000304 c000000001262088 00000000000000c0 c000000000fea500 > > > > > > NIP [c000000000f99198] .memblock_alloc_range_nid+0x20/0x68 > > > > > > LR [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > > > > Call Trace: > > > > > > [c000000001217d00] [c000000002a00000] 0xc000000002a00000 (unreliable) > > > > > > [c000000001217d80] [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > > > > [c000000001217df0] [c000000000f7a274] .allocate_paca_ptrs+0x3c/0x74 > > > > > > [c000000001217e70] [c000000000f78bf0] .early_init_devtree+0x288/0x320 > > > > > > [c000000001217f10] [c000000000f79b6c] .early_setup+0x80/0x130 > > > > > > [c000000001217f90] [c000000000000528] start_here_multiplatform+0x68/0x80 > > > > > > > > > > > > > > > > > > sparc images crash, starting with next-20181009. Bisect with > > > > > > next-201810112 points to the merge of devicetree/for-next, though > > > > > > devicetree/for-next itself does not have the problem (bisect log > > > > > > attached below). The crash is in devicetree code. > > > > > > > > > > > > Crash logs: > > > > > > https://kerneltests.org/builders/qemu-sparc64-next/builds/981/steps/qemubuildcommand_1/logs/stdio > > > > > > https://kerneltests.org/builders/qemu-sparc-next/builds/975/steps/qemubuildcommand_1/logs/stdio > > > > > > > > The sparc crash appears to be related to changes I made. Looking into it. > > > > > > > > > > Let me know if you need me to test anything or do some debugging. > > > > Well, I'm not having any luck getting sparc qemu to work. Here's what > > I'm trying with a sparc32_defconfig kernel: > > > > $ qemu-system-sparc -kernel .build-sparc/vmlinux -M SS-4 -nographic -m > > 256 -no-reboot > > rom: requested regions overlap (rom phdr #0: .build-sparc/vmlinux. > > free=0x000000000000057a, addr=0x0000000000000000) > > qemu-system-sparc: rom check and register reset failed > > > > What is your qemu version ? 2.11 from ubuntu 18.04: QEMU emulator version 2.11.1(Debian 1:2.11+dfsg-1ubuntu7.5) Rob ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 22:13 ` Rob Herring @ 2018-10-15 22:28 ` Guenter Roeck 2018-10-15 22:34 ` Guenter Roeck 1 sibling, 0 replies; 21+ messages in thread From: Guenter Roeck @ 2018-10-15 22:28 UTC (permalink / raw) To: Rob Herring Cc: Stephen Rothwell, linux-kernel@vger.kernel.org, linux-next, linuxppc-dev On Mon, Oct 15, 2018 at 05:13:08PM -0500, Rob Herring wrote: > On Mon, Oct 15, 2018 at 5:10 PM Guenter Roeck <linux@roeck-us.net> wrote: > > > > On Mon, Oct 15, 2018 at 04:48:27PM -0500, Rob Herring wrote: > > > On Mon, Oct 15, 2018 at 4:18 PM Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > > > On Mon, Oct 15, 2018 at 03:35:12PM -0500, Rob Herring wrote: > > > > > On Mon, Oct 15, 2018 at 3:12 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > > > > > > > > > Hi Guenter, > > > > > > > > > > > > [Just cc'ing the PPC and devicetree folks] > > > > > > > > > > > > On Mon, 15 Oct 2018 11:26:37 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > > > > > > > > > On Mon, Oct 15, 2018 at 07:25:46PM +1100, Stephen Rothwell wrote: > > > > > > > > > > > > > > > > My qemu boots of a powerpc pseries_le_defconfig kernel failed today. > > > > > > > > > > > > > > Same here. Interestingly, this only affects little endian pseries > > > > > > > boots; big endian works fine. I'll try to bisect later. > > > > > > > > > > > > > > ALl ppc qemu tests (including big endian pseries) also generate a warning. > > > > > > > > > > > > > > WARNING: CPU: 0 PID: 0 at mm/memblock.c:1301 .memblock_alloc_range_nid+0x20/0x68 > > > > > > > Modules linked in: > > > > > > > CPU: 0 PID: 0 Comm: swapper Not tainted 4.19.0-rc7-next-20181015 #1 > > > > > > > NIP: c000000000f99198 LR: c000000000f99490 CTR: c000000000bb8364 > > > > > > > REGS: c000000001217a78 TRAP: 0700 Not tainted (4.19.0-rc7-next-20181015) > > > > > > > MSR: 0000000080021000 <CE,ME> CR: 24000422 XER: 20000000 > > > > > > > IRQMASK: 1 > > > > > > > GPR00: c000000000f99490 c000000001217d00 c00000000121a500 00000000000000c0 > > > > > > > GPR04: 0000000000000000 0000000000000000 0000000000000000 ffffffffffffffff > > > > > > > GPR08: 0000000000000000 00000000000000c0 0000000000000018 00000000000000b7 > > > > > > > GPR12: 0000000000000040 c000000000fe7840 0000000000000000 0000000000000000 > > > > > > > GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > > > GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > > > GPR24: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > > > GPR28: c000000000000304 c000000001262088 00000000000000c0 c000000000fea500 > > > > > > > NIP [c000000000f99198] .memblock_alloc_range_nid+0x20/0x68 > > > > > > > LR [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > > > > > Call Trace: > > > > > > > [c000000001217d00] [c000000002a00000] 0xc000000002a00000 (unreliable) > > > > > > > [c000000001217d80] [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > > > > > [c000000001217df0] [c000000000f7a274] .allocate_paca_ptrs+0x3c/0x74 > > > > > > > [c000000001217e70] [c000000000f78bf0] .early_init_devtree+0x288/0x320 > > > > > > > [c000000001217f10] [c000000000f79b6c] .early_setup+0x80/0x130 > > > > > > > [c000000001217f90] [c000000000000528] start_here_multiplatform+0x68/0x80 > > > > > > > > > > > > > > > > > > > > > sparc images crash, starting with next-20181009. Bisect with > > > > > > > next-201810112 points to the merge of devicetree/for-next, though > > > > > > > devicetree/for-next itself does not have the problem (bisect log > > > > > > > attached below). The crash is in devicetree code. > > > > > > > > > > > > > > Crash logs: > > > > > > > https://kerneltests.org/builders/qemu-sparc64-next/builds/981/steps/qemubuildcommand_1/logs/stdio > > > > > > > https://kerneltests.org/builders/qemu-sparc-next/builds/975/steps/qemubuildcommand_1/logs/stdio > > > > > > > > > > The sparc crash appears to be related to changes I made. Looking into it. > > > > > > > > > > > > > Let me know if you need me to test anything or do some debugging. > > > > > > Well, I'm not having any luck getting sparc qemu to work. Here's what > > > I'm trying with a sparc32_defconfig kernel: > > > > > > $ qemu-system-sparc -kernel .build-sparc/vmlinux -M SS-4 -nographic -m > > > 256 -no-reboot > > > rom: requested regions overlap (rom phdr #0: .build-sparc/vmlinux. > > > free=0x000000000000057a, addr=0x0000000000000000) > > > qemu-system-sparc: rom check and register reset failed > > > > > > > What is your qemu version ? > > 2.11 from ubuntu 18.04: > QEMU emulator version 2.11.1(Debian 1:2.11+dfsg-1ubuntu7.5) > This works for me: qemu-system-sparc -M SS-4 -kernel arch/sparc/boot/zImage -no-reboot \ -drive file=hda.sqf,if=scsi,format=raw \ -append 'root=/dev/sda rw init=/sbin/init.sh panic=1 console=ttyS0' \ -nographic -monitor none arch/sparc/boot/image works as well. This is with qemu 2.5 (from Ubuntu 16.04). I'll try with 2.11 tonight. My current private version is based on qemu 3.0. Guenter ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 22:13 ` Rob Herring 2018-10-15 22:28 ` Guenter Roeck @ 2018-10-15 22:34 ` Guenter Roeck 2018-10-15 22:52 ` Rob Herring 1 sibling, 1 reply; 21+ messages in thread From: Guenter Roeck @ 2018-10-15 22:34 UTC (permalink / raw) To: Rob Herring Cc: Stephen Rothwell, linux-kernel@vger.kernel.org, linux-next, linuxppc-dev On Mon, Oct 15, 2018 at 05:13:08PM -0500, Rob Herring wrote: > On Mon, Oct 15, 2018 at 5:10 PM Guenter Roeck <linux@roeck-us.net> wrote: > > > > On Mon, Oct 15, 2018 at 04:48:27PM -0500, Rob Herring wrote: > > > On Mon, Oct 15, 2018 at 4:18 PM Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > > > On Mon, Oct 15, 2018 at 03:35:12PM -0500, Rob Herring wrote: > > > > > On Mon, Oct 15, 2018 at 3:12 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > > > > > > > > > Hi Guenter, > > > > > > > > > > > > [Just cc'ing the PPC and devicetree folks] > > > > > > > > > > > > On Mon, 15 Oct 2018 11:26:37 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > > > > > > > > > On Mon, Oct 15, 2018 at 07:25:46PM +1100, Stephen Rothwell wrote: > > > > > > > > > > > > > > > > My qemu boots of a powerpc pseries_le_defconfig kernel failed today. > > > > > > > > > > > > > > Same here. Interestingly, this only affects little endian pseries > > > > > > > boots; big endian works fine. I'll try to bisect later. > > > > > > > > > > > > > > ALl ppc qemu tests (including big endian pseries) also generate a warning. > > > > > > > > > > > > > > WARNING: CPU: 0 PID: 0 at mm/memblock.c:1301 .memblock_alloc_range_nid+0x20/0x68 > > > > > > > Modules linked in: > > > > > > > CPU: 0 PID: 0 Comm: swapper Not tainted 4.19.0-rc7-next-20181015 #1 > > > > > > > NIP: c000000000f99198 LR: c000000000f99490 CTR: c000000000bb8364 > > > > > > > REGS: c000000001217a78 TRAP: 0700 Not tainted (4.19.0-rc7-next-20181015) > > > > > > > MSR: 0000000080021000 <CE,ME> CR: 24000422 XER: 20000000 > > > > > > > IRQMASK: 1 > > > > > > > GPR00: c000000000f99490 c000000001217d00 c00000000121a500 00000000000000c0 > > > > > > > GPR04: 0000000000000000 0000000000000000 0000000000000000 ffffffffffffffff > > > > > > > GPR08: 0000000000000000 00000000000000c0 0000000000000018 00000000000000b7 > > > > > > > GPR12: 0000000000000040 c000000000fe7840 0000000000000000 0000000000000000 > > > > > > > GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > > > GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > > > GPR24: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > > > GPR28: c000000000000304 c000000001262088 00000000000000c0 c000000000fea500 > > > > > > > NIP [c000000000f99198] .memblock_alloc_range_nid+0x20/0x68 > > > > > > > LR [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > > > > > Call Trace: > > > > > > > [c000000001217d00] [c000000002a00000] 0xc000000002a00000 (unreliable) > > > > > > > [c000000001217d80] [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > > > > > [c000000001217df0] [c000000000f7a274] .allocate_paca_ptrs+0x3c/0x74 > > > > > > > [c000000001217e70] [c000000000f78bf0] .early_init_devtree+0x288/0x320 > > > > > > > [c000000001217f10] [c000000000f79b6c] .early_setup+0x80/0x130 > > > > > > > [c000000001217f90] [c000000000000528] start_here_multiplatform+0x68/0x80 > > > > > > > > > > > > > > > > > > > > > sparc images crash, starting with next-20181009. Bisect with > > > > > > > next-201810112 points to the merge of devicetree/for-next, though > > > > > > > devicetree/for-next itself does not have the problem (bisect log > > > > > > > attached below). The crash is in devicetree code. > > > > > > > > > > > > > > Crash logs: > > > > > > > https://kerneltests.org/builders/qemu-sparc64-next/builds/981/steps/qemubuildcommand_1/logs/stdio > > > > > > > https://kerneltests.org/builders/qemu-sparc-next/builds/975/steps/qemubuildcommand_1/logs/stdio > > > > > > > > > > The sparc crash appears to be related to changes I made. Looking into it. > > > > > > > > > > > > > Let me know if you need me to test anything or do some debugging. > > > > > > Well, I'm not having any luck getting sparc qemu to work. Here's what > > > I'm trying with a sparc32_defconfig kernel: > > > > > > $ qemu-system-sparc -kernel .build-sparc/vmlinux -M SS-4 -nographic -m > > > 256 -no-reboot > > > rom: requested regions overlap (rom phdr #0: .build-sparc/vmlinux. > > > free=0x000000000000057a, addr=0x0000000000000000) > > > qemu-system-sparc: rom check and register reset failed > > > > > > > What is your qemu version ? > > 2.11 from ubuntu 18.04: > QEMU emulator version 2.11.1(Debian 1:2.11+dfsg-1ubuntu7.5) > Update: Works for me with QEMU emulator version 2.11.93 (Debian 1:2.12~rc3+dfsg-1) with the following command line. qemu-system-sparc -M SS-4 -kernel arch/sparc/boot/zImage -no-reboot \ -drive file=hda.sqf,if=scsi,format=raw \ -append 'root=/dev/sda rw init=/sbin/init.sh panic=1 console=ttyS0' \ -nographic -monitor none I have to enable DEVTMPFS and SQUASHFS for my root file system to work, but otherwise it is sparc32_defconfig. Guenter ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 22:34 ` Guenter Roeck @ 2018-10-15 22:52 ` Rob Herring 0 siblings, 0 replies; 21+ messages in thread From: Rob Herring @ 2018-10-15 22:52 UTC (permalink / raw) To: Guenter Roeck Cc: Stephen Rothwell, linux-kernel@vger.kernel.org, linux-next, linuxppc-dev On Mon, Oct 15, 2018 at 5:34 PM Guenter Roeck <linux@roeck-us.net> wrote: > > On Mon, Oct 15, 2018 at 05:13:08PM -0500, Rob Herring wrote: > > On Mon, Oct 15, 2018 at 5:10 PM Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > On Mon, Oct 15, 2018 at 04:48:27PM -0500, Rob Herring wrote: > > > > On Mon, Oct 15, 2018 at 4:18 PM Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > > > > > On Mon, Oct 15, 2018 at 03:35:12PM -0500, Rob Herring wrote: > > > > > > On Mon, Oct 15, 2018 at 3:12 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > > > > > > > > > > > Hi Guenter, > > > > > > > > > > > > > > [Just cc'ing the PPC and devicetree folks] > > > > > > > > > > > > > > On Mon, 15 Oct 2018 11:26:37 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > > > > > > > > > > > On Mon, Oct 15, 2018 at 07:25:46PM +1100, Stephen Rothwell wrote: > > > > > > > > > > > > > > > > > > My qemu boots of a powerpc pseries_le_defconfig kernel failed today. > > > > > > > > > > > > > > > > Same here. Interestingly, this only affects little endian pseries > > > > > > > > boots; big endian works fine. I'll try to bisect later. > > > > > > > > > > > > > > > > ALl ppc qemu tests (including big endian pseries) also generate a warning. > > > > > > > > > > > > > > > > WARNING: CPU: 0 PID: 0 at mm/memblock.c:1301 .memblock_alloc_range_nid+0x20/0x68 > > > > > > > > Modules linked in: > > > > > > > > CPU: 0 PID: 0 Comm: swapper Not tainted 4.19.0-rc7-next-20181015 #1 > > > > > > > > NIP: c000000000f99198 LR: c000000000f99490 CTR: c000000000bb8364 > > > > > > > > REGS: c000000001217a78 TRAP: 0700 Not tainted (4.19.0-rc7-next-20181015) > > > > > > > > MSR: 0000000080021000 <CE,ME> CR: 24000422 XER: 20000000 > > > > > > > > IRQMASK: 1 > > > > > > > > GPR00: c000000000f99490 c000000001217d00 c00000000121a500 00000000000000c0 > > > > > > > > GPR04: 0000000000000000 0000000000000000 0000000000000000 ffffffffffffffff > > > > > > > > GPR08: 0000000000000000 00000000000000c0 0000000000000018 00000000000000b7 > > > > > > > > GPR12: 0000000000000040 c000000000fe7840 0000000000000000 0000000000000000 > > > > > > > > GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > > > > GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > > > > GPR24: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > > > > > > GPR28: c000000000000304 c000000001262088 00000000000000c0 c000000000fea500 > > > > > > > > NIP [c000000000f99198] .memblock_alloc_range_nid+0x20/0x68 > > > > > > > > LR [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > > > > > > Call Trace: > > > > > > > > [c000000001217d00] [c000000002a00000] 0xc000000002a00000 (unreliable) > > > > > > > > [c000000001217d80] [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > > > > > > [c000000001217df0] [c000000000f7a274] .allocate_paca_ptrs+0x3c/0x74 > > > > > > > > [c000000001217e70] [c000000000f78bf0] .early_init_devtree+0x288/0x320 > > > > > > > > [c000000001217f10] [c000000000f79b6c] .early_setup+0x80/0x130 > > > > > > > > [c000000001217f90] [c000000000000528] start_here_multiplatform+0x68/0x80 > > > > > > > > > > > > > > > > > > > > > > > > sparc images crash, starting with next-20181009. Bisect with > > > > > > > > next-201810112 points to the merge of devicetree/for-next, though > > > > > > > > devicetree/for-next itself does not have the problem (bisect log > > > > > > > > attached below). The crash is in devicetree code. > > > > > > > > > > > > > > > > Crash logs: > > > > > > > > https://kerneltests.org/builders/qemu-sparc64-next/builds/981/steps/qemubuildcommand_1/logs/stdio > > > > > > > > https://kerneltests.org/builders/qemu-sparc-next/builds/975/steps/qemubuildcommand_1/logs/stdio > > > > > > > > > > > > The sparc crash appears to be related to changes I made. Looking into it. > > > > > > > > > > > > > > > > Let me know if you need me to test anything or do some debugging. > > > > > > > > Well, I'm not having any luck getting sparc qemu to work. Here's what > > > > I'm trying with a sparc32_defconfig kernel: > > > > > > > > $ qemu-system-sparc -kernel .build-sparc/vmlinux -M SS-4 -nographic -m > > > > 256 -no-reboot > > > > rom: requested regions overlap (rom phdr #0: .build-sparc/vmlinux. > > > > free=0x000000000000057a, addr=0x0000000000000000) > > > > qemu-system-sparc: rom check and register reset failed > > > > > > > > > > What is your qemu version ? > > > > 2.11 from ubuntu 18.04: > > QEMU emulator version 2.11.1(Debian 1:2.11+dfsg-1ubuntu7.5) > > > > Update: Works for me with > QEMU emulator version 2.11.93 (Debian 1:2.12~rc3+dfsg-1) Seems to be some regression in 2.11.1. It works fine with my own build with 3.0 based. Rob ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 20:35 ` Rob Herring 2018-10-15 21:18 ` Guenter Roeck @ 2018-10-16 1:00 ` Rob Herring 2018-10-16 1:34 ` David Miller 1 sibling, 1 reply; 21+ messages in thread From: Rob Herring @ 2018-10-16 1:00 UTC (permalink / raw) To: Stephen Rothwell, David Miller Cc: linux-kernel@vger.kernel.org, linux-next, linuxppc-dev, Guenter Roeck +davem On Mon, Oct 15, 2018 at 3:35 PM Rob Herring <robherring2@gmail.com> wrote: > > On Mon, Oct 15, 2018 at 3:12 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > Hi Guenter, > > > > [Just cc'ing the PPC and devicetree folks] > > > > On Mon, 15 Oct 2018 11:26:37 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > On Mon, Oct 15, 2018 at 07:25:46PM +1100, Stephen Rothwell wrote: > > > > > > > > My qemu boots of a powerpc pseries_le_defconfig kernel failed today. > > > > > > Same here. Interestingly, this only affects little endian pseries > > > boots; big endian works fine. I'll try to bisect later. > > > > > > ALl ppc qemu tests (including big endian pseries) also generate a warning. > > > > > > WARNING: CPU: 0 PID: 0 at mm/memblock.c:1301 .memblock_alloc_range_nid+0x20/0x68 > > > Modules linked in: > > > CPU: 0 PID: 0 Comm: swapper Not tainted 4.19.0-rc7-next-20181015 #1 > > > NIP: c000000000f99198 LR: c000000000f99490 CTR: c000000000bb8364 > > > REGS: c000000001217a78 TRAP: 0700 Not tainted (4.19.0-rc7-next-20181015) > > > MSR: 0000000080021000 <CE,ME> CR: 24000422 XER: 20000000 > > > IRQMASK: 1 > > > GPR00: c000000000f99490 c000000001217d00 c00000000121a500 00000000000000c0 > > > GPR04: 0000000000000000 0000000000000000 0000000000000000 ffffffffffffffff > > > GPR08: 0000000000000000 00000000000000c0 0000000000000018 00000000000000b7 > > > GPR12: 0000000000000040 c000000000fe7840 0000000000000000 0000000000000000 > > > GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > GPR24: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > > > GPR28: c000000000000304 c000000001262088 00000000000000c0 c000000000fea500 > > > NIP [c000000000f99198] .memblock_alloc_range_nid+0x20/0x68 > > > LR [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > Call Trace: > > > [c000000001217d00] [c000000002a00000] 0xc000000002a00000 (unreliable) > > > [c000000001217d80] [c000000000f99490] .memblock_alloc_base+0x18/0x48 > > > [c000000001217df0] [c000000000f7a274] .allocate_paca_ptrs+0x3c/0x74 > > > [c000000001217e70] [c000000000f78bf0] .early_init_devtree+0x288/0x320 > > > [c000000001217f10] [c000000000f79b6c] .early_setup+0x80/0x130 > > > [c000000001217f90] [c000000000000528] start_here_multiplatform+0x68/0x80 > > > > > > > > > sparc images crash, starting with next-20181009. Bisect with > > > next-201810112 points to the merge of devicetree/for-next, though > > > devicetree/for-next itself does not have the problem (bisect log > > > attached below). The crash is in devicetree code. > > > > > > Crash logs: > > > https://kerneltests.org/builders/qemu-sparc64-next/builds/981/steps/qemubuildcommand_1/logs/stdio > > > https://kerneltests.org/builders/qemu-sparc-next/builds/975/steps/qemubuildcommand_1/logs/stdio > > The sparc crash appears to be related to changes I made. Looking into it. The problem is a combination of commit 0b9871a3a8cc ("sparc: Convert to using %pOFn instead of device_node.name") and commit 6d0a70a284be ("vsprintf: print OF node name using full_name"). The Sparc functions in prom_*.c can't use %pOFn to ultimately construct full_name as %pOFn is derived from full_name. Reverting the former commit gets QEMU booting again. David, Can you revert commit 0b9871a3a8cc. I'll have to find another approach. Rob ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-16 1:00 ` Rob Herring @ 2018-10-16 1:34 ` David Miller 0 siblings, 0 replies; 21+ messages in thread From: David Miller @ 2018-10-16 1:34 UTC (permalink / raw) To: robherring2; +Cc: sfr, linux-kernel, linux-next, linuxppc-dev, linux From: Rob Herring <robherring2@gmail.com> Date: Mon, 15 Oct 2018 20:00:24 -0500 > David, Can you revert commit 0b9871a3a8cc. I'll have to find another approach. Ok. ^ permalink raw reply [flat|nested] 21+ messages in thread
[parent not found: <20181015193914.GA9881@roeck-us.net>]
* Re: linux-next: Tree for Oct 15 [not found] ` <20181015193914.GA9881@roeck-us.net> @ 2018-10-15 20:33 ` Stephen Rothwell 2018-10-15 21:35 ` Guenter Roeck 2018-10-15 22:22 ` Guenter Roeck 0 siblings, 2 replies; 21+ messages in thread From: Stephen Rothwell @ 2018-10-15 20:33 UTC (permalink / raw) To: Guenter Roeck Cc: Linux Kernel Mailing List, Mike Rapoport, Linux-Next Mailing List, Andrew Morton, PowerPC [-- Attachment #1: Type: text/plain, Size: 3200 bytes --] Hi Guenter, [Again, just cc'ing the PPC folks] On Mon, 15 Oct 2018 12:39:14 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > On Mon, Oct 15, 2018 at 07:25:46PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20181012: > > > > My qemu boots of a powerpc pseries_le_defconfig kernel failed today. > > > > Bisect log: > > # bad: [774ea0551a2966c8fc29a6f675c3e28c5c6fa586] Add linux-next specific files for 20181012 > # good: [0238df646e6224016a45505d2c111a24669ebe21] Linux 4.19-rc7 > git bisect start 'HEAD' 'v4.19-rc7' > # good: [dfbf78faefa3c26d94208398e62bf25ea798e7f2] Merge remote-tracking branch 'spi-nor/spi-nor/next' > git bisect good dfbf78faefa3c26d94208398e62bf25ea798e7f2 > # good: [3f296bb430327676912966c56d2f078f74e6b4ab] Merge remote-tracking branch 'tip/auto-latest' > git bisect good 3f296bb430327676912966c56d2f078f74e6b4ab > # good: [056ff0c45d1780f7bac1b54bd4160647efc500ad] Merge remote-tracking branch 'staging/staging-next' > git bisect good 056ff0c45d1780f7bac1b54bd4160647efc500ad > # good: [d7946b50c21a7d88af6c8e88d976ba3dfca651cc] Merge remote-tracking branch 'pinctrl/for-next' > git bisect good d7946b50c21a7d88af6c8e88d976ba3dfca651cc > # good: [72b5ca3121d5352fbb8fe3e1abaa86748205c0cb] Merge remote-tracking branch 'xarray/xarray' > git bisect good 72b5ca3121d5352fbb8fe3e1abaa86748205c0cb > # good: [e3895cf23a25da6dea2c8e986d4f6c24fafe5448] hugetlb: introduce generic version of prepare_hugepage_range > git bisect good e3895cf23a25da6dea2c8e986d4f6c24fafe5448 > # good: [627f8833ac26e66d4b50676a0251499474bb4ee4] reiserfs: propagate errors from fill_with_dentries() properly > git bisect good 627f8833ac26e66d4b50676a0251499474bb4ee4 > # good: [e38910adf47ba1d0b5a5a573cc26bde1ec533147] memblock: replace alloc_bootmem_pages_node with memblock_alloc_node > git bisect good e38910adf47ba1d0b5a5a573cc26bde1ec533147 > # bad: [f89bdd2c52666d9da4bf4ef3a97a7188586ba0fb] dma-direct: fix up for the removal of linux/bootmem.h > git bisect bad f89bdd2c52666d9da4bf4ef3a97a7188586ba0fb > # good: [3108d998dfc36eb7f6b7f2917fc561258f742094] mm: nobootmem: remove bootmem allocation APIs > git bisect good 3108d998dfc36eb7f6b7f2917fc561258f742094 > # good: [1f94dacb1d0ed0d1068b89ad867a198d3eca7bf2] memblock: rename __free_pages_bootmem to memblock_free_pages > git bisect good 1f94dacb1d0ed0d1068b89ad867a198d3eca7bf2 > # good: [c3954ade0c1b499ae587f3edb813876216212836] memblock: replace BOOTMEM_ALLOC_* with MEMBLOCK variants > git bisect good c3954ade0c1b499ae587f3edb813876216212836 > # bad: [cde1c7f7e92aef241f1c1a09a4d1f1f06fd565b6] mm: remove include/linux/bootmem.h > git bisect bad cde1c7f7e92aef241f1c1a09a4d1f1f06fd565b6 > # first bad commit: [cde1c7f7e92aef241f1c1a09a4d1f1f06fd565b6] mm: remove include/linux/bootmem.h > > Reverting this patch together with its fix-up "powerpc: fix up for removal of > linux/bootmem.h" fixes the problem. This also fixes the traceback seen with all > other ppc64 images. > > Guenter Thanks for this ... though a strange result as those patches were in next-20181012 as well, so I wonder what else changed. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 20:33 ` Stephen Rothwell @ 2018-10-15 21:35 ` Guenter Roeck 2018-10-15 22:22 ` Guenter Roeck 1 sibling, 0 replies; 21+ messages in thread From: Guenter Roeck @ 2018-10-15 21:35 UTC (permalink / raw) To: Stephen Rothwell Cc: Linux Kernel Mailing List, Mike Rapoport, Linux-Next Mailing List, Andrew Morton, PowerPC On Tue, Oct 16, 2018 at 07:33:59AM +1100, Stephen Rothwell wrote: > Hi Guenter, > > [Again, just cc'ing the PPC folks] > > On Mon, 15 Oct 2018 12:39:14 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > On Mon, Oct 15, 2018 at 07:25:46PM +1100, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since 20181012: > > > > > > My qemu boots of a powerpc pseries_le_defconfig kernel failed today. > > > > > > > Bisect log: > > > > # bad: [774ea0551a2966c8fc29a6f675c3e28c5c6fa586] Add linux-next specific files for 20181012 > > # good: [0238df646e6224016a45505d2c111a24669ebe21] Linux 4.19-rc7 > > git bisect start 'HEAD' 'v4.19-rc7' > > # good: [dfbf78faefa3c26d94208398e62bf25ea798e7f2] Merge remote-tracking branch 'spi-nor/spi-nor/next' > > git bisect good dfbf78faefa3c26d94208398e62bf25ea798e7f2 > > # good: [3f296bb430327676912966c56d2f078f74e6b4ab] Merge remote-tracking branch 'tip/auto-latest' > > git bisect good 3f296bb430327676912966c56d2f078f74e6b4ab > > # good: [056ff0c45d1780f7bac1b54bd4160647efc500ad] Merge remote-tracking branch 'staging/staging-next' > > git bisect good 056ff0c45d1780f7bac1b54bd4160647efc500ad > > # good: [d7946b50c21a7d88af6c8e88d976ba3dfca651cc] Merge remote-tracking branch 'pinctrl/for-next' > > git bisect good d7946b50c21a7d88af6c8e88d976ba3dfca651cc > > # good: [72b5ca3121d5352fbb8fe3e1abaa86748205c0cb] Merge remote-tracking branch 'xarray/xarray' > > git bisect good 72b5ca3121d5352fbb8fe3e1abaa86748205c0cb > > # good: [e3895cf23a25da6dea2c8e986d4f6c24fafe5448] hugetlb: introduce generic version of prepare_hugepage_range > > git bisect good e3895cf23a25da6dea2c8e986d4f6c24fafe5448 > > # good: [627f8833ac26e66d4b50676a0251499474bb4ee4] reiserfs: propagate errors from fill_with_dentries() properly > > git bisect good 627f8833ac26e66d4b50676a0251499474bb4ee4 > > # good: [e38910adf47ba1d0b5a5a573cc26bde1ec533147] memblock: replace alloc_bootmem_pages_node with memblock_alloc_node > > git bisect good e38910adf47ba1d0b5a5a573cc26bde1ec533147 > > # bad: [f89bdd2c52666d9da4bf4ef3a97a7188586ba0fb] dma-direct: fix up for the removal of linux/bootmem.h > > git bisect bad f89bdd2c52666d9da4bf4ef3a97a7188586ba0fb > > # good: [3108d998dfc36eb7f6b7f2917fc561258f742094] mm: nobootmem: remove bootmem allocation APIs > > git bisect good 3108d998dfc36eb7f6b7f2917fc561258f742094 > > # good: [1f94dacb1d0ed0d1068b89ad867a198d3eca7bf2] memblock: rename __free_pages_bootmem to memblock_free_pages > > git bisect good 1f94dacb1d0ed0d1068b89ad867a198d3eca7bf2 > > # good: [c3954ade0c1b499ae587f3edb813876216212836] memblock: replace BOOTMEM_ALLOC_* with MEMBLOCK variants > > git bisect good c3954ade0c1b499ae587f3edb813876216212836 > > # bad: [cde1c7f7e92aef241f1c1a09a4d1f1f06fd565b6] mm: remove include/linux/bootmem.h > > git bisect bad cde1c7f7e92aef241f1c1a09a4d1f1f06fd565b6 > > # first bad commit: [cde1c7f7e92aef241f1c1a09a4d1f1f06fd565b6] mm: remove include/linux/bootmem.h > > > > Reverting this patch together with its fix-up "powerpc: fix up for removal of > > linux/bootmem.h" fixes the problem. This also fixes the traceback seen with all > > other ppc64 images. > > > > Guenter > > Thanks for this ... though a strange result as those patches were in > next-20181012 as well, so I wonder what else changed. > Quite simple - the bisect is wrong. For some reason I started with next-20181012 (which was fine), not 20181015 (which is broken). Repeating it now. Sorry for the confusion. Guenter ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 20:33 ` Stephen Rothwell 2018-10-15 21:35 ` Guenter Roeck @ 2018-10-15 22:22 ` Guenter Roeck 2018-10-16 2:02 ` Stephen Rothwell 1 sibling, 1 reply; 21+ messages in thread From: Guenter Roeck @ 2018-10-15 22:22 UTC (permalink / raw) To: Stephen Rothwell Cc: Linux Kernel Mailing List, Mike Rapoport, Linux-Next Mailing List, Andrew Morton, PowerPC On Tue, Oct 16, 2018 at 07:33:59AM +1100, Stephen Rothwell wrote: > Hi Guenter, > > [Again, just cc'ing the PPC folks] > > On Mon, 15 Oct 2018 12:39:14 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > On Mon, Oct 15, 2018 at 07:25:46PM +1100, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since 20181012: > > > > > > My qemu boots of a powerpc pseries_le_defconfig kernel failed today. > > > > > > > Bisect log: > > Trying again. Not very useful since some of the steps fail with compile errors. The problem does seem to be related to the bootmem changes, though. I might try again tonight if I find the time. Guenter # bad: [ca0591d03a2d373e0019ad357fbbee69c8272381] Add linux-next specific files for 20181015 # good: [0238df646e6224016a45505d2c111a24669ebe21] Linux 4.19-rc7 git bisect start 'HEAD' 'v4.19-rc7' # good: [2fc8fb4c02a0f7b9d5e5b4de80cbcef7c808068b] Merge remote-tracking branch 'spi-nor/spi-nor/next' git bisect good 2fc8fb4c02a0f7b9d5e5b4de80cbcef7c808068b # good: [a54eefdf4d208f6904da9e836ff32d7dde0c9516] Merge remote-tracking branch 'tip/auto-latest' git bisect good a54eefdf4d208f6904da9e836ff32d7dde0c9516 # good: [d71e0d25be750d02a3d04500aeb151bb94465811] Merge remote-tracking branch 'staging/staging-next' git bisect good d71e0d25be750d02a3d04500aeb151bb94465811 # good: [7961c8ea9d81f927a78e30bb7c194310ed6b7c1d] Merge remote-tracking branch 'pinctrl/for-next' git bisect good 7961c8ea9d81f927a78e30bb7c194310ed6b7c1d # good: [c3d392e6aae57d54fdc683f7432c3e248602bebb] Merge remote-tracking branch 'xarray/xarray' git bisect good c3d392e6aae57d54fdc683f7432c3e248602bebb # good: [880c1034475c873963d6250eb95ebbbf5604a281] userfaultfd: selftest: cleanup help messages git bisect good 880c1034475c873963d6250eb95ebbbf5604a281 # good: [9f1fa0ab60f7b09d335bbaf33db9116241059708] reiserfs: propagate errors from fill_with_dentries() properly git bisect good 9f1fa0ab60f7b09d335bbaf33db9116241059708 # good: [596046ffd571f32fa3d3e7ffdf7861b71a258552] memblock: replace alloc_bootmem_low with memblock_alloc_low (2) git bisect good 596046ffd571f32fa3d3e7ffdf7861b71a258552 # bad: [ef07e25e5bb02b420cb66004420cea3e0d65d107] dma-direct: fix up for the removal of linux/bootmem.h git bisect bad ef07e25e5bb02b420cb66004420cea3e0d65d107 # good: [ddaa897c9ab76969a74d67a65b6616895f349644] memblock: replace alloc_bootmem with memblock_alloc git bisect good ddaa897c9ab76969a74d67a65b6616895f349644 # good: [3b79243c2ef23d829a2f01f8c9526f17b80a7a32] memblock: rename free_all_bootmem to memblock_free_all git bisect good 3b79243c2ef23d829a2f01f8c9526f17b80a7a32 # good: [d5fa9634892df2bc6bab6101f18df6ba5a2490c5] mm: remove nobootmem git bisect good d5fa9634892df2bc6bab6101f18df6ba5a2490c5 # bad: [75fd637c22bc9bb5c959b7f93c2c5e5f0495992c] mm: remove include/linux/bootmem.h git bisect bad 75fd637c22bc9bb5c959b7f93c2c5e5f0495992c # good: [979961b3058df1a6d24ab423dd6fa6f20982f591] memblock: replace BOOTMEM_ALLOC_* with MEMBLOCK variants git bisect good 979961b3058df1a6d24ab423dd6fa6f20982f591 # first bad commit: [75fd637c22bc9bb5c959b7f93c2c5e5f0495992c] mm: remove include/linux/bootmem.h ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-15 22:22 ` Guenter Roeck @ 2018-10-16 2:02 ` Stephen Rothwell 2018-10-16 2:19 ` Stephen Rothwell 0 siblings, 1 reply; 21+ messages in thread From: Stephen Rothwell @ 2018-10-16 2:02 UTC (permalink / raw) To: Guenter Roeck Cc: Linux Kernel Mailing List, Mike Rapoport, Linux-Next Mailing List, Andrew Morton, PowerPC [-- Attachment #1: Type: text/plain, Size: 7773 bytes --] Hi all, On Mon, 15 Oct 2018 15:22:13 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > On Tue, Oct 16, 2018 at 07:33:59AM +1100, Stephen Rothwell wrote: > > > > On Mon, 15 Oct 2018 12:39:14 -0700 Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > On Mon, Oct 15, 2018 at 07:25:46PM +1100, Stephen Rothwell wrote: > > > > Hi all, > > > > > > > > Changes since 20181012: > > > > > > > > My qemu boots of a powerpc pseries_le_defconfig kernel failed today. > > > > > > > > > > Bisect log: > > > > > Trying again. Not very useful since some of the steps fail with compile errors. > The problem does seem to be related to the bootmem changes, though. OK, I managed to do the bisect: fe3d2a45e8079fdd7d4da1ff07f4b40bc3cb499f is the first bad commit commit fe3d2a45e8079fdd7d4da1ff07f4b40bc3cb499f Author: Mike Rapoport <rppt@linux.vnet.ibm.com> Date: Sat Oct 13 14:05:51 2018 +1100 memblock: stop using implicit alignment to SMP_CACHE_BYTES When a memblock allocation APIs are called with align = 0, the alignment is implicitly set to SMP_CACHE_BYTES. Implicit alignment is done deep in the memblock allocator and it can come as a surprise. Not that such an alignment would be wrong even when used incorrectly but it is better to be explicit for the sake of clarity and the prinicple of the least surprise. Replace all such uses of memblock APIs with the 'align' parameter explicitly set to SMP_CACHE_BYTES and stop implicit alignment assignment in the memblock internal allocation functions. For the case when memblock APIs are used via helper functions, e.g. like iommu_arena_new_node() in Alpha, the helper functions were detected with Coccinelle's help and then manually examined and updated where appropriate. The direct memblock APIs users were updated using the semantic patch below: @@ expression size, min_addr, max_addr, nid; @@ ( | - memblock_alloc_try_nid_raw(size, 0, min_addr, max_addr, nid) + memblock_alloc_try_nid_raw(size, SMP_CACHE_BYTES, min_addr, max_addr, nid) | - memblock_alloc_try_nid_nopanic(size, 0, min_addr, max_addr, nid) + memblock_alloc_try_nid_nopanic(size, SMP_CACHE_BYTES, min_addr, max_addr, nid) | - memblock_alloc_try_nid(size, 0, min_addr, max_addr, nid) + memblock_alloc_try_nid(size, SMP_CACHE_BYTES, min_addr, max_addr, nid) | - memblock_alloc(size, 0) + memblock_alloc(size, SMP_CACHE_BYTES) | - memblock_alloc_raw(size, 0) + memblock_alloc_raw(size, SMP_CACHE_BYTES) | - memblock_alloc_from(size, 0, min_addr) + memblock_alloc_from(size, SMP_CACHE_BYTES, min_addr) | - memblock_alloc_nopanic(size, 0) + memblock_alloc_nopanic(size, SMP_CACHE_BYTES) | - memblock_alloc_low(size, 0) + memblock_alloc_low(size, SMP_CACHE_BYTES) | - memblock_alloc_low_nopanic(size, 0) + memblock_alloc_low_nopanic(size, SMP_CACHE_BYTES) | - memblock_alloc_from_nopanic(size, 0, min_addr) + memblock_alloc_from_nopanic(size, SMP_CACHE_BYTES, min_addr) | - memblock_alloc_node(size, 0, nid) + memblock_alloc_node(size, SMP_CACHE_BYTES, nid) ) [mhocko@suse.com: changelog update] Link: http://lkml.kernel.org/r/1538687224-17535-1-git-send-email-rppt@linux.vnet.ibm.com Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> Suggested-by: Michal Hocko <mhocko@suse.com> Acked-by: Paul Burton <paul.burton@mips.com> [MIPS] Acked-by: Michael Ellerman <mpe@ellerman.id.au> [powerpc] Acked-by: Michal Hocko <mhocko@suse.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Chris Zankel <chris@zankel.net> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Guan Xuetao <gxt@pku.edu.cn> Cc: Ingo Molnar <mingo@redhat.com> Cc: Matt Turner <mattst88@gmail.com> Cc: Michal Simek <monstr@monstr.eu> Cc: Richard Weinberger <richard@nod.at> Cc: Russell King <linux@armlinux.org.uk> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Tony Luck <tony.luck@intel.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> :040000 040000 9fdad987cc69ffad8de2d0d621facc66b096aac1 c9959a9199e01f282d1d291a6280b203a8561e7a M arch :040000 040000 de303e4a0ad2b500de3fca2f65c8943c12c0b077 1581aed934cfb96b2706df9bfa7746edfadffea6 M drivers :040000 040000 f9179d8189f08e3575031a76181a64eedd148db5 293bc953dcfc2b718f5c7cdd58722284f4393dec M include :040000 040000 3019b5f917a20420537ac5cf4dc90b3c7f1aa56f 1b88f0791341d17abd259d7a8d2e0cc55147d8f6 M init :040000 040000 8819d52ce4e6463fc95a2e841baeeddbc9fb8c52 dc167f38bd8c4a80e0ac84ecc981e95b98703393 M kernel :040000 040000 30c64583e66fc20181d7ce2b6ced9d7e060e1042 4e57b31864cef4e921bbd73150f63637a819e3c4 M lib :040000 040000 1b341ab0dd034f0fef37c234a771419924e0ecc9 9c489ba60978950733bf678191833fdb9689bdab M mm # bad: [ca0591d03a2d373e0019ad357fbbee69c8272381] Add linux-next specific files for 20181015 # good: [3a27203102ebfa67bd0bced05b1def499bb59db2] Merge tag 'libnvdimm-fixes-4.19-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm git bisect start 'HEAD' 'remotes/origin/stable' # good: [5a09f4fbf98e45de8341bc8176e62afaac8405f6] Merge remote-tracking branch 'crypto/master' git bisect good 5a09f4fbf98e45de8341bc8176e62afaac8405f6 # good: [a54eefdf4d208f6904da9e836ff32d7dde0c9516] Merge remote-tracking branch 'tip/auto-latest' git bisect good a54eefdf4d208f6904da9e836ff32d7dde0c9516 # good: [d71e0d25be750d02a3d04500aeb151bb94465811] Merge remote-tracking branch 'staging/staging-next' git bisect good d71e0d25be750d02a3d04500aeb151bb94465811 # good: [7961c8ea9d81f927a78e30bb7c194310ed6b7c1d] Merge remote-tracking branch 'pinctrl/for-next' git bisect good 7961c8ea9d81f927a78e30bb7c194310ed6b7c1d # good: [c3d392e6aae57d54fdc683f7432c3e248602bebb] Merge remote-tracking branch 'xarray/xarray' git bisect good c3d392e6aae57d54fdc683f7432c3e248602bebb # good: [880c1034475c873963d6250eb95ebbbf5604a281] userfaultfd: selftest: cleanup help messages git bisect good 880c1034475c873963d6250eb95ebbbf5604a281 # good: [9f1fa0ab60f7b09d335bbaf33db9116241059708] reiserfs: propagate errors from fill_with_dentries() properly git bisect good 9f1fa0ab60f7b09d335bbaf33db9116241059708 # good: [596046ffd571f32fa3d3e7ffdf7861b71a258552] memblock: replace alloc_bootmem_low with memblock_alloc_low (2) git bisect good 596046ffd571f32fa3d3e7ffdf7861b71a258552 # good: [979961b3058df1a6d24ab423dd6fa6f20982f591] memblock: replace BOOTMEM_ALLOC_* with MEMBLOCK variants git bisect good 979961b3058df1a6d24ab423dd6fa6f20982f591 # bad: [8fab7180e6cd3126f7be81e8e33c8152b99f046b] mm/memory_hotplug: make add_memory() take the device_hotplug_lock git bisect bad 8fab7180e6cd3126f7be81e8e33c8152b99f046b # bad: [fe3d2a45e8079fdd7d4da1ff07f4b40bc3cb499f] memblock: stop using implicit alignment to SMP_CACHE_BYTES git bisect bad fe3d2a45e8079fdd7d4da1ff07f4b40bc3cb499f # good: [2b130e2ae5fdc482305c6d23b05a532addda7c40] powerpc: fix up for removal of linux/bootmem.h git bisect good 2b130e2ae5fdc482305c6d23b05a532addda7c40 # good: [699f0940861c958f2397c727d80fe324b6d88b06] docs/boot-time-mm: remove bootmem documentation git bisect good 699f0940861c958f2397c727d80fe324b6d88b06 # first bad commit: [fe3d2a45e8079fdd7d4da1ff07f4b40bc3cb499f] memblock: stop using implicit alignment to SMP_CACHE_BYTES Reverting fe3d2a45e8079fdd7d4da1ff07f4b40bc3cb499f (and the following 2 commits) produces a kernel that boots. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-16 2:02 ` Stephen Rothwell @ 2018-10-16 2:19 ` Stephen Rothwell 2018-10-16 3:12 ` Benjamin Herrenschmidt 0 siblings, 1 reply; 21+ messages in thread From: Stephen Rothwell @ 2018-10-16 2:19 UTC (permalink / raw) To: Guenter Roeck Cc: Linux Kernel Mailing List, Mike Rapoport, Linux-Next Mailing List, Andrew Morton, PowerPC [-- Attachment #1: Type: text/plain, Size: 1727 bytes --] Hi all, On Tue, 16 Oct 2018 13:02:16 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > Reverting fe3d2a45e8079fdd7d4da1ff07f4b40bc3cb499f (and the following 2 > commits) produces a kernel that boots. Instead of that, I applied this patch on top of linux-next and it boots and produces a stack trace ... From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Tue, 16 Oct 2018 13:07:01 +1100 Subject: [PATCH] mm/memblock.c: use dump_stack() instead of WARN_ON_ONCE for the alignment checks Using WARN_ON_ONCE too early causes the PowerPC kernel to fail. Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- mm/memblock.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/memblock.c b/mm/memblock.c index 5fefc70253ee..f2ef3915a356 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1298,8 +1298,10 @@ static phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, { phys_addr_t found; - if (WARN_ON_ONCE(!align)) + if (!align) { + dump_stack(); align = SMP_CACHE_BYTES; + } found = memblock_find_in_range_node(size, align, start, end, nid, flags); @@ -1423,8 +1425,10 @@ static void * __init memblock_alloc_internal( if (WARN_ON_ONCE(slab_is_available())) return kzalloc_node(size, GFP_NOWAIT, nid); - if (WARN_ON_ONCE(!align)) + if (!align) { + dump_stack(); align = SMP_CACHE_BYTES; + } if (max_addr > memblock.current_limit) max_addr = memblock.current_limit; -- 2.18.0 So, patch "memblock: stop using implicit alignment to SMP_CACHE_BYTES" should *not* remove the 0 -> SMP_CACHE_BYTES update from mm/memblock.c and just add the dump_stack(). -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: linux-next: Tree for Oct 15 2018-10-16 2:19 ` Stephen Rothwell @ 2018-10-16 3:12 ` Benjamin Herrenschmidt 0 siblings, 0 replies; 21+ messages in thread From: Benjamin Herrenschmidt @ 2018-10-16 3:12 UTC (permalink / raw) To: Stephen Rothwell, Guenter Roeck Cc: Linux Kernel Mailing List, Mike Rapoport, Linux-Next Mailing List, Andrew Morton, PowerPC On Tue, 2018-10-16 at 13:19 +1100, Stephen Rothwell wrote: > Hi all, > > On Tue, 16 Oct 2018 13:02:16 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > Reverting fe3d2a45e8079fdd7d4da1ff07f4b40bc3cb499f (and the following 2 > > commits) produces a kernel that boots. > > Instead of that, I applied this patch on top of linux-next and it boots > and produces a stack trace ... > > From: Stephen Rothwell <sfr@canb.auug.org.au> > Date: Tue, 16 Oct 2018 13:07:01 +1100 > Subject: [PATCH] mm/memblock.c: use dump_stack() instead of WARN_ON_ONCE for > the alignment checks > > Using WARN_ON_ONCE too early causes the PowerPC kernel to fail. Interesting ... I thought I had fixed that. Might need to be re-fixed. > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> > --- > mm/memblock.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 5fefc70253ee..f2ef3915a356 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1298,8 +1298,10 @@ static phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > { > phys_addr_t found; > > - if (WARN_ON_ONCE(!align)) > + if (!align) { > + dump_stack(); > align = SMP_CACHE_BYTES; > + } > > found = memblock_find_in_range_node(size, align, start, end, nid, > flags); > @@ -1423,8 +1425,10 @@ static void * __init memblock_alloc_internal( > if (WARN_ON_ONCE(slab_is_available())) > return kzalloc_node(size, GFP_NOWAIT, nid); > > - if (WARN_ON_ONCE(!align)) > + if (!align) { > + dump_stack(); > align = SMP_CACHE_BYTES; > + } > > if (max_addr > memblock.current_limit) > max_addr = memblock.current_limit; > -- > 2.18.0 > > So, patch "memblock: stop using implicit alignment to SMP_CACHE_BYTES" > should *not* remove the 0 -> SMP_CACHE_BYTES update from mm/memblock.c > and just add the dump_stack(). ^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2018-10-16 20:44 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20181015192546.15faf3a1@canb.auug.org.au>
[not found] ` <20181015182637.GA16445@roeck-us.net>
2018-10-15 20:12 ` linux-next: Tree for Oct 15 Stephen Rothwell
2018-10-15 20:24 ` Stephen Rothwell
2018-10-15 22:13 ` Andrew Morton
2018-10-16 13:36 ` Mike Rapoport
2018-10-16 20:41 ` Stephen Rothwell
2018-10-15 20:35 ` Rob Herring
2018-10-15 21:18 ` Guenter Roeck
2018-10-15 21:48 ` Rob Herring
2018-10-15 22:10 ` Guenter Roeck
2018-10-15 22:13 ` Rob Herring
2018-10-15 22:28 ` Guenter Roeck
2018-10-15 22:34 ` Guenter Roeck
2018-10-15 22:52 ` Rob Herring
2018-10-16 1:00 ` Rob Herring
2018-10-16 1:34 ` David Miller
[not found] ` <20181015193914.GA9881@roeck-us.net>
2018-10-15 20:33 ` Stephen Rothwell
2018-10-15 21:35 ` Guenter Roeck
2018-10-15 22:22 ` Guenter Roeck
2018-10-16 2:02 ` Stephen Rothwell
2018-10-16 2:19 ` Stephen Rothwell
2018-10-16 3:12 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).