From: Christian Lamparter <chunkeey@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Paul Mackerras <paulus@samba.org>,
Markus Elfring <elfring@users.sourceforge.net>
Subject: [PATCH] ppc4xx: ocm: fix errnous "failed to create file" errors
Date: Sun, 28 Oct 2018 17:17:02 +0100 [thread overview]
Message-ID: <20181028161702.9300-1-chunkeey@gmail.com> (raw)
Previously, the kernel would complain:
| debugfs ppc4xx ocm: failed to create file
But the "info" file was still created and working. This
is because debugfs_create_file() returns a pointer to a
struct *dentry on success or -ENODEV when debugfs isn't
available. This patch fixes both the debugfs_create_dir()
and debugfs_create_file() check, so this will work as
expected.
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
---
arch/powerpc/platforms/4xx/ocm.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/4xx/ocm.c b/arch/powerpc/platforms/4xx/ocm.c
index 69d9f60d9fe5..e616c8636303 100644
--- a/arch/powerpc/platforms/4xx/ocm.c
+++ b/arch/powerpc/platforms/4xx/ocm.c
@@ -293,13 +293,14 @@ static int ocm_debugfs_init(void)
{
struct dentry *junk;
- junk = debugfs_create_dir("ppc4xx_ocm", 0);
- if (!junk) {
+ junk = debugfs_create_dir("ppc4xx_ocm", NULL);
+ if (IS_ERR_OR_NULL(junk)) {
printk(KERN_ALERT "debugfs ppc4xx ocm: failed to create dir\n");
return -1;
}
- if (debugfs_create_file("info", 0644, junk, NULL, &ocm_debugfs_fops)) {
+ if (IS_ERR_OR_NULL(debugfs_create_file("info", 0644, junk, NULL,
+ &ocm_debugfs_fops))) {
printk(KERN_ALERT "debugfs ppc4xx ocm: failed to create file\n");
return -1;
}
--
2.19.1
next reply other threads:[~2018-10-28 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-28 16:17 Christian Lamparter [this message]
2018-11-01 11:45 ` [PATCH] ppc4xx: ocm: fix errnous "failed to create file" errors Michael Ellerman
2018-11-04 15:57 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181028161702.9300-1-chunkeey@gmail.com \
--to=chunkeey@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).