From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: alex_gagniuc@dellteam.com, Sam Bobroff <sbobroff@linux.ibm.com>,
linux-pci@vger.kernel.org, shyam_iyer@dell.com,
linux-kernel@vger.kernel.org, Lukas Wunner <lukas@wunner.de>,
Alexandru Gagniuc <mr.nuke.me@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Oliver O'Halloran <oohall@gmail.com>,
austin_bolen@dell.com, linuxppc-dev@lists.ozlabs.org,
Jonathan Derrick <jonathan.derrick@intel.com>
Subject: Re: [PATCH v2] PCI/MSI: Don't touch MSI bits when the PCI device is disconnected
Date: Thu, 8 Nov 2018 14:49:00 -0700 [thread overview]
Message-ID: <20181108214900.GB2932@localhost.localdomain> (raw)
In-Reply-To: <20181108200855.GE41183@google.com>
On Thu, Nov 08, 2018 at 02:09:17PM -0600, Bjorn Helgaas wrote:
>
> I'm having second thoughts about this. One thing I'm uncomfortable
> with is that sprinkling pci_dev_is_disconnected() around feels ad hoc
> instead of systematic, in the sense that I don't know how we convince
> ourselves that this (and only this) is the correct place to put it.
You know how the kernel provides ZERO_PAGE, wouldn't it be cool if we
also had a ONES_PAGE and could remap all virtual addresses from a memory
mapped device to that page on an ungraceful disconnect? I do not know
how to accomplish that, so might just be crazy talk... But if it is
possible, that would be a pretty nifty way to solve this problem.
next prev parent reply other threads:[~2018-11-08 21:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180918221501.13112-1-mr.nuke.me@gmail.com>
[not found] ` <20181107234257.GC41183@google.com>
2018-11-08 20:09 ` [PATCH v2] PCI/MSI: Don't touch MSI bits when the PCI device is disconnected Bjorn Helgaas
2018-11-08 21:49 ` Keith Busch [this message]
2018-11-08 22:01 ` Greg Kroah-Hartman
2018-11-08 22:32 ` Keith Busch
2018-11-08 22:42 ` Greg Kroah-Hartman
2018-11-08 22:49 ` Alex_Gagniuc
2018-11-08 22:51 ` Greg KH
2018-11-08 23:06 ` Alex_Gagniuc
2018-11-12 5:49 ` Oliver O'Halloran
2018-11-12 20:05 ` Alex_Gagniuc
2018-11-13 5:02 ` Bjorn Helgaas
2018-11-13 22:39 ` Alex_Gagniuc
2018-11-13 22:52 ` Keith Busch
2018-11-14 0:31 ` Alex_Gagniuc
2018-11-14 5:59 ` Bjorn Helgaas
2018-11-14 19:22 ` Alex_Gagniuc
2018-11-14 19:41 ` Derrick, Jonathan
2018-11-14 20:23 ` Keith Busch
2018-11-14 20:52 ` Alex_Gagniuc
2018-11-14 20:58 ` Keith Busch
2018-11-15 6:24 ` Bjorn Helgaas
2018-11-16 0:19 ` Alex_Gagniuc
2018-11-08 23:03 ` Keith Busch
[not found] ` <20181109072953.ox7qfpnibb7drmf6@wunner.de>
2018-11-09 11:32 ` Greg Kroah-Hartman
2018-11-09 16:36 ` Keith Busch
2018-11-08 22:20 ` Alex_Gagniuc
[not found] ` <20181109071139.uxa6gu7jwsvr7ve6@wunner.de>
2018-11-12 5:48 ` Oliver O'Halloran
2018-12-27 19:28 ` Alex_Gagniuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108214900.GB2932@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas@wunner.de \
--cc=mr.nuke.me@gmail.com \
--cc=oohall@gmail.com \
--cc=sbobroff@linux.ibm.com \
--cc=shyam_iyer@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).