From: Wei Yang <richard.weiyang@gmail.com>
To: David Hildenbrand <david@redhat.com>
Cc: Oscar Salvador <osalvador@suse.com>,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Wei Yang <richard.weiyang@gmail.com>,
linux-mm@kvack.org, Ingo Molnar <mingo@kernel.org>,
linux-s390@vger.kernel.org, x86@kernel.org,
Pavel Tatashin <pasha.tatashin@oracle.com>,
linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org,
Michal Such??nek <msuchanek@suse.de>,
Pavel Tatashin <pavel.tatashin@microsoft.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"mike.travis@hpe.com" <mike.travis@hpe.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Dan Williams <dan.j.williams@intel.com>,
Michal Hocko <mhocko@kernel.org>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Andrew Banman <andrew.banman@hpe.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
devel@linuxdriverproject.org,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH RFCv2 1/4] mm/memory_hotplug: Introduce memory block types
Date: Mon, 3 Dec 2018 20:58:36 +0000 [thread overview]
Message-ID: <20181203205836.7xpab6ljc3kngrqm@master> (raw)
In-Reply-To: <af797dbb-0537-19ec-ef31-d72a3f979791@redhat.com>
[...]
>>>
>>> + if (type == MEMORY_BLOCK_NONE)
>>> + return -EINVAL;
>>
>> No one will pass in this value. Can we omit this check for now?
>
>I could move it to patch nr 2 I guess, but as I introduce
>MEMORY_BLOCK_NONE here it made sense to keep it in here.
>
Yes, this make sense to me now.
>(and I think at least for now it makes sense to not squash patch 1 and
>2, to easier discuss the new user interface/concept introduced in this
>patch).
>
>Thanks!
>
>--
>
>Thanks,
>
>David / dhildenb
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2018-12-03 21:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 17:59 [PATCH RFCv2 0/4] mm/memory_hotplug: Introduce memory block types David Hildenbrand
2018-11-30 17:59 ` [PATCH RFCv2 1/4] " David Hildenbrand
2018-12-01 1:25 ` Wei Yang
2018-12-03 10:32 ` David Hildenbrand
2018-12-03 20:58 ` Wei Yang [this message]
2018-11-30 17:59 ` [PATCH RFCv2 2/4] mm/memory_hotplug: Replace "bool want_memblock" by "int type" David Hildenbrand
2018-12-01 1:50 ` Wei Yang
2018-12-03 10:33 ` David Hildenbrand
2018-11-30 17:59 ` [PATCH RFCv2 3/4] mm/memory_hotplug: Introduce and use more memory types David Hildenbrand
2018-12-04 9:44 ` Michal Suchánek
2018-12-04 9:47 ` David Hildenbrand
2018-11-30 17:59 ` [PATCH RFCv2 4/4] mm/memory_hotplug: Drop MEMORY_TYPE_UNSPECIFIED David Hildenbrand
2018-12-01 0:48 ` [PATCH RFCv2 0/4] mm/memory_hotplug: Introduce memory block types Wei Yang
2018-12-20 12:58 ` David Hildenbrand
2018-12-20 13:08 ` Michal Hocko
2018-12-20 13:16 ` David Hildenbrand
2019-03-27 16:03 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203205836.7xpab6ljc3kngrqm@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.banman@hpe.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@kernel.org \
--cc=mike.travis@hpe.com \
--cc=mingo@kernel.org \
--cc=msuchanek@suse.de \
--cc=osalvador@suse.com \
--cc=pasha.tatashin@oracle.com \
--cc=pavel.tatashin@microsoft.com \
--cc=rafael@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).