From: Paul Mackerras <paulus@ozlabs.org>
To: lantianyu1986@gmail.com
Cc: linux-mips@linux-mips.org, kvm@vger.kernel.org,
rkrcmar@redhat.com, catalin.marinas@arm.com, will.deacon@arm.com,
christoffer.dall@arm.com, hpa@zytor.com, kys@microsoft.com,
kvmarm@lists.cs.columbia.edu, x86@kernel.org,
linux@armlinux.org.uk, michael.h.kelley@microsoft.com,
mingo@redhat.com, jhogan@kernel.org,
Lan Tianyu <Tianyu.Lan@microsoft.com>,
marc.zyngier@arm.com, kvm-ppc@vger.kernel.org, bp@alien8.de,
tglx@linutronix.de, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, ralf@linux-mips.org,
paul.burton@mips.com, pbonzini@redhat.com, vkuznets@redhat.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [Resend PATCH V5 7/10] KVM: Make kvm_set_spte_hva() return int
Date: Wed, 12 Dec 2018 16:03:53 +1100 [thread overview]
Message-ID: <20181212050353.GF22265@blackberry> (raw)
In-Reply-To: <20181206132113.2691-8-Tianyu.Lan@microsoft.com>
On Thu, Dec 06, 2018 at 09:21:10PM +0800, lantianyu1986@gmail.com wrote:
> From: Lan Tianyu <Tianyu.Lan@microsoft.com>
>
> The patch is to make kvm_set_spte_hva() return int and caller can
> check return value to determine flush tlb or not.
It would be helpful if the patch description told the reader which
return value(s) mean that the caller should flush the tlb. I would
guess that non-zero means to do the flush, but you should make that
explicit.
> Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
For the powerpc bits:
Acked-by: Paul Mackerras <paulus@ozlabs.org>
next prev parent reply other threads:[~2018-12-12 5:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 13:21 [Resend PATCH V5 0/10] x86/KVM/Hyper-v: Add HV ept tlb range flush hypercall support in KVM lantianyu1986
2018-12-06 13:21 ` [Resend PATCH V5 1/10] KVM: Add tlb_remote_flush_with_range callback in kvm_x86_ops lantianyu1986
2018-12-06 13:21 ` [Resend PATCH V5 2/10] x86/hyper-v: Add HvFlushGuestAddressList hypercall support lantianyu1986
2018-12-21 9:32 ` Paolo Bonzini
2018-12-06 13:21 ` [Resend PATCH V5 3/10] x86/Hyper-v: Add trace in the hyperv_nested_flush_guest_mapping_range() lantianyu1986
2018-12-06 13:21 ` [Resend PATCH V5 4/10] KVM/VMX: Add hv tlb range flush support lantianyu1986
2018-12-06 13:21 ` [Resend PATCH V5 5/10] KVM/MMU: Add tlb flush with range helper function lantianyu1986
2018-12-06 13:21 ` [Resend PATCH V5 6/10] KVM: Replace old tlb flush function with new one to flush a specified range lantianyu1986
2018-12-06 13:21 ` [Resend PATCH V5 7/10] KVM: Make kvm_set_spte_hva() return int lantianyu1986
2018-12-12 5:03 ` Paul Mackerras [this message]
2018-12-13 7:47 ` Tianyu Lan
2018-12-21 9:31 ` [Resend PATCH V5 0/10] x86/KVM/Hyper-v: Add HV ept tlb range flush hypercall support in KVM Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2018-11-08 14:46 [Resend PATCH V5 1/10] KVM: Add tlb_remote_flush_with_range callback in kvm_x86_ops lantianyu1986
2018-11-08 14:46 ` [Resend PATCH V5 7/10] KVM: Make kvm_set_spte_hva() return int lantianyu1986
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212050353.GF22265@blackberry \
--to=paulus@ozlabs.org \
--cc=Tianyu.Lan@microsoft.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=hpa@zytor.com \
--cc=jhogan@kernel.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=kys@microsoft.com \
--cc=lantianyu1986@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marc.zyngier@arm.com \
--cc=michael.h.kelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=paul.burton@mips.com \
--cc=pbonzini@redhat.com \
--cc=ralf@linux-mips.org \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).