From: David Miller <davem@davemloft.net>
To: wen.yang99@zte.com.cn
Cc: cheng.shengyu@zte.com.cn, linux-kernel@vger.kernel.org,
tlfalcon@linux.ibm.com, paulus@samba.org, jallen@linux.ibm.com,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] net/ibmvnic: Remove tests of member address
Date: Fri, 14 Dec 2018 13:36:57 -0800 (PST) [thread overview]
Message-ID: <20181214.133657.253891930157421703.davem@davemloft.net> (raw)
In-Reply-To: <20181211042046.64810-1-wen.yang99@zte.com.cn>
From: Wen Yang <wen.yang99@zte.com.cn>
Date: Tue, 11 Dec 2018 12:20:46 +0800
> The driver was checking for non-NULL address.
> - adapter->napi[i]
>
> This is pointless as these will be always non-NULL, since the
> 'dapter->napi' is allocated in init_napi().
> It is safe to get rid of useless checks for addresses to fix the
> coccinelle warning:
>>>drivers/net/ethernet/ibm/ibmvnic.c: test of a variable/field address
> Since such statements always return true, they are redundant.
>
> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Applied.
prev parent reply other threads:[~2018-12-14 21:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 4:20 [PATCH] net/ibmvnic: Remove tests of member address Wen Yang
2018-12-14 21:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214.133657.253891930157421703.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cheng.shengyu@zte.com.cn \
--cc=jallen@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=tlfalcon@linux.ibm.com \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).