linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-vger@kernel.org
Cc: Nishanth Menon <nm@ti.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vignesh R <vigneshr@ti.com>,
	arnd@arndb.de, gregkh@linuxfoundation.org,
	Tony Lindgren <tony@atomide.com>, Jiri Slaby <jslaby@suse.com>,
	open list <linux-kernel@vger.kernel.org>,
	Lokesh Vutla <lokeshvutla@ti.com>,
	paulus@samba.org, linux-serial@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux@roeck-us.net,
	Michael Moese <mmoese@suse.de>
Subject: [PATCH] Revert "serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250"
Date: Thu, 20 Dec 2018 20:27:16 -0800	[thread overview]
Message-ID: <20181221042719.29954-1-f.fainelli@gmail.com> (raw)
In-Reply-To: <20181220173844.GA5838@roeck-us.net>

This reverts commit 6d11023c345e369bcb9d5a68b271764e362c1f6e ("serial:
8250: Default SERIAL_OF_PLATFORM to SERIAL_8250") since that breaks at
least mpc8544ds (PowerPC) using arch/powerpc/kernel/legacy_serial.c.

See https://lkml.org/lkml/2018/12/5/1491 for discussion and analysis

Fixes: 6d11023c345e ("serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/tty/serial/8250/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index d7737dca0e48..15c2c5463835 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -484,7 +484,6 @@ config SERIAL_8250_PXA
 config SERIAL_OF_PLATFORM
 	tristate "Devicetree based probing for 8250 ports"
 	depends on SERIAL_8250 && OF
-	default SERIAL_8250
 	help
 	  This option is used for all 8250 compatible serial ports that
 	  are probed through devicetree, including Open Firmware based
-- 
2.19.1


  parent reply	other threads:[~2018-12-21  4:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181115011125.GA32556@roeck-us.net>
     [not found] ` <29E7A6C0-7829-4650-93C6-7220FECAA6EF@gmail.com>
     [not found]   ` <20181115053836.GA7606@roeck-us.net>
     [not found]     ` <27ed27d3-220e-963f-7d2c-64df10421580@gmail.com>
     [not found]       ` <20181115172535.GA26922@roeck-us.net>
     [not found]         ` <5937b814-ca5f-5786-93a1-3334df8c92dc@gmail.com>
     [not found]           ` <20181116011656.GA21813@roeck-us.net>
     [not found]             ` <ffff966c-d6ae-1487-5269-b86df0824d1c@gmail.com>
     [not found]               ` <20181119205050.GA1933@roeck-us.net>
     [not found]                 ` <20181123182023.GA10080@roeck-us.net>
2018-11-27  0:08                   ` [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250 Florian Fainelli
2018-12-05  5:47                     ` Michael Ellerman
2018-12-05 22:40                       ` Florian Fainelli
     [not found] ` <20181220152111.GB17408@kroah.com>
     [not found]   ` <20181220173844.GA5838@roeck-us.net>
2018-12-21  4:27     ` Florian Fainelli [this message]
2018-12-21  4:28     ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181221042719.29954-1-f.fainelli@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-vger@kernel.org \
    --cc=linux@roeck-us.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lokeshvutla@ti.com \
    --cc=mmoese@suse.de \
    --cc=nm@ti.com \
    --cc=paulus@samba.org \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).