From: Catalin Marinas <catalin.marinas@arm.com>
To: David Hildenbrand <david@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Michal Hocko <mhocko@suse.com>,
CHANDAN VN <chandan.vn@samsung.com>,
Bhupesh Sharma <bhsharma@redhat.com>,
Will Deacon <will.deacon@arm.com>, Stefan Agner <stefan@agner.ch>,
linux-mm@kvack.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Laura Abbott <labbott@redhat.com>,
Kristina Martsenko <kristina.martsenko@arm.com>,
linux-m68k@lists.linux-m68k.org,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Logan Gunthorpe <logang@deltatee.com>,
linux-kernel@vger.kernel.org,
Dave Kleikamp <dave.kleikamp@oracle.com>,
James Morse <james.morse@arm.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
Greg Hackmann <ghackmann@android.com>
Subject: Re: [PATCH v2 7/9] arm64: kdump: No need to mark crashkernel pages manually PG_reserved
Date: Fri, 25 Jan 2019 16:28:31 +0000 [thread overview]
Message-ID: <20190125162830.GK25901@arrakis.emea.arm.com> (raw)
In-Reply-To: <20190114125903.24845-8-david@redhat.com>
On Mon, Jan 14, 2019 at 01:59:01PM +0100, David Hildenbrand wrote:
> The crashkernel is reserved via memblock_reserve(). memblock_free_all()
> will call free_low_memory_core_early(), which will go over all reserved
> memblocks, marking the pages as PG_reserved.
>
> So manually marking pages as PG_reserved is not necessary, they are
> already in the desired state (otherwise they would have been handed over
> to the buddy as free pages and bad things would happen).
>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: James Morse <james.morse@arm.com>
> Cc: Bhupesh Sharma <bhsharma@redhat.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Dave Kleikamp <dave.kleikamp@oracle.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Stefan Agner <stefan@agner.ch>
> Cc: Laura Abbott <labbott@redhat.com>
> Cc: Greg Hackmann <ghackmann@android.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Kristina Martsenko <kristina.martsenko@arm.com>
> Cc: CHANDAN VN <chandan.vn@samsung.com>
> Cc: AKASHI Takahiro <takahiro.akashi@linaro.org>
> Cc: Logan Gunthorpe <logang@deltatee.com>
> Reviewed-by: Matthias Brugger <mbrugger@suse.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2019-01-25 16:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 12:58 [PATCH v2 0/9] mm: PG_reserved cleanups and documentation David Hildenbrand
2019-01-14 12:58 ` [PATCH v2 1/9] agp: efficeon: no need to set PG_reserved on GATT tables David Hildenbrand
2019-01-14 12:58 ` [PATCH v2 2/9] s390/vdso: don't clear PG_reserved David Hildenbrand
2019-01-14 12:58 ` [PATCH v2 3/9] powerpc/vdso: " David Hildenbrand
2019-01-14 12:58 ` [PATCH v2 4/9] riscv/vdso: " David Hildenbrand
2019-01-15 15:36 ` Christoph Hellwig
2019-01-14 12:58 ` [PATCH v2 5/9] m68k/mm: use __ClearPageReserved() David Hildenbrand
2019-01-14 14:02 ` Geert Uytterhoeven
2019-01-14 12:59 ` [PATCH v2 6/9] arm64: kexec: no need to ClearPageReserved() David Hildenbrand
2019-01-14 15:50 ` Bhupesh Sharma
2019-01-25 16:25 ` Catalin Marinas
2019-01-14 12:59 ` [PATCH v2 7/9] arm64: kdump: No need to mark crashkernel pages manually PG_reserved David Hildenbrand
2019-01-14 15:52 ` Bhupesh Sharma
2019-01-25 16:28 ` Catalin Marinas [this message]
2019-01-14 12:59 ` [PATCH v2 8/9] ia64: perfmon: Don't mark buffer pages as PG_reserved David Hildenbrand
2019-01-14 12:59 ` [PATCH v2 9/9] mm: better document PG_reserved David Hildenbrand
2019-01-15 15:38 ` [PATCH v2 0/9] mm: PG_reserved cleanups and documentation Christoph Hellwig
2019-01-15 15:53 ` David Hildenbrand
2019-01-21 11:36 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125162830.GK25901@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=bhsharma@redhat.com \
--cc=chandan.vn@samsung.com \
--cc=dave.kleikamp@oracle.com \
--cc=david@redhat.com \
--cc=f.fainelli@gmail.com \
--cc=ghackmann@android.com \
--cc=hannes@cmpxchg.org \
--cc=james.morse@arm.com \
--cc=kristina.martsenko@arm.com \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=logang@deltatee.com \
--cc=mark.rutland@arm.com \
--cc=mhocko@suse.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=stefan@agner.ch \
--cc=takahiro.akashi@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).