linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Viorel Suman <viorel.suman@nxp.com>, Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"S.j. Wang" <shengjiu.wang@nxp.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Viorel Suman <viorel.suman@gmail.com>,
	Cosmin Samoila <cosmin.samoila@nxp.com>,
	Mark Brown <broonie@kernel.org>, dl-linux-imx <linux-imx@nxp.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Daniel Baluta <daniel.baluta@nxp.com>
Subject: Re: [PATCH v3 2/4] ASoC: add fsl_audmix DT binding documentation
Date: Fri, 25 Jan 2019 17:49:19 -0800	[thread overview]
Message-ID: <20190126014918.GA2617@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <1547729177-14317-3-git-send-email-viorel.suman@nxp.com>

On Thu, Jan 17, 2019 at 12:46:29PM +0000, Viorel Suman wrote:

> +  - dais		: Must contain a list of phandles to AUDMIX connected
> +			  DAIs. The current implementation requires two phandles
> +			  to SAI interfaces to be provided, the first SAI in the
> +			  list being used to route the AUDMIX output.

Another small thing, that I just noticed, is this list. It forces
the first input source to be the output source without giving any
chance. I feel that we could have some flexibility here: one node
for two input sources, and one node for the output source.

Well, there is no critical problem with the current binding since
it follows the SoC design. Yet I doubt if this routing logic will
never break.

Any suggestion, Rob?

  reply	other threads:[~2019-01-26  1:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17 12:46 [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers Viorel Suman
2019-01-17 12:46 ` [PATCH v3 1/4] ASoC: fsl: Add Audio Mixer CPU DAI driver Viorel Suman
2019-01-17 12:46 ` [PATCH v3 2/4] ASoC: add fsl_audmix DT binding documentation Viorel Suman
2019-01-26  1:49   ` Nicolin Chen [this message]
2019-01-17 12:46 ` [PATCH v3 3/4] ASoC: fsl: Add Audio Mixer machine driver Viorel Suman
2019-01-17 12:46 ` [PATCH v3 4/4] ASoC: add imx-audmix DT binding documentation Viorel Suman
2019-01-17 16:18 ` [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers Rob Herring
2019-01-18 13:16   ` Viorel Suman
2019-01-18 19:46     ` Nicolin Chen
2019-01-21 15:23       ` Rob Herring
2019-01-22 11:39         ` Viorel Suman
2019-01-22 11:19       ` Viorel Suman
2019-01-17 22:22 ` Nicolin Chen
2019-01-17 22:24   ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190126014918.GA2617@Asurada-Nvidia.nvidia.com \
    --to=nicoleotsuka@gmail.com \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cosmin.samoila@nxp.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=shengjiu.wang@nxp.com \
    --cc=timur@kernel.org \
    --cc=tiwai@suse.com \
    --cc=viorel.suman@gmail.com \
    --cc=viorel.suman@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).