From: Christoph Hellwig <hch@lst.de>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>,
Alexander Fomichev <fomichev.ru@gmail.com>,
linux@yadro.com
Subject: Re: [RFC PATCH] powerpc: fix get_arch_dma_ops() for NTB devices
Date: Mon, 4 Feb 2019 09:17:52 +0100 [thread overview]
Message-ID: <20190204081752.GA5730@lst.de> (raw)
In-Reply-To: <87imy6pain.fsf@concordia.ellerman.id.au>
On Wed, Jan 30, 2019 at 11:58:40PM +1100, Michael Ellerman wrote:
> Alexander Fomichev <fomichev.ru@gmail.com> writes:
>
> > get_dma_ops() falls into arch-dependant get_arch_dma_ops(), which
> > historically returns NULL on PowerPC. Therefore dma_set_mask() fails.
> > This affects Switchtec (and probably other) NTB devices, that they fail
> > to initialize.
>
> What's an NTB device?
>
> drivers/ntb I assume?
>
> So it's a PCI device of some sort, but presumably the device you're
> calling dma_set_mask() on is an NTB device not a PCI device?
>
> But then it works if you tell it to use the PCI DMA ops?
>
> At the very least the code should be checking for the NTB bus type and
> only returning the PCI ops in that specific case, not for all devices.
Can you provide the context? E.g. the patch and the rest of the commit
log. This all looks rather odd to me.
next prev parent reply other threads:[~2019-02-04 8:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 13:32 [RFC PATCH] powerpc: fix get_arch_dma_ops() for NTB devices Alexander Fomichev
2019-01-30 12:58 ` Michael Ellerman
2019-02-04 8:17 ` Christoph Hellwig [this message]
2019-02-05 11:20 ` Michael Ellerman
2019-02-05 16:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204081752.GA5730@lst.de \
--to=hch@lst.de \
--cc=fomichev.ru@gmail.com \
--cc=linux@yadro.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).