From: Jonathan Corbet <corbet@lwn.net>
To: "Tobin C. Harding" <tobin@kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 0/1] Start conversion of PowerPC docs
Date: Thu, 7 Feb 2019 17:01:31 -0700 [thread overview]
Message-ID: <20190207170131.1fd2bb03@lwn.net> (raw)
In-Reply-To: <20190207060316.3221-1-tobin@kernel.org>
On Thu, 7 Feb 2019 17:03:15 +1100
"Tobin C. Harding" <tobin@kernel.org> wrote:
> As discussed at LCA here is the start to the docs conversion for PowerPC
> to RST.
>
> This applies cleanly on top of the mainline (5.20-rc5) and Jon's tree
> (docs-next branch).
>
> I'm guessing it should go in through the PowerPC tree because I doubt
> you want to review this Jon, it's one big single patch (all blame for
> that falls on mpe ;)
Well, I went and took a look anyway, being a glutton for punishment. So
naturally I do have some comments...
- I don't think this should be a top-level directory full of docs; the top
level is already rather overpopulated. At worst, we should create an
arch/ directory for architecture-specific docs. I kind of think that
this should be thought through a bit more, though, with an eye toward
who the audience is. Some of it is clearly developer documentation, and
some of it is aimed at admins; ptrace.rst is user-space API stuff.
Nobody ever welcomes me saying this, but we should really split things
into the appropriate manuals according to audience.
- It would be good to know how much of this stuff is still relevant.
bootwrapper.txt hasn't been modified since it was added in 2008.
cpu_features.txt predates the git era, as does mpc52xx.txt; hvcs.txt is
nearly as old. And so on. Can we perhaps stop dragging some of those
docs around?
- The use of flat-table in isa-versions.rst totally wrecks the readability
of those tables in the plain-text version. Said tables are pretty close
to being RST in their original form; it would be far better to just fix
anything needing fixing but to keep that form.
- I'm glad you're adding SPDX lines, but do you know that the license is
correct in each case? It's best to be careful with such things.
Thanks,
jon
next prev parent reply other threads:[~2019-02-08 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 6:03 [PATCH 0/1] Start conversion of PowerPC docs Tobin C. Harding
2019-02-07 6:03 ` [PATCH 1/1] docs: powerpc: Convert to RST format Tobin C. Harding
2019-02-07 22:58 ` Randy Dunlap
2019-02-08 0:01 ` Jonathan Corbet [this message]
2019-02-08 3:40 ` [PATCH 0/1] Start conversion of PowerPC docs Michael Ellerman
2019-02-08 20:00 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207170131.1fd2bb03@lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tobin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).