From: Sam Bobroff <sbobroff@linux.ibm.com>
To: "Oliver O'Halloran" <oohall@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 4/7] powerpc/eeh_cache: Bump log level of eeh_addr_cache_print()
Date: Fri, 15 Feb 2019 16:12:55 +1100 [thread overview]
Message-ID: <20190215051255.GD8338@tungsten.ozlabs.ibm.com> (raw)
In-Reply-To: <20190215004817.19961-4-oohall@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]
On Fri, Feb 15, 2019 at 11:48:14AM +1100, Oliver O'Halloran wrote:
> To use this function at all #define DEBUG needs to be set in eeh_cache.c.
> Considering that printing at pr_debug is probably not all that useful since
> it adds the additional hurdle of requiring you to enable the debug print if
> dynamic_debug is in use so this patch bumps it to pr_info.
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Reviewed-by: Sam Bobroff <sbobroff@linux.ibm.com>
> ---
> arch/powerpc/kernel/eeh_cache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/eeh_cache.c b/arch/powerpc/kernel/eeh_cache.c
> index 5c5697cced41..9c68f0837385 100644
> --- a/arch/powerpc/kernel/eeh_cache.c
> +++ b/arch/powerpc/kernel/eeh_cache.c
> @@ -114,7 +114,7 @@ static void eeh_addr_cache_print(struct pci_io_addr_cache *cache)
> while (n) {
> struct pci_io_addr_range *piar;
> piar = rb_entry(n, struct pci_io_addr_range, rb_node);
> - pr_debug("PCI: %s addr range %d [%pap-%pap]: %s\n",
> + pr_info("PCI: %s addr range %d [%pap-%pap]: %s\n",
> (piar->flags & IORESOURCE_IO) ? "i/o" : "mem", cnt,
> &piar->addr_lo, &piar->addr_hi, pci_name(piar->pcidev));
> cnt++;
> --
> 2.20.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-15 5:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 0:48 [PATCH v2 1/7] powerpc/eeh: Use debugfs_create_u32 for eeh_max_freezes Oliver O'Halloran
2019-02-15 0:48 ` [PATCH v2 2/7] powerpc/eeh_cache: Add pr_debug() prints for insert/remove Oliver O'Halloran
2019-02-15 5:11 ` Sam Bobroff
2019-02-15 0:48 ` [PATCH v2 3/7] powerpc/eeh_cache: Add a way to dump the EEH address cache Oliver O'Halloran
2019-02-15 5:12 ` Sam Bobroff
2019-02-15 0:48 ` [PATCH v2 4/7] powerpc/eeh_cache: Bump log level of eeh_addr_cache_print() Oliver O'Halloran
2019-02-15 5:12 ` Sam Bobroff [this message]
2019-02-15 0:48 ` [PATCH v2 5/7] powerpc/pci: Add pci_find_controller_for_domain() Oliver O'Halloran
2019-02-15 5:13 ` Sam Bobroff
2019-02-15 0:48 ` [PATCH v2 6/7] powerpc/eeh: Allow disabling recovery Oliver O'Halloran
2019-02-15 5:58 ` Sam Bobroff
2019-02-17 23:19 ` Oliver
2019-02-15 0:48 ` [PATCH v2 7/7] powerpc/eeh: Add eeh_force_recover to debugfs Oliver O'Halloran
2019-02-15 5:10 ` [PATCH v2 1/7] powerpc/eeh: Use debugfs_create_u32 for eeh_max_freezes Sam Bobroff
2019-02-22 9:47 ` [v2,1/7] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215051255.GD8338@tungsten.ozlabs.ibm.com \
--to=sbobroff@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).