From: Peter Zijlstra <peterz@infradead.org>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
Michael Bringmann <mwb@linux.vnet.ibm.com>,
Ingo Molnar <mingo@redhat.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Nathan Fontenot <nfont@linux.vnet.ibm.com>,
Borislav Petkov <bp@suse.de>,
linuxppc-dev@lists.ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2] sched/topology: fix kernel crash when a CPU is hotplugged in a memoryless node
Date: Wed, 20 Feb 2019 18:08:41 +0100 [thread overview]
Message-ID: <20190220170841.GM32494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190220165520.5241-1-lvivier@redhat.com>
On Wed, Feb 20, 2019 at 05:55:20PM +0100, Laurent Vivier wrote:
> index 3f35ba1d8fde..372278605f0d 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -1651,6 +1651,7 @@ void sched_init_numa(void)
> */
> tl[i++] = (struct sched_domain_topology_level){
> .mask = sd_numa_mask,
> + .flags = SDTL_OVERLAP,
This makes no sense what so ever. The numa identify node should not have
overlap with other domains.
Are you sure this is not because of the utterly broken powerpc nonsense
where they move CPUs between nodes?
> .numa_level = 0,
> SD_INIT_NAME(NODE)
> };
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-02-20 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 16:55 [PATCH v2] sched/topology: fix kernel crash when a CPU is hotplugged in a memoryless node Laurent Vivier
2019-02-20 17:08 ` Peter Zijlstra [this message]
2019-02-20 17:57 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220170841.GM32494@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lvivier@redhat.com \
--cc=mingo@redhat.com \
--cc=mwb@linux.vnet.ibm.com \
--cc=nfont@linux.vnet.ibm.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox