* build failure of current mmotm with skiroot_defconfig
@ 2019-02-26 8:12 Mike Rapoport
2019-02-26 9:39 ` Christophe Leroy
0 siblings, 1 reply; 6+ messages in thread
From: Mike Rapoport @ 2019-02-26 8:12 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev, Andrew Morton, Paul Mackerras
Hi,
I've encountered the following error when building skyroot_defconfig with
current mmotm tree:
make CONFIG_OF_ALL_DTBS=y CONFIG_DTC=y CROSS_COMPILE=/opt/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ARCH=powerpc vmlinux
...
CC arch/powerpc/kernel/dbell.o
In file included from arch/powerpc/kernel/dbell.c:20:
arch/powerpc/include/asm/kvm_ppc.h: In function 'xics_on_xive':
arch/powerpc/include/asm/kvm_ppc.h:625:9: error: implicit declaration of function 'xive_enabled'; did you mean 'eeh_enabled'? [-Werror=implicit-function-declaration]
return xive_enabled() && cpu_has_feature(CPU_FTR_HVMODE);
^~~~~~~~~~~~
eeh_enabled
cc1: all warnings being treated as errors
scripts/Makefile.build:278: recipe for target 'arch/powerpc/kernel/dbell.o' failed
make[3]: *** [arch/powerpc/kernel/dbell.o] Error 1
scripts/Makefile.build:493: recipe for target 'arch/powerpc/kernel' failed
make[2]: *** [arch/powerpc/kernel] Error 2
Makefile:1049: recipe for target 'arch/powerpc' failed
make[1]: *** [arch/powerpc] Error 2
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: build failure of current mmotm with skiroot_defconfig
2019-02-26 8:12 build failure of current mmotm with skiroot_defconfig Mike Rapoport
@ 2019-02-26 9:39 ` Christophe Leroy
2019-02-26 9:59 ` Mike Rapoport
0 siblings, 1 reply; 6+ messages in thread
From: Christophe Leroy @ 2019-02-26 9:39 UTC (permalink / raw)
To: Mike Rapoport, Michael Ellerman
Cc: Paul Mackerras, Andrew Morton, linuxppc-dev
Le 26/02/2019 à 09:12, Mike Rapoport a écrit :
> Hi,
>
> I've encountered the following error when building skyroot_defconfig with
> current mmotm tree:
>
> make CONFIG_OF_ALL_DTBS=y CONFIG_DTC=y CROSS_COMPILE=/opt/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ARCH=powerpc vmlinux
> ...
> CC arch/powerpc/kernel/dbell.o
> In file included from arch/powerpc/kernel/dbell.c:20:
> arch/powerpc/include/asm/kvm_ppc.h: In function 'xics_on_xive':
> arch/powerpc/include/asm/kvm_ppc.h:625:9: error: implicit declaration of function 'xive_enabled'; did you mean 'eeh_enabled'? [-Werror=implicit-function-declaration]
> return xive_enabled() && cpu_has_feature(CPU_FTR_HVMODE);
> ^~~~~~~~~~~~
> eeh_enabled
I can neither find the above in arch/powerpc/include/asm/kvm_ppc.h in
the powerpc tree, nor a patch removing it.
Where does that comes from ?
Christophe
> cc1: all warnings being treated as errors
> scripts/Makefile.build:278: recipe for target 'arch/powerpc/kernel/dbell.o' failed
> make[3]: *** [arch/powerpc/kernel/dbell.o] Error 1
> scripts/Makefile.build:493: recipe for target 'arch/powerpc/kernel' failed
> make[2]: *** [arch/powerpc/kernel] Error 2
> Makefile:1049: recipe for target 'arch/powerpc' failed
> make[1]: *** [arch/powerpc] Error 2
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: build failure of current mmotm with skiroot_defconfig
2019-02-26 9:39 ` Christophe Leroy
@ 2019-02-26 9:59 ` Mike Rapoport
2019-02-26 22:24 ` Paul Mackerras
0 siblings, 1 reply; 6+ messages in thread
From: Mike Rapoport @ 2019-02-26 9:59 UTC (permalink / raw)
To: Christophe Leroy; +Cc: Andrew Morton, linuxppc-dev, Paul Mackerras
On Tue, Feb 26, 2019 at 10:39:54AM +0100, Christophe Leroy wrote:
>
>
> Le 26/02/2019 à 09:12, Mike Rapoport a écrit :
> >Hi,
> >
> >I've encountered the following error when building skyroot_defconfig with
> >current mmotm tree:
> >
> >make CONFIG_OF_ALL_DTBS=y CONFIG_DTC=y CROSS_COMPILE=/opt/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ARCH=powerpc vmlinux
> > ...
> > CC arch/powerpc/kernel/dbell.o
> >In file included from arch/powerpc/kernel/dbell.c:20:
> >arch/powerpc/include/asm/kvm_ppc.h: In function 'xics_on_xive':
> >arch/powerpc/include/asm/kvm_ppc.h:625:9: error: implicit declaration of function 'xive_enabled'; did you mean 'eeh_enabled'? [-Werror=implicit-function-declaration]
> > return xive_enabled() && cpu_has_feature(CPU_FTR_HVMODE);
> > ^~~~~~~~~~~~
> > eeh_enabled
>
> I can neither find the above in arch/powerpc/include/asm/kvm_ppc.h in the
> powerpc tree, nor a patch removing it.
>
> Where does that comes from ?
It's from current mmotm, probably some merge conflict...
> Christophe
>
> >cc1: all warnings being treated as errors
> >scripts/Makefile.build:278: recipe for target 'arch/powerpc/kernel/dbell.o' failed
> >make[3]: *** [arch/powerpc/kernel/dbell.o] Error 1
> >scripts/Makefile.build:493: recipe for target 'arch/powerpc/kernel' failed
> >make[2]: *** [arch/powerpc/kernel] Error 2
> >Makefile:1049: recipe for target 'arch/powerpc' failed
> >make[1]: *** [arch/powerpc] Error 2
> >
> >
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: build failure of current mmotm with skiroot_defconfig
2019-02-26 9:59 ` Mike Rapoport
@ 2019-02-26 22:24 ` Paul Mackerras
2019-02-27 6:41 ` Christophe Leroy
0 siblings, 1 reply; 6+ messages in thread
From: Paul Mackerras @ 2019-02-26 22:24 UTC (permalink / raw)
To: Mike Rapoport; +Cc: Andrew Morton, linuxppc-dev
On Tue, Feb 26, 2019 at 11:59:08AM +0200, Mike Rapoport wrote:
> On Tue, Feb 26, 2019 at 10:39:54AM +0100, Christophe Leroy wrote:
> >
> >
> > Le 26/02/2019 à 09:12, Mike Rapoport a écrit :
> > >Hi,
> > >
> > >I've encountered the following error when building skyroot_defconfig with
> > >current mmotm tree:
> > >
> > >make CONFIG_OF_ALL_DTBS=y CONFIG_DTC=y CROSS_COMPILE=/opt/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ARCH=powerpc vmlinux
> > > ...
> > > CC arch/powerpc/kernel/dbell.o
> > >In file included from arch/powerpc/kernel/dbell.c:20:
> > >arch/powerpc/include/asm/kvm_ppc.h: In function 'xics_on_xive':
> > >arch/powerpc/include/asm/kvm_ppc.h:625:9: error: implicit declaration of function 'xive_enabled'; did you mean 'eeh_enabled'? [-Werror=implicit-function-declaration]
> > > return xive_enabled() && cpu_has_feature(CPU_FTR_HVMODE);
> > > ^~~~~~~~~~~~
> > > eeh_enabled
> >
> > I can neither find the above in arch/powerpc/include/asm/kvm_ppc.h in the
> > powerpc tree, nor a patch removing it.
> >
> > Where does that comes from ?
>
> It's from current mmotm, probably some merge conflict...
It's not a merge conflict; see http://patchwork.ozlabs.org/patch/1048584/
for the fix.
Paul.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: build failure of current mmotm with skiroot_defconfig
2019-02-26 22:24 ` Paul Mackerras
@ 2019-02-27 6:41 ` Christophe Leroy
2019-02-27 11:13 ` Paul Mackerras
0 siblings, 1 reply; 6+ messages in thread
From: Christophe Leroy @ 2019-02-27 6:41 UTC (permalink / raw)
To: Paul Mackerras, Mike Rapoport; +Cc: Andrew Morton, linuxppc-dev
Le 26/02/2019 à 23:24, Paul Mackerras a écrit :
> On Tue, Feb 26, 2019 at 11:59:08AM +0200, Mike Rapoport wrote:
>> On Tue, Feb 26, 2019 at 10:39:54AM +0100, Christophe Leroy wrote:
>>>
>>>
>>> Le 26/02/2019 à 09:12, Mike Rapoport a écrit :
>>>> Hi,
>>>>
>>>> I've encountered the following error when building skyroot_defconfig with
>>>> current mmotm tree:
>>>>
>>>> make CONFIG_OF_ALL_DTBS=y CONFIG_DTC=y CROSS_COMPILE=/opt/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ARCH=powerpc vmlinux
>>>> ...
>>>> CC arch/powerpc/kernel/dbell.o
>>>> In file included from arch/powerpc/kernel/dbell.c:20:
>>>> arch/powerpc/include/asm/kvm_ppc.h: In function 'xics_on_xive':
>>>> arch/powerpc/include/asm/kvm_ppc.h:625:9: error: implicit declaration of function 'xive_enabled'; did you mean 'eeh_enabled'? [-Werror=implicit-function-declaration]
>>>> return xive_enabled() && cpu_has_feature(CPU_FTR_HVMODE);
>>>> ^~~~~~~~~~~~
>>>> eeh_enabled
>>>
>>> I can neither find the above in arch/powerpc/include/asm/kvm_ppc.h in the
>>> powerpc tree, nor a patch removing it.
>>>
>>> Where does that comes from ?
>>
>> It's from current mmotm, probably some merge conflict...
>
> It's not a merge conflict; see http://patchwork.ozlabs.org/patch/1048584/
> for the fix.
>
Why not include asm/xive.h all the time, as it defines xive_enabled()
for when CONFIG_PPC_XIVE is set and for when it is not set ?
Christophe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: build failure of current mmotm with skiroot_defconfig
2019-02-27 6:41 ` Christophe Leroy
@ 2019-02-27 11:13 ` Paul Mackerras
0 siblings, 0 replies; 6+ messages in thread
From: Paul Mackerras @ 2019-02-27 11:13 UTC (permalink / raw)
To: Christophe Leroy; +Cc: Andrew Morton, linuxppc-dev, Mike Rapoport
On Wed, Feb 27, 2019 at 07:41:21AM +0100, Christophe Leroy wrote:
>
>
> Le 26/02/2019 à 23:24, Paul Mackerras a écrit :
> >On Tue, Feb 26, 2019 at 11:59:08AM +0200, Mike Rapoport wrote:
> >>On Tue, Feb 26, 2019 at 10:39:54AM +0100, Christophe Leroy wrote:
> >>>
> >>>
> >>>Le 26/02/2019 à 09:12, Mike Rapoport a écrit :
> >>>>Hi,
> >>>>
> >>>>I've encountered the following error when building skyroot_defconfig with
> >>>>current mmotm tree:
> >>>>
> >>>>make CONFIG_OF_ALL_DTBS=y CONFIG_DTC=y CROSS_COMPILE=/opt/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ARCH=powerpc vmlinux
> >>>> ...
> >>>> CC arch/powerpc/kernel/dbell.o
> >>>>In file included from arch/powerpc/kernel/dbell.c:20:
> >>>>arch/powerpc/include/asm/kvm_ppc.h: In function 'xics_on_xive':
> >>>>arch/powerpc/include/asm/kvm_ppc.h:625:9: error: implicit declaration of function 'xive_enabled'; did you mean 'eeh_enabled'? [-Werror=implicit-function-declaration]
> >>>> return xive_enabled() && cpu_has_feature(CPU_FTR_HVMODE);
> >>>> ^~~~~~~~~~~~
> >>>> eeh_enabled
> >>>
> >>>I can neither find the above in arch/powerpc/include/asm/kvm_ppc.h in the
> >>>powerpc tree, nor a patch removing it.
> >>>
> >>>Where does that comes from ?
> >>
> >>It's from current mmotm, probably some merge conflict...
> >
> >It's not a merge conflict; see http://patchwork.ozlabs.org/patch/1048584/
> >for the fix.
> >
>
> Why not include asm/xive.h all the time, as it defines xive_enabled() for
> when CONFIG_PPC_XIVE is set and for when it is not set ?
I wasn't sure it wouldn't break the build for 32-bit configs.
Paul.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-27 11:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-26 8:12 build failure of current mmotm with skiroot_defconfig Mike Rapoport
2019-02-26 9:39 ` Christophe Leroy
2019-02-26 9:59 ` Mike Rapoport
2019-02-26 22:24 ` Paul Mackerras
2019-02-27 6:41 ` Christophe Leroy
2019-02-27 11:13 ` Paul Mackerras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).