From: Paul Mackerras <paulus@ozlabs.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, Mike Rapoport <rppt@linux.ibm.com>
Subject: Re: build failure of current mmotm with skiroot_defconfig
Date: Wed, 27 Feb 2019 22:13:14 +1100 [thread overview]
Message-ID: <20190227111314.GA15195@blackberry> (raw)
In-Reply-To: <fea8a5ef-2c90-8222-fc80-3ae77a2fd473@c-s.fr>
On Wed, Feb 27, 2019 at 07:41:21AM +0100, Christophe Leroy wrote:
>
>
> Le 26/02/2019 à 23:24, Paul Mackerras a écrit :
> >On Tue, Feb 26, 2019 at 11:59:08AM +0200, Mike Rapoport wrote:
> >>On Tue, Feb 26, 2019 at 10:39:54AM +0100, Christophe Leroy wrote:
> >>>
> >>>
> >>>Le 26/02/2019 à 09:12, Mike Rapoport a écrit :
> >>>>Hi,
> >>>>
> >>>>I've encountered the following error when building skyroot_defconfig with
> >>>>current mmotm tree:
> >>>>
> >>>>make CONFIG_OF_ALL_DTBS=y CONFIG_DTC=y CROSS_COMPILE=/opt/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ARCH=powerpc vmlinux
> >>>> ...
> >>>> CC arch/powerpc/kernel/dbell.o
> >>>>In file included from arch/powerpc/kernel/dbell.c:20:
> >>>>arch/powerpc/include/asm/kvm_ppc.h: In function 'xics_on_xive':
> >>>>arch/powerpc/include/asm/kvm_ppc.h:625:9: error: implicit declaration of function 'xive_enabled'; did you mean 'eeh_enabled'? [-Werror=implicit-function-declaration]
> >>>> return xive_enabled() && cpu_has_feature(CPU_FTR_HVMODE);
> >>>> ^~~~~~~~~~~~
> >>>> eeh_enabled
> >>>
> >>>I can neither find the above in arch/powerpc/include/asm/kvm_ppc.h in the
> >>>powerpc tree, nor a patch removing it.
> >>>
> >>>Where does that comes from ?
> >>
> >>It's from current mmotm, probably some merge conflict...
> >
> >It's not a merge conflict; see http://patchwork.ozlabs.org/patch/1048584/
> >for the fix.
> >
>
> Why not include asm/xive.h all the time, as it defines xive_enabled() for
> when CONFIG_PPC_XIVE is set and for when it is not set ?
I wasn't sure it wouldn't break the build for 32-bit configs.
Paul.
prev parent reply other threads:[~2019-02-27 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 8:12 build failure of current mmotm with skiroot_defconfig Mike Rapoport
2019-02-26 9:39 ` Christophe Leroy
2019-02-26 9:59 ` Mike Rapoport
2019-02-26 22:24 ` Paul Mackerras
2019-02-27 6:41 ` Christophe Leroy
2019-02-27 11:13 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227111314.GA15195@blackberry \
--to=paulus@ozlabs.org \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@c-s.fr \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).