Re: [PULL REQUEST] powerpc generic command line

[Daniel Walker <danielwa@cisco.com>]

On Mon, Mar 04, 2019 at 02:55:08PM +0100, Christophe Leroy wrote:
> 
> 
> Le 01/03/2019 à 20:44, Daniel Walker a écrit :
> > Here are the generic command line changes for powerpc.
> > 
> > These changes have been in linux-next for two cycles, with few problems reported.
> > It's also been used at Cisco Systems, Inc. in production products for many many
> > years with no problems.
> > 
> > Please pull these changes.
> > 
> > 
> > The following changes since commit ccda4af0f4b92f7b4c308d3acc262f4a7e3affad:
> > 
> >    Linux 4.20-rc2 (2018-11-11 17:12:31 -0600)
> > 
> > are available in the git repository at:
> > 
> >    https://github.com/daniel-walker/cisco-linux.git for-powerpc
> > 
> > for you to fetch changes up to 5d4514a9c291ecf19b0626695161673d35e5d549:
> > 
> >    powerpc: convert config files to generic cmdline (2018-11-16 07:32:26 -0800)
> > 
> > ----------------------------------------------------------------
> > Daniel Walker (3):
> >        add generic builtin command line
> >        powerpc: convert to generic builtin command line
> >        powerpc: convert config files to generic cmdline
> 
> Hello,
> 
> This series is in total contradiction with the work being done to add KASAN
> support to powerpc.
> 
> It also modifies the behaviour for powerpc.
> 
> Please do not apply this series as is, see my comments on the individual
> patchs for details.
> 

Not trying to offend you, but you comments seems overly alarmist. KASAN is a
debug feature, generally we don't write code around debug features (especially
ones which aren't merged yet). It would not be hard to correct our use of string
functions when your KASAN enablement is merged, I'm sure you could do it, but I would be happy
to do it also. The other comments you had I don't think rise to the level of
stopping a pull request. Our code is stabilized, so I'm not going to
re-design it at a late date like this.

I think the pull request is still valid.

Daniel