linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
To: Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
	syzkaller@googlegroups.com, Paul Mackerras <paulus@samba.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	Andrew Donnellan <andonnel@au1.ibm.com>
Subject: Re: [PATCH] Disable kcov for slb routines.
Date: Thu, 7 Mar 2019 10:07:36 +0530	[thread overview]
Message-ID: <20190307043736.GA1809@sathnaga86> (raw)
In-Reply-To: <155168793242.4372.10864050702181452671.stgit@jupiter.in.ibm.com>

On Mon, Mar 04, 2019 at 01:55:51PM +0530, Mahesh J Salgaonkar wrote:
> From: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
> 
> The kcov instrumentation inside SLB routines causes duplicate SLB entries
> to be added resulting into SLB multihit machine checks.
> Disable kcov instrumentation on slb.o
> 
> Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
> ---
>  arch/powerpc/mm/Makefile |    1 +
>  1 file changed, 1 insertion(+)

Fixes: https://github.com/linuxppc/issues/issues/230

Tested-by: Satheesh Rajendran <sathnaga@linux.vent.ibm.com>

> 
> diff --git a/arch/powerpc/mm/Makefile b/arch/powerpc/mm/Makefile
> index d4d32e229ace..f9cb40684746 100644
> --- a/arch/powerpc/mm/Makefile
> +++ b/arch/powerpc/mm/Makefile
> @@ -60,3 +60,4 @@ obj-$(CONFIG_PPC_MEM_KEYS)	+= pkeys.o
>  # This is necessary for booting with kcov enabled on book3e machines
>  KCOV_INSTRUMENT_tlb_nohash.o := n
>  KCOV_INSTRUMENT_fsl_booke_mmu.o := n
> +KCOV_INSTRUMENT_slb.o := n
> 


  parent reply	other threads:[~2019-03-07  4:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04  8:25 [PATCH] Disable kcov for slb routines Mahesh J Salgaonkar
2019-03-05  3:31 ` Andrew Donnellan
2019-03-07  4:37 ` Satheesh Rajendran [this message]
2019-03-14 11:43 ` Michael Ellerman
2019-03-15  5:01   ` Mahesh Jagannath Salgaonkar
2019-03-20 12:51     ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190307043736.GA1809@sathnaga86 \
    --to=sathnaga@linux.vnet.ibm.com \
    --cc=andonnel@au1.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    --cc=syzkaller@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).