From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8962CC43381 for ; Sat, 16 Mar 2019 14:23:18 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACB7A21900 for ; Sat, 16 Mar 2019 14:23:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Fe6PdOGD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACB7A21900 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44M4Rl47k1zDqTL for ; Sun, 17 Mar 2019 01:23:15 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=jic23@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Fe6PdOGD"; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44M4Q45PrYzDqB3 for ; Sun, 17 Mar 2019 01:21:48 +1100 (AEDT) Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1BB821900; Sat, 16 Mar 2019 14:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552746105; bh=TLmhwtGQN4VfA785J1wHBRYladJMghsxUN/gvs2WAtQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Fe6PdOGDhGUycaeQPVznagNh/h87ljYHfugz3ota5Azqa76QT8/MPpDUfjhpDQgAJ vGRKSXM/rlzMxmMBBMI1KapR7Ls9+wdihG5JPj85l7VG9Oe+RfoudoEgtydpB3oiiH an0VU2n8chVwD8TI3MM+GqQvpaij9B1WbhcNKUI4= Date: Sat, 16 Mar 2019 14:21:38 +0000 From: Jonathan Cameron To: Rob Herring Subject: Re: [PATCH v2 4/7] dt-bindings: counter: ftm-quaddec Message-ID: <20190316142138.65860d88@archlinux> In-Reply-To: <20190312190952.GA18547@bogus> References: <20190306111208.7454-1-patrick.havelange@essensium.com> <20190306111208.7454-5-patrick.havelange@essensium.com> <20190312190952.GA18547@bogus> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org, Patrick Havelange , Daniel Lezcano , William Breathitt Gray , Li Yang , Thierry Reding , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Shawn Guo , Esben Haabendal Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 12 Mar 2019 14:09:52 -0500 Rob Herring wrote: > On Wed, Mar 06, 2019 at 12:12:05PM +0100, Patrick Havelange wrote: > > FlexTimer quadrature decoder driver. > > > > Signed-off-by: Patrick Havelange > > Reviewed-by: Esben Haabendal > > --- > > Changes v2 > > - None > > --- > > .../bindings/counter/ftm-quaddec.txt | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/counter/ftm-quaddec.txt > > > > diff --git a/Documentation/devicetree/bindings/counter/ftm-quaddec.txt b/Documentation/devicetree/bindings/counter/ftm-quaddec.txt > > new file mode 100644 > > index 000000000000..4d18cd722074 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/counter/ftm-quaddec.txt > > @@ -0,0 +1,18 @@ > > +FlexTimer Quadrature decoder counter > > + > > +This driver exposes a simple counter for the quadrature decoder mode. > > Seems like this is more a mode of a h/w block than describing a h/w > block. Bindings should do the latter. The snag is that we need to dig ourselves out of the hole set by: fsl,vf610-ftm-pwm etc. Documentation/devicetree/bindings/pwm/pwm-fsl-ftm.txt Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt (I'm assuming these are the same IP block). Can probably be sorted out though. One core driver binds against the ftm and deals with instantiating the others depending on the configuration (note that this mode for instance does make sense in DT as it's really reflecting the fact there is a quadrature encoder connected to the ftm). Fiddly though :) J > > > + > > +Required properties: > > +- compatible: Must be "fsl,ftm-quaddec". > > +- reg: Must be set to the memory region of the flextimer. > > + > > +Optional property: > > +- big-endian: Access the device registers in big-endian mode. > > + > > +Example: > > + counter0: counter@29d0000 { > > + compatible = "fsl,ftm-quaddec"; > > + reg = <0x0 0x29d0000 0x0 0x10000>; > > + big-endian; > > + status = "disabled"; > > + }; > > -- > > 2.19.1 > >