linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Michael Neuling <mikey@neuling.org>
Cc: mikey@neuling.org, linuxppc-dev@lists.ozlabs.org,
	kbuild-all@01.org, Cameron Kaiser <spectre@floodgap.com>
Subject: Re: [PATCH] powerpc: Add force enable of DAWR on P9 option
Date: Tue, 26 Mar 2019 15:48:20 +0800	[thread overview]
Message-ID: <201903261547.dYN2kJcV%lkp@intel.com> (raw)
In-Reply-To: <20190326054022.5552-1-mikey@neuling.org>

[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]

Hi Michael,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.1-rc2 next-20190326]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Michael-Neuling/powerpc-Add-force-enable-of-DAWR-on-P9-option/20190326-135550
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allnoconfig (attached as .config)
compiler: powerpc-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   arch/powerpc/kernel/process.c: In function '__set_breakpoint':
>> arch/powerpc/kernel/process.c:820:6: error: implicit declaration of function 'dawr_enabled'; did you mean 'radix_enabled'? [-Werror=implicit-function-declaration]
     if (dawr_enabled())
         ^~~~~~~~~~~~
         radix_enabled
   cc1: all warnings being treated as errors

vim +820 arch/powerpc/kernel/process.c

   815	
   816	void __set_breakpoint(struct arch_hw_breakpoint *brk)
   817	{
   818		memcpy(this_cpu_ptr(&current_brk), brk, sizeof(*brk));
   819	
 > 820		if (dawr_enabled())
   821			// Power8 or later
   822			set_dawr(brk);
   823		else if (!cpu_has_feature(CPU_FTR_ARCH_207S))
   824			// Power7 or earlier
   825			set_dabr(brk);
   826		else
   827			// Shouldn't happen due to higher level checks
   828			WARN_ON_ONCE(1);
   829	}
   830	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 5706 bytes --]

  reply	other threads:[~2019-03-26  7:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26  5:40 [PATCH] powerpc: Add force enable of DAWR on P9 option Michael Neuling
2019-03-26  7:48 ` kbuild test robot [this message]
2019-03-26  8:48 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201903261547.dYN2kJcV%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=spectre@floodgap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).