* [RFC PATCH] drivers/dax: Allow to include DEV_DAX_PMEM as builtin
@ 2019-03-30 5:42 Aneesh Kumar K.V
2019-03-30 15:33 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Aneesh Kumar K.V @ 2019-03-30 5:42 UTC (permalink / raw)
To: dan.j.williams; +Cc: linux-mm, linuxppc-dev, Aneesh Kumar K.V, linux-nvdimm
This move the dependency to DEV_DAX_PMEM_COMPAT such that only
if DEV_DAX_PMEM is built as module we can allow the compat support.
This allows to test the new code easily in a emulation setup where we
often build things without module support.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
---
drivers/dax/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig
index 5ef624fe3934..e582e088b48c 100644
--- a/drivers/dax/Kconfig
+++ b/drivers/dax/Kconfig
@@ -23,7 +23,6 @@ config DEV_DAX
config DEV_DAX_PMEM
tristate "PMEM DAX: direct access to persistent memory"
depends on LIBNVDIMM && NVDIMM_DAX && DEV_DAX
- depends on m # until we can kill DEV_DAX_PMEM_COMPAT
default DEV_DAX
help
Support raw access to persistent memory. Note that this
@@ -50,7 +49,7 @@ config DEV_DAX_KMEM
config DEV_DAX_PMEM_COMPAT
tristate "PMEM DAX: support the deprecated /sys/class/dax interface"
- depends on DEV_DAX_PMEM
+ depends on DEV_DAX_PMEM=m
default DEV_DAX_PMEM
help
Older versions of the libdaxctl library expect to find all
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC PATCH] drivers/dax: Allow to include DEV_DAX_PMEM as builtin
2019-03-30 5:42 [RFC PATCH] drivers/dax: Allow to include DEV_DAX_PMEM as builtin Aneesh Kumar K.V
@ 2019-03-30 15:33 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2019-03-30 15:33 UTC (permalink / raw)
To: Aneesh Kumar K.V; +Cc: Linux MM, linuxppc-dev, linux-nvdimm
On Fri, Mar 29, 2019 at 10:42 PM Aneesh Kumar K.V
<aneesh.kumar@linux.ibm.com> wrote:
>
> This move the dependency to DEV_DAX_PMEM_COMPAT such that only
> if DEV_DAX_PMEM is built as module we can allow the compat support.
>
> This allows to test the new code easily in a emulation setup where we
> often build things without module support.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> ---
> drivers/dax/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig
> index 5ef624fe3934..e582e088b48c 100644
> --- a/drivers/dax/Kconfig
> +++ b/drivers/dax/Kconfig
> @@ -23,7 +23,6 @@ config DEV_DAX
> config DEV_DAX_PMEM
> tristate "PMEM DAX: direct access to persistent memory"
> depends on LIBNVDIMM && NVDIMM_DAX && DEV_DAX
> - depends on m # until we can kill DEV_DAX_PMEM_COMPAT
> default DEV_DAX
> help
> Support raw access to persistent memory. Note that this
> @@ -50,7 +49,7 @@ config DEV_DAX_KMEM
>
> config DEV_DAX_PMEM_COMPAT
> tristate "PMEM DAX: support the deprecated /sys/class/dax interface"
> - depends on DEV_DAX_PMEM
> + depends on DEV_DAX_PMEM=m
Looks ok, just also a needs a "depends on m" here, because
DEV_DAX_PMEM_COMPAT=y is an invalid config.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-30 15:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-30 5:42 [RFC PATCH] drivers/dax: Allow to include DEV_DAX_PMEM as builtin Aneesh Kumar K.V
2019-03-30 15:33 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).