From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Andrey Abramov <st5pub@yandex.ru>
Cc: "mhocko@suse.com" <mhocko@suse.com>,
"gustavo@embeddedor.com" <gustavo@embeddedor.com>,
"peterz@infradead.org" <peterz@infradead.org>,
Dave Chinner <dchinner@redhat.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"piaojun@huawei.com" <piaojun@huawei.com>,
"yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
"paulus@samba.org" <paulus@samba.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"jiang.biao2@zte.com.cn" <jiang.biao2@zte.com.cn>,
"jslaby@suse.cz" <jslaby@suse.cz>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"darrick.wong@oracle.com" <darrick.wong@oracle.com>,
"richard@nod.at" <richard@nod.at>,
"mark@fasheh.com" <mark@fasheh.com>,
"x86@kernel.org" <x86@kernel.org>,
"yuehaibing@huawei.com" <yuehaibing@huawei.com>,
"lchen@suse.com" <lchen@suse.com>,
"rppt@linux.ibm.com" <rppt@linux.ibm.com>,
"ge.changwei@h3c.com" <ge.changwei@h3c.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"naveen.n.rao@linux.vnet.ibm.com"
<naveen.n.rao@linux.vnet.ibm.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"kamalesh@linux.vnet.ibm.com" <kamalesh@linux.vnet.ibm.com>,
"amir73il@gmail.com" <amir73il@gmail.com>,
"keescook@chromium.org" <keescook@chromium.org>,
"jannh@google.com" <jannh@google.com>,
"ashish.samant@oracle.com" <ashish.samant@oracle.com>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"jiangyiwen@huawei.com" <jiangyiwen@huawei.com>,
"bp@alien8.de" <bp@alien8.de>,
"jlbec@evilplan.org" <jlbec@evilplan.org>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
George Spelvin <lkml@sdf.org>,
"dedekind1@gmail.com" <dedekind1@gmail.com>,
"malat@debian.org" <malat@debian.org>,
"vgupta@synopsys.com" <vgupta@synopsys.com>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Morton Andrew <akpm@linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>
Subject: Re: [PATCH 5/5] Lib: sort.h: replace int size with size_t size in the swap function
Date: Sat, 30 Mar 2019 19:38:26 +0100 [thread overview]
Message-ID: <20190330183826.GB21828@kroah.com> (raw)
In-Reply-To: <20467491553964233@myt4-c0b480c282c8.qloud-c.yandex.net>
On Sat, Mar 30, 2019 at 07:43:53PM +0300, Andrey Abramov wrote:
> Replace int type with size_t type of the size argument
> in the swap function, also affect all its dependencies.
This says _what_ the patch does, but it gives no clue as to _why_ you
are doing this. Neither did your 0/5 patch :(
Why make this change? Nothing afterward depends on it from what I can
tell, so why is it needed?
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-30 18:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 16:37 [PATCH 0/5] simple sort swap function usage improvements Andrey Abramov
2019-03-30 16:40 ` [PATCH 1/5] arch/arc: unwind.c: replace swap function with built-in one Andrey Abramov
2019-03-30 16:41 ` [PATCH 2/5] powerpc: module_[32|64].c: " Andrey Abramov
2019-04-01 10:11 ` Michael Ellerman
2019-04-02 19:11 ` Andrey Abramov
2019-03-30 16:42 ` [PATCH 3/5] ocfs2: dir, refcounttree, xattr: replace swap functions " Andrey Abramov
2019-03-30 16:43 ` [PATCH 4/5] ubifs: find.c: replace swap function " Andrey Abramov
2019-03-30 16:43 ` [PATCH 5/5] Lib: sort.h: replace int size with size_t size in the swap function Andrey Abramov
2019-03-30 18:38 ` gregkh [this message]
2019-03-30 17:16 ` [PATCH 0/5] simple sort swap function usage improvements George Spelvin
2019-03-30 18:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190330183826.GB21828@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=ashish.samant@oracle.com \
--cc=bp@alien8.de \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=dedekind1@gmail.com \
--cc=ge.changwei@h3c.com \
--cc=gustavo@embeddedor.com \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=jiang.biao2@zte.com.cn \
--cc=jiangyiwen@huawei.com \
--cc=jlbec@evilplan.org \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=keescook@chromium.org \
--cc=lchen@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkml@sdf.org \
--cc=malat@debian.org \
--cc=mark@fasheh.com \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=piaojun@huawei.com \
--cc=richard@nod.at \
--cc=rppt@linux.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=st5pub@yandex.ru \
--cc=tglx@linutronix.de \
--cc=vgupta@synopsys.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox